Re: [Freeciv-Dev] (PR#40113) civclient: player.c:293: player_number: Assertion `pplayer' failed.

2008-02-25 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 Now that I've had some sleep Madeline Book wrote: Yes, I was afraid of something like that. So what are the semantics of client.playing? It is set from game.info.player_idx -- exclusively. Is it supposed to be NULL when the

[Freeciv-Dev] (PR#40113) civclient: player.c:293: player_number: Assertion `pplayer' failed.

2008-02-25 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 [wsimpson - Mon Feb 25 13:02:09 2008]: Now that I've had some sleep Madeline Book wrote: Yes, I was afraid of something like that. So what are the semantics of client.playing? It is set from game.info.player_idx --

[Freeciv-Dev] (PR#40113) civclient: player.c:293: player_number: Assertion `pplayer' failed.

2008-02-25 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 [wsimpson - Mon Feb 25 22:15:57 2008]: Madeline Book wrote: So I supposed it should be set for clients connecting to a server somewhere remotely (e.g. a to play a game online). It should be set by the server and sent to

[Freeciv-Dev] (PR#40113) civclient: player.c:293: player_number: Assertion `pplayer' failed.

2008-02-24 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 After updating my working tree with latest S2_2 branch (r14422) I get an assertion failure in the client when trying to start a new game. Steps to reproduce: 1. Start a server in one console (e.g. run ./ser). 2. Start a client in

Re: [Freeciv-Dev] (PR#40113) civclient: player.c:293: player_number: Assertion `pplayer' failed.

2008-02-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 Cannot duplicate, running client with internal server. Tried random nation button (my usual test), random nation button on nation dialog, and picking specific nation. All work. ___

[Freeciv-Dev] (PR#40113) civclient: player.c:293: player_number: Assertion `pplayer' failed.

2008-02-24 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 [book - Mon Feb 25 02:47:42 2008]: I will see if I cannot fix this (kind of hard to work on the editor if I cannot start a game ;)). So here is a quick patch that addresses the underlying cause as I understand it at the moment.

[Freeciv-Dev] (PR#40113) civclient: player.c:293: player_number: Assertion `pplayer' failed.

2008-02-24 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 [wsimpson - Mon Feb 25 03:22:41 2008]: Cannot duplicate, running client with internal server. Tried random nation button (my usual test), random nation button on nation dialog, and picking specific nation. All work. I did say to

Re: [Freeciv-Dev] (PR#40113) civclient: player.c:293: player_number: Assertion `pplayer' failed.

2008-02-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 This appears to be wrong. This might set client.playing for an observer, which would violate quite a bit of existing logic. It should not be possible for an observer to pick a nation. Is that what you tried? (You didn't mention that

Re: [Freeciv-Dev] (PR#40113) civclient: player.c:293: player_number: Assertion `pplayer' failed.

2008-02-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40113 I have examined all instances of send_conn_info(), and with one exception, they seem to come after send_player_info() -- which is how client.playing is set. Please post the exact commands that you send. And have you tested with any