[Freeciv-Dev] [bug #15144] notradesize not honored for capital city

2010-01-19 Thread George Koehler

Follow-up Comment #5, bug #15144 (project freeciv):

This bug happened because Freeciv used normal corruption for
notradesize/fulltradesize. Improvements that reduce corruption (Courthouse
and Palace) worked against notradesize/fulltradesize.

I played a game with notradesize=2, fulltradesize=4. Some capital city lost
its only trade point to corruption, but some other capital city had trade
surplus, when all capital cities were size 1 or size 2. Later, I noticed that
AI built Courthouse in many cities. Courthouse increased trade in size 2 and
size 3 cities, including if government was Democracy.

The patch might fix notradesize but not fulltradesize. After I update
Freeciv, I might want to check if Courthouse can still increase trade in
cities between notradesize and fulltradesize; if so, then I might open
another bug.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15144] notradesize not honored for capital city

2010-01-19 Thread pepeto

Update of bug #15144 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15144] notradesize not honored for capital city

2010-01-18 Thread pepeto

Update of bug #15144 (project freeciv):

  Status:   Confirmed => Ready For Test 
 Assigned to:None => pepeto 
 Planned Release: => 2.2.0  

___

Follow-up Comment #2:

Fix attached for S2_2 and trunk only.

As the change is in the common part and S2_1 is released for a long time, it
would break the compatibility of the rules in this branch.  We will probably
that bug in it then.


(file #7715)
___

Additional Item Attachment:

File name: trunk_S2_2_notradesize.diffSize:0 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15144] notradesize not honored for capital city

2010-01-17 Thread pepeto

Update of bug #15144 (project freeciv):

  Status:None => Confirmed  

___

Follow-up Comment #1:

I confirm in branches S2_1, S2_2 and trunk.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #15144] notradesize not honored for capital city

2010-01-17 Thread anonymous

URL:
  

 Summary: notradesize not honored for capital city
 Project: Freeciv
Submitted by: None
Submitted on: Sunday 01/17/10 at 22:08 CET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.2beta2
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

Probably is WAD, but the notradesize option is not honored for capital city.
I mean, if I set notradesize=5 and fulltradesize=9, the capital always get
same trade also if its population is less then 5.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev