[Freeciv-Dev] [bug #15333] Natural city names should ignore hints for unknown terrain types
Update of bug #15333 (project freeciv): Status: Ready For Test = In Progress ___ Reply to this item at: http://gna.org/bugs/?15333 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15333] Natural city names should ignore hints for unknown terrain types
Update of bug #15333 (project freeciv): Status: In Progress = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?15333 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15333] Natural city names should ignore hints for unknown terrain types
Update of bug #15333 (project freeciv): Status:None = Ready For Test Assigned to:None = jtn Planned Release: = 2.2.1 ___ Follow-up Comment #6: Patches for S2_2 and trunk attached: * Unknown city terrain hints are logged at LOG_VERBOSE instead of LOG_ERROR. Behaviour is unchanged: just the offending terrain type is ignored, all other types and the city are still used. * Unknown conflicts_with nations now logged in the same way as unknown civilwar nations (LOG_VERBOSE); previously they were silently ignored. * num_conflicts member removed from nation struct; conflicts_with is now terminated with sentinel NO_NATION_SELECTED in the same way as civilwar_nations. (file #8258, file #8259) ___ Additional Item Attachment: File name: S2_2-nation-ruleset-diagnostics.diff Size:2 KB File name: trunk-nation-ruleset-diagnostics.diff Size:3 KB ___ Reply to this item at: http://gna.org/bugs/?15333 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15333] Natural city names should ignore hints for unknown terrain types
Follow-up Comment #3, bug #15333 (project freeciv): It turns out there already is such an option, as I learned in bug #15378: -debug 3 (Thanks Jacob. :) ) Then I guess it would be trivial to change is to that these error messages are shown only when the server is running in debug mode. One thought, though, is whether a nonexistent terrain hint causes the whole city to be ignored, all terrain hints, or just the mismatching terrain hint itself? ___ Reply to this item at: http://gna.org/bugs/?15333 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15333] Natural city names should ignore hints for unknown terrain types
Follow-up Comment #5, bug #15333 (project freeciv): One thought, though, is whether a nonexistent terrain hint causes the whole city to be ignored, all terrain hints, or just the mismatching terrain hint itself? The last, for my money. You've already got a plan to tell anyone who might be listening, and this seems like the most graceful degradation, and fixes my original issue of using nations mentioning lakes with civ2 rules. ___ Reply to this item at: http://gna.org/bugs/?15333 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15333] Natural city names should ignore hints for unknown terrain types
Follow-up Comment #1, bug #15333 (project freeciv): These error messages are of great use for me personally, since I often edit nationsets. They've helped me catch numerous typos (mine and others.) As a matter of fact, I'd love it if f.e. misspelled civilwar_nations and conflicts_with were caught as well. Could we have some kind of 'verbose' mode for the server that is turned off by default but could be enabled on runtime? ___ Reply to this item at: http://gna.org/bugs/?15333 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15333] Natural city names should ignore hints for unknown terrain types
Follow-up Comment #2, bug #15333 (project freeciv): Another approach would be to bless a certain set of fixed terrain types as usable in city descriptions, but that wouldn't be ideal for people making modpacks (Barad-dûr (mountains, lava, skulls)). I like your idea better -- freeciv-server -pedantic. ___ Reply to this item at: http://gna.org/bugs/?15333 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15333] Natural city names should ignore hints for unknown terrain types
URL: http://gna.org/bugs/?15333 Summary: Natural city names should ignore hints for unknown terrain types Project: Freeciv Submitted by: jtn Submitted on: Thursday 11/02/10 at 10:18 Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: With the civ2 ruleset, the Aztec nation on S2_2 is currently giving the following warning: data/civ2/nations.ruleset [nation_aztec] cities: terrain lake not found; skipping it. last message repeated 2 times This is presumably because some of its cities have lake as their terrain hint (I think this came in in patch #1435), but that terrain doesn't exist in the civ2 ruleset (only the default rules). Since the terrain is only a hint, I think that terrain types unknown in the current ruleset should just be ignored. This does mean that typos won't be picked up, but the alternative is a continual source of warnings for non-default rulesets and inability to add any new terrain types added to the default ruleset. ___ Reply to this item at: http://gna.org/bugs/?15333 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
