[Freeciv-Dev] [bug #15500] do not change the status of the connection of the client to the server

[pepeto]

Update of bug #15500 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15500] do not change the status of the connection of the client to the server

[Matthias Pfafferodt]

Follow-up Comment #6, bug #15500 (project freeciv):

works as expected ...

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15500] do not change the status of the connection of the client to the server

[pepeto]

Update of bug #15500 (project freeciv):

  Status: In Progress => Ready For Test 
 Assigned to:None => pepeto 

___

Additional Item Attachment:

File name: trunk_client_conn.diff Size:3 KB
File name: S2_2_client_conn.diff  Size:3 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15500] do not change the status of the connection of the client to the server

[pepeto]

Update of bug #15500 (project freeciv):

  Status:  Ready For Test => In Progress

___

Follow-up Comment #5:

I am very unsure this is correct, those values are used for displaying the
connection list on the start page. The detaching state would have strange
behaviour if the username is not set.

I guess I did a mistake removing the duplicate of our connection (patch
#1326). We should probably reverse partially this patch and *document* why
it's not a good idea.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15500] do not change the status of the connection of the client to the server

[Matthias Pfafferodt]

Follow-up Comment #4, bug #15500 (project freeciv):

I don't know if I understand this code correct but here is my
interpretation:

the added condition prevents the client to change the data / information
about the server. The server will never change, i.e. at least the address,
capabilities and username of the connection to the server will be constant as
long as this connection exists. So one patch in-between: only this values are
not change for the client's connection to the server. I tested it doing
different combinations of 

* (re)connect to the server as observer; leave
* (re)connect; edit mode on / off; leave 
* (re)connect as player; leave
* (re)connect using another user name; leave


(file #8314)
___

Additional Item Attachment:

File name:
version3-20100227-S2_2-do-not-change-the-status-of-the-connection-of-the-cl.patch
Size:1 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15500] do not change the status of the connection of the client to the server

[pepeto]

Follow-up Comment #3, bug #15500 (project freeciv):

Ouch, this is very dangerous, the client won't know anymore what is its
current state (e.g. player target, observing state, etc)... This item really
need more work.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15500] do not change the status of the connection of the client to the server

[Matthias Pfafferodt]

Update of bug #15500 (project freeciv):

  Status:None => Ready For Test 
 Planned Release: => 2.2.1, 2.3.0   

___

Follow-up Comment #2:

> I would prefer the test if (pconn != &client.conn).

Done. Furthermore all data of the connection is included within the
condition.

Patch for S2_2 and trunk

(file #8312)
___

Additional Item Attachment:

File name:
version2-20100227-S2_2-do-not-change-the-status-of-the-connection-of-the-cl.patch
Size:1 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15500] do not change the status of the connection of the client to the server

[pepeto]

Follow-up Comment #1, bug #15500 (project freeciv):

I would prefer the test if (pconn != &client.conn).

___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15500] do not change the status of the connection of the client to the server

[Matthias Pfafferodt]

URL:
  

 Summary: do not change the status of the connection of the
client to the server
 Project: Freeciv
Submitted by: syntron
Submitted on: Samstag 27.02.2010 um 20:04
Category: general
Severity: 4 - Important
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.2.0
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

within handle_conn_info() the server capabilities are changed (see bug
#15499); a hack to prevent updates of the server capability string is
attached. If someone knows a better solution he is welcome

This problem should (?) also be valid for trunk



___

File Attachments:


---
Date: Samstag 27.02.2010 um 20:04  Name:
20100227-S2_2-do-not-change-the-status-of-the-connection-of-the-cl.patch 
Size: 920B   By: syntron



___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev