[Freeciv-Dev] [bug #15710] Lack of generality for specialists in city report / citizen governor display

[Jacob Nevins]

Update of bug #15710 (project freeciv):

  Status: In Progress => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15710] Lack of generality for specialists in city report / citizen governor display

[Jacob Nevins]

Update of bug #15710 (project freeciv):

  Status:  Ready For Test => In Progress


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15710] Lack of generality for specialists in city report / citizen governor display

[Jacob Nevins]

Additional Item Attachment, bug #15710 (project freeciv):

File name: trunk-test-extra-specialist.diff Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15710] Lack of generality for specialists in city report / citizen governor display

[Jacob Nevins]

URL:
  

 Summary: Lack of generality for specialists in city report /
citizen governor display
 Project: Freeciv
Submitted by: jtn
Submitted on: Saturday 03/27/10 at 13:37
Category: client
Severity: 2 - Minor
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.0

___

Details:

While the number and type of specialists is nominally set by the ruleset,
there are still a couple of places where the assumption that there are
exactly three types, E/S/T, is hardcoded:
* In the city report, there's a column "E/S/T" = "Entertainers, Scientists,
Taxmen" (although the column actually displays the ruleset specialist types,
and there are individual columns for the ruleset-defined specialist types).
* In the citizen governor, there's a heading "People (W/E/S/T):" (again, the
actual specialists are displayed even if different in number).

The attached patch addresses this. Side-effects:
* The explanation of the combined specialists column changes from
"Entertainers, Scientists, Taxmen" to "Specialists: elvis, scientist,
taxman", which is a bit ugly.
** This could be fixed by defining a plural name in rulesets, and probably
decoupling the rule name ("elvis") from the display name ("Entertainer"). I
haven't done this.
* The initial position of the combined specialists column moves left.

The issue applies to S2_1, S2_2, and trunk, but the patch touches strings
hence only patched for trunk.



___

File Attachments:


---
Date: Saturday 03/27/10 at 13:37  Name: trunk-specialist-generality.diff 
Size: 6kB   By: jtn
trunk r17166: generalise specialists in city report and citizen governor


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev