[Freeciv-Dev] [bug #15923] should log successful connections the same way as lost connections

[pepeto]

Update of bug #15923 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15923] should log successful connections the same way as lost connections

[pepeto]

Follow-up Comment #2, bug #15923 (project freeciv):

Re-attaching fixes after manipulation mistakes...


(file #9076, file #9077)
___

Additional Item Attachment:

File name: S2_2_login_message.diffSize:4 KB
File name: trunk_login_message.diff   Size:4 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15923] should log successful connections the same way as lost connections

[pepeto]

Update of bug #15923 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => pepeto 
 Planned Release: => 2.2.1, 2.3.0   

___

Follow-up Comment #1:

I confirm. The problem is that this message is sent connection per
connection, so it is not cached like other messages. The reason is that we
don't want to send to the incoming connection the same message.

Fix attached: it computes the chat packet directly from
establish_new_connection(), send connection per connection, then cache for
*all* connection. I needed then to move this a bit later to avoid this packet
sent via send_pending_events(). Additionally for trunk, improve the login
message with setting the player name the connection is attached to.


(file #9044, file #9045)
___

Additional Item Attachment:

File name: trunk_login_message.diff   Size:4 KB
File name: S2_2_login_message.diffSize:4 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15923] should log successful connections the same way as lost connections

[Andreas]

URL:
  

 Summary: should log successful connections the same way as
lost connections
 Project: Freeciv
Submitted by: anbe
Submitted on: Tuesday 04/20/2010 at 12:00
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

Hi,

the server should log (successful) connections with the same priority as
"Lost connection" events so that both appear in the chat window (and get
replayed from the event cache).

Seeing this:
  [11:45:18] (T72 - 11:20:54) Lost connection: andreas from 1.2.3.4 (player
AnBe).
  [11:45:18] (T72 - 11:44:40) Lost connection: andreas from 1.2.3.4 (player
AnBe).
implies "there is something missing".


Andreas




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev