[Freeciv-Dev] [bug #16717] AI chooses new wonder city too often
Update of bug #16717 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?16717 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16717] AI chooses new wonder city too often
Update of bug #16717 (project freeciv): Status: In Progress = Ready For Test ___ Reply to this item at: http://gna.org/bugs/?16717 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16717] AI chooses new wonder city too often
Update of bug #16717 (project freeciv): Assigned to:None = pepeto ___ Reply to this item at: http://gna.org/bugs/?16717 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16717] AI chooses new wonder city too often
Follow-up Comment #5, bug #16717 (project freeciv): Uploading -v2 patches. They delete that FIXME comment, and also delete the 'redundant test?' comment, two lines down. The test '!is_wonder(wonder_city-production.value.building)' is not redundant, because city might build Barracks instead of wonder when AI has no tech for wonder. (file #10770, file #10771) ___ Additional Item Attachment: File name: p22-keep-wonder-city-v2.diff Size:0 KB File name: ptrunk-keep-wonder-city-v2.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?16717 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16717] AI chooses new wonder city too often
Follow-up Comment #4, bug #16717 (project freeciv): The FIXME comment must be removed, because it is pointing about an invalid comprehension of the code, added with the sign mistake in the same patch. ___ Reply to this item at: http://gna.org/bugs/?16717 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16717] AI chooses new wonder city too often
Follow-up Comment #3, bug #16717 (project freeciv): Attaching patches. * p22-keep-wonder-city.diff for S2_2 * ptrunk-keep-wonder-city.diff for trunk (file #10653, file #10654) ___ Additional Item Attachment: File name: p22-keep-wonder-city.diff Size:0 KB File name: ptrunk-keep-wonder-city.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?16717 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16717] AI chooses new wonder city too often
Follow-up Comment #1, bug #16717 (project freeciv): AI tries to pick a wonder city and build a wonder there. Today, the logic to stay with a wonder city is broken, only because the code has '=' instead of '=' at one place, so AI will never finish a wonder unless by luck AI chooses this same city for every turn until this wonder is complete. At ai_manage_buildings() under ai/aicity.c, I tried to change from 0 = wonder_city-surplus[O_SHIELD] to 0 = wonder_city-surplus[O_SHIELD] and tried a game. I observed that the AI stayed with its wonder city, except when this wonder city was not building a wonder (perhaps because the AI had no technology for a wonder). So change from '=' to '=' seems to be good idea. I can create patch after I delete my logging code. I need to keep my logging code while I study bug #13557. ___ Reply to this item at: http://gna.org/bugs/?16717 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16717] AI chooses new wonder city too often
Update of bug #16717 (project freeciv): Status:None = In Progress Planned Release: = 2.2.4, 2.3.0 ___ Follow-up Comment #2: Effectively, this appears to be the cause of the bug. It has been added by mistake in PR#39553 (revision #13297) when inverting a condition: !(a b) - (!a || !b). Patch is needed for trunk and S2_2 (note that this code has been moved into server/advbuilding.c in trunk). ___ Reply to this item at: http://gna.org/bugs/?16717 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
