[Freeciv-Dev] [bug #17862] Hardcoded GAME_START_YEAR

[Marko Lindqvist]

Update of bug #17862 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17862] Hardcoded GAME_START_YEAR

[Marko Lindqvist]

Update of bug #17862 (project freeciv):

Category:None => general
  Status:None => Ready For Test 
 Planned Release: => 2.3.4, 2.4.0, 2.5.0

___

Follow-up Comment #5:

Patches to send string "Calendar not set up" instead of any numerical year
value in pregame.

(file #16998, file #16999)
___

Additional Item Attachment:

File name: MetaCalendarSetup.patchSize:0 KB
File name: MetaCalendarSetup-S2_3.patch   Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17862] Hardcoded GAME_START_YEAR

[Marko Lindqvist]

Follow-up Comment #1, bug #17862 (project freeciv):

Fix attached for the "MinYear" requirement case. Simply allow any value.

We couldn't force value to be at least start year in effects loading even if
we wanted. Calendar, and start year, is not yet set up at that point. We could
add check to ruleset sanity module, but as year has no gameplay effects at
all, I don't think that's necessary - maybe someone even wants to implement
countdown style calendar where years decreases as turn increases.

(file #16658)
___

Additional Item Attachment:

File name: Pre4000BCMinYear.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17862] Hardcoded GAME_START_YEAR

[Marko Lindqvist]

URL:
  

 Summary: Hardcoded GAME_START_YEAR
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 07 Mar 2011 11:36:51 PM EET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

There's still macro GAME_START_YEAR with value -4000 used in some places.
Regardless of what ruleset defines as start year, metaserver shows -4000 as
current year for pregame games. "MinYear" requirement with value less than
-4000 is always considered invalid (even if start year defined in ruleset is
less)

Metasever issue at least is not trivial to fix. In pregame ruleset, with
start year definition, is still subject to change.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev