[Freeciv-Dev] [bug #18081] warning: null format string

Update of bug #18081 (project freeciv): Status: In Progress => Fixed Open/Closed:Open => Closed ___ Follow-up Comment #22: Committed. Let's

[Freeciv-Dev] [bug #18081] warning: null format string

Follow-up Comment #20, bug #18081 (project freeciv): > I will commit it today if there are no objections. Due a change of plans, I can do this earliest on sunday evening. If it is needed before, the ticket is free ... ___ Reply to this it

[Freeciv-Dev] [bug #18081] warning: null format string

Follow-up Comment #19, bug #18081 (project freeciv): > Evidence for Ubuntu tweaking to enable these warnings here. But > I don't know what the mechanism they use to do so (it's not > ended up on my command line). That is the link I found! Opensuse seems to not activate it. At least, there is a d

[Freeciv-Dev] [bug #18081] warning: null format string

Follow-up Comment #18, bug #18081 (project freeciv): File #14086 does help for me, yes. (And notwithstanding my previous comment about fragility, it's hard to see how a toolchain could find this objectionable.) Evidence for Ubuntu tweaking to enable these warnings here

[Freeciv-Dev] [bug #18081] warning: null format string

Follow-up Comment #17, bug #18081 (project freeciv): I did found the option. It is -Wformat; see gna patch #2960. Did the patch help in your case? In my tests with I could reproduce the compile error with the new options. It seems to be fixed by the patch in comment #15. ___

[Freeciv-Dev] [bug #18081] warning: null format string

Follow-up Comment #16, bug #18081 (project freeciv): > Do you know which option(s) have to be added to gcc to activate > these checks This is probably related to so called "hardened gcc", though I would expect every major distribution to use such configuration already. Anyway, maybe googling tha

[Freeciv-Dev] [bug #18081] warning: null format string

Update of bug #18081 (project freeciv): Status: Fixed => In Progress Open/Closed: Closed => Open ___ Follow-up Comment #15: I do not have the

[Freeciv-Dev] [bug #18081] warning: null format string

Follow-up Comment #14, bug #18081 (project freeciv): No, I still had the problem after r20241 (that's where I first noticed it) -- I just mentioned r20238 to narrow down which of the two changes introduced the problem for me. ___ Reply to

[Freeciv-Dev] [bug #18081] warning: null format string

Follow-up Comment #13, bug #18081 (project freeciv): Could you first check SVN Revision 20241? (comment #10) It should fix the problem ... For reference my gcc version: gcc version 4.5.0 20100604 [gcc-4_5-branch revision 160292] (SUSE Linux) __

[Freeciv-Dev] [bug #18081] warning: null format string

Follow-up Comment #12, bug #18081 (project freeciv): Here's my solution to the problem. It's somewhat heavyweight, but if we're to keep the __format__(__printf__) stuff, having a function which doesn't _quite_ have printf semantics (such as accepting a NULL format string) will be a continuing sou

[Freeciv-Dev] [bug #18081] warning: null format string

Follow-up Comment #11, bug #18081 (project freeciv): This change (r20238) seems to have provoked the following warnings (=errors) from my compiler: "format not a string literal and no format arguments". So I can't build trunk any more. GCC 4.4.3 on Ubuntu 10.04.

[Freeciv-Dev] [bug #18081] warning: null format string

Follow-up Comment #9, bug #18081 (project freeciv): I did not consider cpp (qt client). The attached patch gets it to compile again. I will apply it immediately. (file #14074) ___ Additional Item Attachment: File name: 0015-fix-qt-client.

[Freeciv-Dev] [bug #18081] warning: null format string

Update of bug #18081 (project freeciv): Category:None => general Status:None => Fixed Open/Closed:Open => Closed

[Freeciv-Dev] [bug #18081] warning: null format string

Follow-up Comment #7, bug #18081 (project freeciv): ups; wrong file ... (file #12944) ___ Additional Item Attachment: File name: 0005-gna-warning-null-format-string.patch Size:2 KB ___

[Freeciv-Dev] [bug #18081] warning: null format string

Update of bug #18081 (project freeciv): Assigned to:None => syntron Planned Release: => 2.4.0 ___ Follow-up Comment #6: I put it together

[Freeciv-Dev] [bug #18081] warning: null format string

Follow-up Comment #5, bug #18081 (project freeciv): Missed one call (file #12930) ___ Additional Item Attachment: File name: sanitycheck.c Size:0 KB ___ Reply to

[Freeciv-Dev] [bug #18081] warning: null format string

Follow-up Comment #4, bug #18081 (project freeciv): Check out attached patch (file #12929) ___ Additional Item Attachment: File name: noprintfassertfail.diffSize:1 KB ___

[Freeciv-Dev] [bug #18081] warning: null format string

Follow-up Comment #3, bug #18081 (project freeciv): This is just terrible, if I change NULL to "" I get: warning: zero-length printf format string I propose, in fc_assert_fail and similar change if (NULL != message) { into if (NOMSG != message) { where NOMSG is some define, like (void*)0x1. Af

[Freeciv-Dev] [bug #18081] warning: null format string

Follow-up Comment #2, bug #18081 (project freeciv): How many such calls? Hundereds. Maybe the __printf__ assertion can be moved to a lower level and the fc_assert defines should include a test: fmt == NULL ? "" : fmt or something instead. _

[Freeciv-Dev] [bug #18081] warning: null format string

Follow-up Comment #1, bug #18081 (project freeciv): Could you check how many of such calls exists (with NULL for message). I think it would be best, if these calls are corrected. You never know if similar checks will not be included in gcc for linux ... __

[Freeciv-Dev] [bug #18081] warning: null format string

URL: Summary: warning: null format string Project: Freeciv Submitted by: akfaew Submitted on: Thu 28 Apr 2011 08:43:15 AM GMT Category: None Severity: 3 - Normal