[Freeciv-Dev] [bug #18930] Scenarios with bases broken AGAIN?

[Marko Lindqvist]

Update of bug #18930 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18930] Scenarios with bases broken AGAIN?

[Marko Lindqvist]

Follow-up Comment #3, bug #18930 (project freeciv):

> Sounds like bug #17616?

Embarrassing. Seems like I were in the middle of writing another patch at the
time and it was not convenient to switch to writing fix for the bug, and then
I managed to forgot fixing it when I had time. Sine this ticket now has fix,
I'll mark #17616 as duplicate, even though it's older one of the two.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18930] Scenarios with bases broken AGAIN?

[Jacob Nevins]

Follow-up Comment #2, bug #18930 (project freeciv):

Sounds like bug #17616?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18930] Scenarios with bases broken AGAIN?

[Marko Lindqvist]

Update of bug #18930 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #1:

Fix attached

(file #14439)
___

Additional Item Attachment:

File name: ScenBaseFix_18930.diff Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18930] Scenarios with bases broken AGAIN?

[Marko Lindqvist]

URL:
  

 Summary: Scenarios with bases broken AGAIN?
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 05 Nov 2011 11:59:45 PM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.1, 2.4.0, 2.5.0

___

Details:

This code in sg_load_map_tiles_bases():
  if (game.info.is_new_game) {
/* No bases information for a new game / scenario. */
return;
  }

seem to indicate that scenarios with preset bases are not working. I remember
fixing this years ago, already. Non-buildable bases preset to map (=unique
tiles, even with special base features) are important scenario creation
feature!
(I fixed it in S2_2, which had only old style savegame, I probably missed new
style savegames when forwardporting the fix)




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev