[Freeciv-Dev] [bug #19647] String "% of Road Bonus" erroneously claimed to be c-format

2012-04-30 Thread Joan Creus 
Follow-up Comment #2, bug #19647 (project freeciv):

The no-c-format will certainly remove the error for translators, but this *is*
actually a C source file.

My C is quite rusty, but I am pretty sure that one single percent sign won't
print anything at all.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19647] String "% of Road Bonus" erroneously claimed to be c-format

2012-04-30 Thread Jacob Nevins 
Update of bug #19647 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19647] String "% of Road Bonus" erroneously claimed to be c-format

2012-04-30 Thread Marko Lindqvist 
Follow-up Comment #4, bug #19647 (project freeciv):

Something wrong with freciv-dev mailing list? I just got bounce from email I
sent two days ago (it's semi-urgen so this delay was not nice).

Recent freeciv nightly builds by fullmoon fail with logs mentioning something
about el.po having %-issue. Is it this bug? If so, can you make sure that
el.po is fixed too when committing this, and to commit this ASAP as
compilation fix.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19647] String "% of Road Bonus" erroneously claimed to be c-format

2012-04-30 Thread Jacob Nevins 
Follow-up Comment #3, bug #19647 (project freeciv):

Not every string in a C source file has %-interpolation applied to it, only
strings that are passed as the format string argument to printf()- or
scanf()-like functions.


fprintf(doc, "%s%s%s%s(%s)",
_("Irrigation"), _("Mining"), _("Transform"), _("% of Road bonus"),
_("turns"));
_("Irrigation"), _("Mining"), _("Transform"),
/* xgettext:no-c-format */
_("% of Road bonus"), _("turns"));


Here, the first string argument "%s..." is subject to %-replacement
by fprintf(), but the subsequent string arguments are merely substituted in in
place of the %s's in the first one (after going through _(), which doesn't do
any %-mangling).

(The % stuff is interpreted by parts of the standard library, not by the
compiler, unlike escapes like n which really do apply to all strings in C
source files -- but are not significant to i18n.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19647] String "% of Road Bonus" erroneously claimed to be c-format

2012-04-24 Thread Jacob Nevins 
Update of bug #19647 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => jtn
 Planned Release: => 2.5.0  
 Summary: Conflict in c-format string => String "% of Road
Bonus" erroneously claimed to be c-format

___

Follow-up Comment #1:

The string is correct, since it's not used in a context where format string
substitution takes place. However, it should be marked up as such with /*
xgettext:no-c-format */.

(Came in in patch #3223, so only affects trunk.)

(file #15617)
___

Additional Item Attachment:

File name: trunk-manual-road-cfmt.diffSize:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev