[Freeciv-Dev] [bug #20085] Client does not set correct transported_by info

[Marko Lindqvist]

Update of bug #20085 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20085] Client does not set correct transported_by info

[Marko Lindqvist]

Update of bug #20085 (project freeciv):

Category:None => client 
  Status:None => Ready For Test 
 Planned Release: => 2.4.0, 2.5.0   

___

Follow-up Comment #2:

Attached fix removes setting transported_by from unit_transport_unload().
Transported_by should be as told by the server.

(file #16411)
___

Additional Item Attachment:

File name: TransportedByAsServerSays.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20085] Client does not set correct transported_by info

[Marko Lindqvist]

Follow-up Comment #1, bug #20085 (project freeciv):

This explain (original) bug #19904. When client then gets the unit info packet
that is meant to tell it to unload unit, it thinks that unit was never
transported (by checking transported_by) and does nothing to unload it (to set
transporter).

This does not explain server side problems over client logout/login cycle.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20085] Client does not set correct transported_by info

[Marko Lindqvist]

URL:
  

 Summary: Client does not set correct transported_by info
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 20 Aug 2012 03:23:03 AM EEST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

When client initially receives units (either when connecting to server or when
it suddenly sees allied units etc) that are transported, transported_by is not
set correctly.

It's set when unpackaging unit, but then...
packhand.c:1598: unit_transport_unload()
-> Unload from potential old transport. This sets transported_by to -1
packhand.c:1599: unit_transport_load()
-> This loads to correct transport, but it doesn't set transported_by

I'm not yet entirely sure if it's bug that unit_transport_unload() sets
transported_by, or is the bug that unit_transport_load() does not. Should
transported_by in the client be set only by network packet unpackaging, or
should those auxiliary functions also do what their name suggest?




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev