[Freeciv-Dev] [bug #21143] send_unit_info_to_onlookers() puts huge positive or negative values to 8 bits

[Jacob Nevins]

Update of bug #21143 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21143] send_unit_info_to_onlookers() puts huge positive or negative values to 8 bits

[Jacob Nevins]

Update of bug #21143 (project freeciv):

  Status: In Progress => Ready For Test 
 Planned Release: => 2.3.5,2.4.2,2.5.0,2.6.0

___

Follow-up Comment #2:

Same underlying problem affects S2_4 and S2_3, but the warnings aren't present
in those versions.

(file #19603, file #19604, file #19605)
___

Additional Item Attachment:

File name: trunk-savegame-init-orders.patch Size:3 KB
File name: S2_5-savegame-init-orders.patch Size:0 KB
File name: S2_4-S2_3-savegame-init-orders.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21143] send_unit_info_to_onlookers() puts huge positive or negative values to 8 bits

[Jacob Nevins]

Update of bug #21143 (project freeciv):

  Status:None => In Progress
 Assigned to:None => jtn

___

Follow-up Comment #1:

I've encountered this too -- trunk savegame attached. In this game, an example
of a unit triggering this is id 792, English Freight with goto orders.

The problem for me seems to be that when loading from savegame,  activity
target is not initialised for orders where it's not relevant, but the
uninitialsed garbage is unconditionally sent to the client, hence the noise.

Working on patches now.

(file #19598)
___

Additional Item Attachment:

File name: teamgame2.sav.bz2  Size:41 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21143] send_unit_info_to_onlookers() puts huge positive or negative values to 8 bits

[Marko Lindqvist]

URL:
  

 Summary: send_unit_info_to_onlookers() puts huge positive or
negative values to 8 bits
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 17 Sep 2013 12:55:32 AM EEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

"Trying to put -1061625928 into 8 bits" repeated many times with different
values when restarting our multiplayer game from savegame. Backtrace shows
send_unit_info_to_onlookers() called by send_all_known_units() called by
send_all_info().




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev