[Freeciv-Dev] [bug #21373] Switching between nationsets cause assert failure

[Jacob Nevins]

Follow-up Comment #4, bug #21373 (project freeciv):

OK, I'm back on my main computer and am now seeing this (on trunk but not
S2_5, oddly).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21373] Switching between nationsets cause assert failure

[Jacob Nevins]

Follow-up Comment #3, bug #21373 (project freeciv):

> dpkg -s libcairo2 -> Version: 1.12.16-2 
1.10.2-6.1ubuntu3 for me.

I think the format assumption documented by that assertion in
sprite_get_bounding_box() is at the mercy of the behaviour of
cairo_image_surface_create_from_png() called from our load_gfxfile().

Looking at the [http://cgit.freedesktop.org/cairo/tree/src/cairo-png.c#n639
current Cairo git code), it can create a surface with format
CAIRO_FORMAT_ARGB32 or CAIRO_FORMAT_RGB24, depending on the PNG format it
finds.

However, I think my packaged libcairo2 looks similar to the top of tree in
this regard, so I'm not sure why I'm not seeing it.

(Also, the comment

about cairo-png "It is a toy API" is a bit worrying.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21373] Switching between nationsets cause assert failure

[Marko Lindqvist]

Follow-up Comment #2, bug #21373 (project freeciv):

> (I believe you're using a newer Gtk3 than me, for what that's
> worth.)

dpkg -s libgtk-3-0 -> Version: 3.8.6-1
dpkg -s libcairo2 -> Version: 1.12.16-2

> (Maybe this happens when initially popping up the pick-nations
> dialog as well as when interacting with the nationsets control?)

No

That popup_races_dialog() part is interesting in that I just got one of the
backtraces on screen (as I said there was a lot of them - maybe one per
nation?) there. Now that I reproduced this, I can't see one with
popup_races_dialog(), but all have races_update_pickable() there.

1: in sprite_get_bounding_box() [client/gui-gtk-3.0/sprite.c::190]: assertion
'cairo_image_surface_get_format(sprite->surface) == CAIRO_FORMAT_ARGB32'
failed.
2: Backtrace:
2: 0: ./client/freeciv-gtk3() [0x5e640d]
2: 1: ./client/freeciv-gtk3(vdo_log+0x78) [0x5eafc8]
2: 2: ./client/freeciv-gtk3(do_log+0x7d) [0x5eb05d]
2: 3: ./client/freeciv-gtk3(fc_assert_fail+0x8e) [0x5eb24e]
2: 4: ./client/freeciv-gtk3(sprite_get_bounding_box+0x2a5) [0x469345]
2: 5: ./client/freeciv-gtk3(get_flag+0x3c) [0x463dec]
2: 6: ./client/freeciv-gtk3() [0x4d66d9]
2: 7: ./client/freeciv-gtk3() [0x4d69d4]
2: 8: ./client/freeciv-gtk3(races_update_pickable+0x114) [0x4d7d04]
2: 9: ./client/freeciv-gtk3(client_handle_packet+0x2b) [0x4a316b]
2:10: ./client/freeciv-gtk3(client_packet_input+0x1f) [0x46ff8f]
2:11: ./client/freeciv-gtk3(input_from_server+0x6c) [0x47631c]


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21373] Switching between nationsets cause assert failure

[Jacob Nevins]

Follow-up Comment #1, bug #21373 (project freeciv):

Interesting -- I haven't seen these.
(I believe you're using a newer Gtk3 than me, for what that's worth.)

Interesting to see popup_races_dialog() in the backtrace -- I don't think I
expect that when interacting with the nationset control. (Maybe this happens
when initially popping up the pick-nations dialog as well as when interacting
with the nationsets control?)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21373] Switching between nationsets cause assert failure

[Marko Lindqvist]

Update of bug #21373 (project freeciv):

 Summary: Switching between nationsets cause gtk-assert =>
Switching between nationsets cause assert failure


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev