[Freeciv-Dev] [bug #21417] Requirement 'present' / 'negated' field never sent to client

2014-01-02 Thread Jacob Nevins 
Additional Item Attachment, bug #21417 (project freeciv):

File name: trunk-negated-reqs-to-client.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21417] Requirement 'present' / 'negated' field never sent to client

2014-01-02 Thread Jacob Nevins 
Follow-up Comment #1, bug #21417 (project freeciv):

Might explain bug #21115?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21417] Requirement 'present' / 'negated' field never sent to client

2014-01-02 Thread Jacob Nevins 
URL:
  

 Summary: Requirement 'present' / 'negated' field never sent
to client
 Project: Freeciv
Submitted by: jtn
Submitted on: Thu Jan  2 19:59:38 2014
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 2.3.4,2.4.1
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

In send_ruleset_cache(), a requirement's 'negated' field (more recently
'present') is carefully fetched with req_get_values(), but then the value sent
to the client is always negated==FALSE (or present==TRUE).

It's been like this forever (r10499
, PR#13049,
2005-05) -- prior to anywhere I can conveniently check rationale.

Any reason not to send the correct value to the client? I tried a smoke test
on trunk, and no smoke was emitted.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev