[Freeciv-Dev] [bug #21419] Conjunctive requirement sanity checking applied to disjunctive building obsolete_by list

[Jacob Nevins]

Update of bug #21419 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21419] Conjunctive requirement sanity checking applied to disjunctive building obsolete_by list

[Jacob Nevins]

Update of bug #21419 (project freeciv):

  Status: In Progress => Ready For Test 
 Planned Release: => 2.4.2,2.5.0,2.6.0  

___

Additional Item Attachment:

File name: S2_5-rssanity-disjunctive-reqs.patch Size:7 KB
File name: S2_4-rssanity-disjunctive-reqs.patch Size:6 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21419] Conjunctive requirement sanity checking applied to disjunctive building obsolete_by list

[Jacob Nevins]

Additional Item Attachment, bug #21419 (project freeciv):

File name: trunk-rssanity-disjunctive-reqs.patch Size:7 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21419] Conjunctive requirement sanity checking applied to disjunctive building obsolete_by list

[Jacob Nevins]

URL:
  

 Summary: Conjunctive requirement sanity checking applied to
disjunctive building obsolete_by list
 Project: Freeciv
Submitted by: jtn
Submitted on: Fri Jan  3 01:45:14 2014
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

In sanity_check_ruleset_data(), sanity_check_req_vec() is used for all
requirements lists, including pimprove->obsolete_by.
However, obsolete_by is a disjunctive ("or") list -- any of the requirements
is sufficient to obsolete the building. The checks currently in
sanity_check_req_vec() are only appropriate for "and" lists.
For instance, it's a bit of a stretch, but it would be possible to allow
either of two different Govs to obsolete a building, but the sanity checking
forbids it. (Two techs are more likely, but the ruleset checking allows
this.)

(Not that complex obsolete reqs are currently handled particularly gracefully
elsewhere, particularly in the help, but it would work in gameplay terms.)




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev