[Freeciv-Dev] [bug #21899] Crash on clicking unit that was moved out of city

[pepeto]

Update of bug #21899 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 

___

Follow-up Comment #13:

Revisions 24904, 24905 and 24906 fix this particular bug. But a more general
bug about out of sight packets is still present (see bug #22049).


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21899] Crash on clicking unit that was moved out of city

[pepeto]

Follow-up Comment #6, bug #21899 (project freeciv):

Updated server patch to apply over patch #4693.


(file #20749)
___

Additional Item Attachment:

File name: transported_units_not_out_of_sight2.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21899] Crash on clicking unit that was moved out of city

[pepeto]

Follow-up Comment #5, bug #21899 (project freeciv):

Actually, the player doesn't lose vision, but the server seems to assume it
did.

In "server/unittools.c", unit_move():

  if (TILE_KNOWN_SEEN == tile_get_known(tile1, pplayer)) {
unit_list_iterate(tile1->units, punit2) {
  if (punit2 != punit && !can_player_see_unit(pplayer, punit2)) {
unit_goes_out_of_sight(pplayer, punit2);
  }
} unit_list_iterate_end;
  }


can_player_see_unit() returns FALSE because can_player_see_units_in_city()
does. unit_goes_out_of_sight() is called whereas it shouldn't for the cargo
units.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21899] Crash on clicking unit that was moved out of city

[Marko Lindqvist]

Follow-up Comment #4, bug #21899 (project freeciv):

Do the units being transported belong to (another) allied player? Otherwise I
don't understand how one would lose vision when trasnport is moved out but the
cargo units, and their vision, still remain.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21899] Crash on clicking unit that was moved out of city

[pepeto]

Update of bug #21899 (project freeciv):

  Depends on: => patch #4693


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21899] Crash on clicking unit that was moved out of city

[pepeto]

Update of bug #21899 (project freeciv):

  Status:   Confirmed => Ready For Test 
 Planned Release: => 2.4.3,2.5.0,2.6.0  

___

Follow-up Comment #3:

Summary:
Diplomatic state is canceled (alliance to peace). The units inside cities are
thrown outside. But when a transport is bounced, then it loses vision of the
city tile. Cargo units are still there when the server send out of sight
signal (removing unit for owned units).

1) The server shouldn't send out of sight signal because the cargo units will
follow the transport.
2) The client refuses to unload units which aren't at same tile of their
transport. It results that freed pointers are still in usage in the cargo
list. This is what why the client crashes when opening the unit selection
dialog.

Attached fix for both bugs, separately.


(file #20743, file #20744)
___

Additional Item Attachment:

File name: transported_units_not_out_of_sight.patch Size:0 KB
File name: unit_transport_unload.patchSize:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21899] Crash on clicking unit that was moved out of city

[pepeto]

Update of bug #21899 (project freeciv):

 Assigned to:None => pepeto 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21899] Crash on clicking unit that was moved out of city

[pepeto]

Update of bug #21899 (project freeciv):

Category:None => general
Severity:  3 - Normal => 4 - Important  
  Status:None => Confirmed  

___

Follow-up Comment #2:

I confirm with the current S2_4 branch. When canceling the treaty with
Westphalians, I get series of failed assertion : first, I get 3 times

1: in unit_transport_unload() [unit.c::2111]: assertion
'same_pos(unit_tile(pcargo), unit_tile(ptrans))' failed.
2: Backtrace:
2: 0: ./client/freeciv-gtk2() [0x5e943b]
2: 1: ./client/freeciv-gtk2(vdo_log+0x9b) [0x5ed3fb]
2: 2: ./client/freeciv-gtk2(do_log+0x7d) [0x5ed4cd]
2: 3: ./client/freeciv-gtk2(fc_assert_fail+0x9f) [0x5ed6ff]
2: 4: ./client/freeciv-gtk2(unit_transport_unload+0xd3) [0x5e38a3]
2: 5: ./client/freeciv-gtk2(unit_virtual_destroy+0x30) [0x5e3940]
2: 6: ./client/freeciv-gtk2(client_remove_unit+0xf0) [0x472730]
2: 7: ./client/freeciv-gtk2(handle_unit_remove+0xcc) [0x4962bc]
2: 8: ./client/freeciv-gtk2(client_handle_packet+0x48f) [0x49f2cf]
2: 9: ./client/freeciv-gtk2(client_packet_input+0x1e) [0x46fcde]
2:10: ./client/freeciv-gtk2(input_from_server+0x75) [0x4765a5]
2:11: ./client/freeciv-gtk2() [0x444750]
2:12:
/lib/x86_64-linux-gnu/libglib-2.0.so.0(g_main_context_dispatch+0x133)
[0x7f7a3f250d13]
2:13: /lib/x86_64-linux-gnu/libglib-2.0.so.0(+0x48060) [0x7f7a3f251060]
2:14: /lib/x86_64-linux-gnu/libglib-2.0.so.0(g_main_loop_run+0x6a)
[0x7f7a3f25145a]
2:15: /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0(gtk_main+0xa7)
[0x7f7a3ff9c397]
2:16: ./client/freeciv-gtk2(ui_main+0x549) [0x4476d9]
2:17: ./client/freeciv-gtk2(client_main+0x306) [0x4702e6]
2:18: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xed)
[0x7f7a3ec4d76d]
2:19: ./client/freeciv-gtk2() [0x61]


and afterward, an alternation with :

1: in unit_virtual_destroy() [unit.c::1718]: assertion
'!unit_transported(punit)' failed.
2: Backtrace:
2: 0: ./client/freeciv-gtk2() [0x5e943b]
2: 1: ./client/freeciv-gtk2(vdo_log+0x9b) [0x5ed3fb]
2: 2: ./client/freeciv-gtk2(do_log+0x7d) [0x5ed4cd]
2: 3: ./client/freeciv-gtk2(fc_assert_fail+0x9f) [0x5ed6ff]
2: 4: ./client/freeciv-gtk2(unit_virtual_destroy+0x235) [0x5e3b45]
2: 5: ./client/freeciv-gtk2(client_remove_unit+0xf0) [0x472730]
2: 6: ./client/freeciv-gtk2(handle_unit_remove+0xcc) [0x4962bc]
2: 7: ./client/freeciv-gtk2(client_handle_packet+0x48f) [0x49f2cf]
2: 8: ./client/freeciv-gtk2(client_packet_input+0x1e) [0x46fcde]
2: 9: ./client/freeciv-gtk2(input_from_server+0x75) [0x4765a5]
2:10: ./client/freeciv-gtk2() [0x444750]
2:11:
/lib/x86_64-linux-gnu/libglib-2.0.so.0(g_main_context_dispatch+0x133)
[0x7f7a3f250d13]
2:12: /lib/x86_64-linux-gnu/libglib-2.0.so.0(+0x48060) [0x7f7a3f251060]
2:13: /lib/x86_64-linux-gnu/libglib-2.0.so.0(g_main_loop_run+0x6a)
[0x7f7a3f25145a]
2:14: /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0(gtk_main+0xa7)
[0x7f7a3ff9c397]
2:15: ./client/freeciv-gtk2(ui_main+0x549) [0x4476d9]
2:16: ./client/freeciv-gtk2(client_main+0x306) [0x4702e6]
2:17: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xed)
[0x7f7a3ec4d76d]
2:18: ./client/freeciv-gtk2() [0x61]



___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21899] Crash on clicking unit that was moved out of city

[anonymous]

Follow-up Comment #1, bug #21899 (project freeciv):

Am not the same user who posted the original bug.
But I can confirm the bug also exists in Windows Freeciv 2.4.2
The client crashes, the server is fine. The bug report is below.

This report is almost identical to the series I posted earlier
bug #21874: Windows Freeciv 2.4.2 GTK access violation causes client crash But
the cause is completely different and this one is reproducible.



C:Program FilesFreeciv-2.4.2-gtk2freeciv-gtk2.exe caused an Access Violation
at location 0041bac5 in module C:Program
FilesFreeciv-2.4.2-gtk2freeciv-gtk2.exe Reading from location 01c0.

Registers:
eax=020c8338 ebx=0022e810 ecx=01d54e20 edx= esi=0022e7d0 edi=01d54e20
eip=0041bac5 esp=0022e6b0 ebp=0022e798 iopl=0 nv up ei pl nz na pe nc
cs=001b  ss=0023  ds=0023  es=0023  fs=003b  gs= efl=00010202

Call stack:
0041BAC5  C:Program FilesFreeciv-2.4.2-gtk2freeciv-gtk2.exe:0041BAC5  WinMain 
/Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402
0043416F  C:Program FilesFreeciv-2.4.2-gtk2freeciv-gtk2.exe:0043416F  WinMain 
/Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402
0043425A  C:Program FilesFreeciv-2.4.2-gtk2freeciv-gtk2.exe:0043425A  WinMain 
/Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402
0049FFE7  C:Program FilesFreeciv-2.4.2-gtk2freeciv-gtk2.exe:0049FFE7  WinMain 
/Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402
004A01F4  C:Program FilesFreeciv-2.4.2-gtk2freeciv-gtk2.exe:004A01F4  WinMain 
/Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402
004A04F3  C:Program FilesFreeciv-2.4.2-gtk2freeciv-gtk2.exe:004A04F3  WinMain 
/Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402
00431301  C:Program FilesFreeciv-2.4.2-gtk2freeciv-gtk2.exe:00431301  WinMain 
/Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402
00425E8E  C:Program FilesFreeciv-2.4.2-gtk2freeciv-gtk2.exe:00425E8E  WinMain 
/Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402
0042FD1F  C:Program FilesFreeciv-2.4.2-gtk2freeciv-gtk2.exe:0042FD1F  WinMain 
/Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402
0108B916  C:Program FilesFreeciv-2.4.2-gtk2libgtk-win32-2.0-0.dll:0108B916 
gtk_marshal_VOID__UINT_STRING
63A462FC  C:Program FilesFreeciv-2.4.2-gtk2libgobject-2.0-0.dll:63A462FCDwarf
Error: found dwarf version '49664', this reader only handles version 2
information.  g_closure_invoke
63A5D66D  C:Program FilesFreeciv-2.4.2-gtk2libgobject-2.0-0.dll:63A5D66D 
g_signal_emit_by_name
63A5CE2F  C:Program FilesFreeciv-2.4.2-gtk2libgobject-2.0-0.dll:63A5CE2F 
g_signal_emit_valist
63A5D06A  C:Program FilesFreeciv-2.4.2-gtk2libgobject-2.0-0.dll:63A5D06A 
g_signal_emit
011AB557  C:Program FilesFreeciv-2.4.2-gtk2libgtk-win32-2.0-0.dll:011AB557 
gtk_widget_get_realized
01089BA3  C:Program FilesFreeciv-2.4.2-gtk2libgtk-win32-2.0-0.dll:01089BA3 
gtk_propagate_event
0108A05F  C:Program FilesFreeciv-2.4.2-gtk2libgtk-win32-2.0-0.dll:0108A05F 
gtk_main_do_event
6C37EF6F  C:Program FilesFreeciv-2.4.2-gtk2libgdk-win32-2.0-0.dll:6C37EF6F 
gdk_event_get_graphics_expose
685F81D3  C:Program FilesFreeciv-2.4.2-gtk2libglib-2.0-0.dll:685F81D3Dwarf
Error: found dwarf version '1346', this reader only handles version 2
information.  g_source_is_destroyed
685F8C0A  C:Program FilesFreeciv-2.4.2-gtk2libglib-2.0-0.dll:685F8C0A 
g_main_context_dispatch
685F8DE5  C:Program FilesFreeciv-2.4.2-gtk2libglib-2.0-0.dll:685F8DE5 
g_main_context_dispatch
685F91D4  C:Program FilesFreeciv-2.4.2-gtk2libglib-2.0-0.dll:685F91D4 
g_main_loop_run
01089038  C:Program FilesFreeciv-2.4.2-gtk2libgtk-win32-2.0-0.dll:01089038 
gtk_main
00405DE1  C:Program FilesFreeciv-2.4.2-gtk2freeciv-gtk2.exe:00405DE1  WinMain 
/Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402
004074B3  C:Program FilesFreeciv-2.4.2-gtk2freeciv-gtk2.exe:004074B3  WinMain 
/Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402
0040235B  C:Program FilesFreeciv-2.4.2-gtk2freeciv-gtk2.exe:0040235B 
console_main 
/Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:318
00402418  C:Program FilesFreeciv-2.4.2-gtk2freeciv-gtk2.exe:00402418  WinMain 
/Users/hercules/trunk/SDL-1.2/./src/main/win32/SDL_win32_main.c:402
00401AD6  C:Program FilesFreeciv-2.4.2-gtk2freeciv-gtk2.exe:00401AD6
004010DB  C:Program FilesFreeciv-2.4.2-gtk2freeciv-gtk2.exe:004010DB
00401158  C:Program FilesFreeciv-2.4.2-gtk2freeciv-gtk2.exe:00401158
77E6F1EB  C:WINDOWSsystem32kernel32.dll:77E6F1EB  ProcessIdToSessionId


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21899] Crash on clicking unit that was moved out of city

[anonymous]

URL:
  

 Summary: Crash on clicking unit that was moved out of city
 Project: Freeciv
Submitted by: None
Submitted on: Tue 08 Apr 2014 05:22:18 AM UTC
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.4.2
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

There seems to be a bug after units are automatically moved due to downgrading
pact from Alliance to Armistice. Clicking the moved unit will result in a
crash.

How to reproduce:

0) Load attachment file
1) Center on Grevenbroich
2) Cancel treaty with Westphalians
3) Click on the transport next to Grevenbroich



___

File Attachments:


---
Date: Tue 08 Apr 2014 05:22:18 AM UTC  Name:
freeciv_AI_WATCH-T0280-Y01810-auto.sav.bz2  Size: 596kB   By: None



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev