[Freeciv-Dev] [bug #22258] "Map topology and tileset incompatible" is not an error

2014-07-06 Thread pepeto 
Update of bug #22258 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22258] "Map topology and tileset incompatible" is not an error

2014-07-02 Thread Emmet Hikory 
Follow-up Comment #3, bug #22258 (project freeciv):

My apologies: I didn't understand enough, and hadn't tested.  Thank you for
the clarification.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22258] "Map topology and tileset incompatible" is not an error

2014-07-02 Thread pepeto 
Follow-up Comment #2, bug #22258 (project freeciv):

> While I agree it is not an error, I do like getting the popup:
> it reminds me to change tilesets.

Note that my patch still preserves it.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22258] "Map topology and tileset incompatible" is not an error

2014-07-02 Thread Emmet Hikory 
Follow-up Comment #1, bug #22258 (project freeciv):

While I agree it is not an error, I do like getting the popup: it reminds me
to change tilesets.  Previously, I would often find myself doing things in the
wrong topology, which may have unexpected results (gameplay is frequently
surprising, and I spent some time trying to solve a non-problem in such a
situation once while testing pathfinding).

That said, the backtrace isn't either interesting or useful: this isn't a
problem with the code, just with the user preferences.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22258] "Map topology and tileset incompatible" is not an error

2014-07-02 Thread pepeto 
URL:
  

 Summary: "Map topology and tileset incompatible" is not an
error
 Project: Freeciv
Submitted by: pepeto
Submitted on: mer. 02 juil. 2014 15:02:59 CEST
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.6.0

___

Details:

In patch #4474, an tileset error has been added to warn the user that its
tileset doesn't fit the topology.

I really think this is not an *error*. I agree the user should be warned. But
we shouldn't spam the console with error messages (and backtraces in my
case).

Changed to LOG_NORMAL, which looks a better compromise.




___

File Attachments:


---
Date: mer. 02 juil. 2014 15:02:59 CEST  Name:
tileset_error_topology_incompatible.patch  Size: 1 ko   By: pepeto



___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev