[Freeciv-Dev] [patch #1288] Featured test: client side colors

[pepeto]

Update of patch #1288 (project freeciv):

 Assigned to:None => pepeto 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1288] Featured test: client side colors

[pepeto]

Follow-up Comment #5, patch #1288 (project freeciv):

> create_event() is client side mechanism that simulates server
> sent events. It calls handle_event(). See for example
> control.c:do_unit_goto()

Sorry, my mistake, I missed that.  The new patch fix that and:
* create_event() doesn't pass the client.conn.id to handle_event, because
this is used for chat, and this is not a chat line.
* use city_link() instead of city_name() in the create_event() messages.


(file #6764)
___

Additional Item Attachment:

File name: trunk_S2_2_ft_client_colors2.diff.gz Size:10 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1288] Featured test: client side colors

[Marko Lindqvist]

Follow-up Comment #4, patch #1288 (project freeciv):

> The client calls output_window_event only from the
> handle_event(), called from handle_msg_chat(). The messages
> handled by this way are received from the server.

create_event() is client side mechanism that simulates server sent events. It
calls handle_event(). See for example control.c:do_unit_goto()

create_event(ptile, E_BAD_COMMAND,
 _("Didn't find a route to the destination!"));


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1288] Featured test: client side colors

[pepeto]

Follow-up Comment #3, patch #1288 (project freeciv):

> I noticed that client creates some messages as events with
> function called create_event(). Are you aware of that, and are
> you going to add colors to those messages also? (If you do, open
> new ticket)

The client calls output_window_event only from the handle_event(), called
from handle_msg_chat().  The messages handled by this way are received from
the server.  So, they already contain colors, then it doesn't need to have
extra colors.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1288] Featured test: client side colors

[Marko Lindqvist]

Follow-up Comment #2, patch #1288 (project freeciv):

I fixed compile of ftwl client also.

(file #6760)
___

Additional Item Attachment:

File name: AOWColors_1288.diff.bz2Size:7 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1288] Featured test: client side colors

[Marko Lindqvist]

Follow-up Comment #1, patch #1288 (project freeciv):

I noticed that client creates some messages as events with function called
create_event(). Are you aware of that, and are you going to add colors to
those messages also? (If you do, open new ticket)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1288] Featured test: client side colors

[pepeto]

URL:
  

 Summary: Featured test: client side colors
 Project: Freeciv
Submitted by: pepeto
Submitted on: mercredi 09.09.2009 à 22:46
Category: client
Priority: 3 - Low
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.2.0

___

Details:

Like patch #1271, but for client side.

I renamed the interface append_output_window() to output_window_append(). 
Also, I added the function output_window_printf() to make directly
c-formats.




___

File Attachments:


---
Date: mercredi 09.09.2009 à 22:46  Name: trunk_ft_client_colors.diff.gz 
Size: 7 ko   By: pepeto



___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev