[Freeciv-Dev] [patch #1519] [Metaticket] Activate Partisans from Lua script

[pepeto]

Update of patch #1519 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1519] [Metaticket] Activate Partisans from Lua script

[anonymous]

Follow-up Comment #2, patch #1519 (project freeciv):

Thanks, merging this is good. I'm sorry, I must have done something wrong
when I updated the patch series. I didn't test patches 4 and 5 separately,
only together.

While this change is good, and gives more freedom to the ruleset and/or
scenario writer (including ourselves), since the exact partisan placement is
not yet exported, does this change meet our goal (i.e. make freeciv more
flexible, again for ourselves as well as ruleset/scenario writers?). I hope
so, at least since we export more variables and functions to make this
possible (effects, city size and original owner).

One effects function that belongs with the others but that I forgot is
get_unit_bonus. Patch can come later.

___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1519] [Metaticket] Activate Partisans from Lua script

[pepeto]

Update of patch #1519 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #1:

Merged and updated to current trunk the 3 last patches.


(file #8552)
___

Additional Item Attachment:

File name: trunk_lua_make_partisans.diff  Size:30 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1519] [Metaticket] Activate Partisans from Lua script

[pepeto]

Update of patch #1519 (project freeciv):

 Planned Release: => 2.3.0  


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1519] [Metaticket] Activate Partisans from Lua script

[pepeto]

Update of patch #1519 (project freeciv):

 Assigned to:None => pepeto 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1519] [Metaticket] Activate Partisans from Lua script

[Ulrik Sverdrup]

Update of patch #1519 (project freeciv):

  Depends on: => patch #1524


___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1519] [Metaticket] Activate Partisans from Lua script

[Ulrik Sverdrup]

Update of patch #1519 (project freeciv):

  Depends on: => patch #1522


___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1519] [Metaticket] Activate Partisans from Lua script

[Ulrik Sverdrup]

Update of patch #1519 (project freeciv):

  Depends on: => patch #1521


___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1519] [Metaticket] Activate Partisans from Lua script

[Ulrik Sverdrup]

Update of patch #1519 (project freeciv):

  Depends on: => patch #1520


___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1519] [Metaticket] Activate Partisans from Lua script

[Ulrik Sverdrup]

URL:
  

 Summary: [Metaticket] Activate Partisans from Lua script
 Project: Freeciv
Submitted by: englabenny
Submitted on: lördag 2010-03-13 den 13:37
Category: general
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

This series of 5 patches allows us to "activate" placements of partisans from
a Lua script. The last patch includes a change to default.lua to do this.

The exact partisan placement code in place_partisans is kept in C
implementation and this function is exported to the Scripting API with a
modified signature: place_partisans(tile, owner, count).

This change comes with a couple of caveats, the semantics change since we
move the partisan creation from a very specific time inside the process of a
city being taken over, to be carried out after that in the 'city_lost'
callback. Please help me understand if this can have any bad consequences.

Since the city is already lost we can't use get_city_bonus for the inspire
partisans effect, and with this change we will use get_player_bonus. This
makes no difference in the default ruleset but it ignores local effects.

The patches themselves have explanations, first come 4 patches to expand the
Scripting API.




___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev