[Freeciv-Dev] [patch #1942] refactor first portion of ai_airlift into find_neediest_airlift_city

2010-09-12 Thread pepeto
Update of patch #1942 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #1942] refactor first portion of ai_airlift into find_neediest_airlift_city

2010-09-10 Thread pepeto
Update of patch #1942 (project freeciv): Planned Release: => 2.3.0 ___ Reply to this item at: ___ Message po

[Freeciv-Dev] [patch #1942] refactor first portion of ai_airlift into find_neediest_airlift_city

2010-09-10 Thread pepeto
Update of patch #1942 (project freeciv): Status:None => Ready For Test Assigned to:None => pepeto ___ Reply to this item at:

[Freeciv-Dev] [patch #1942] refactor first portion of ai_airlift into find_neediest_airlift_city

2010-09-10 Thread James Spahlinger
Follow-up Comment #5, patch #1942 (project freeciv): Bah, the empty line had spaces in it, removed those 4 in this patch. I read that as "empty line". ;) (file #10296) ___ Additional Item Attachment: File name: 0004-refactor-first-portion

[Freeciv-Dev] [patch #1942] refactor first portion of ai_airlift into find_neediest_airlift_city

2010-09-10 Thread James Spahlinger
Follow-up Comment #4, patch #1942 (project freeciv): Alright, new patch attached fixing comment header length to 77 chars. I copied from the header for ai_airlift which is 75. I left the empty line on line 127 as it separates the variable initialization for that block from the use of it. This f

[Freeciv-Dev] [patch #1942] refactor first portion of ai_airlift into find_neediest_airlift_city

2010-09-10 Thread pepeto
Follow-up Comment #3, patch #1942 (project freeciv): Other things (not so important): * line 127 contains only spaces (necessary) ; * new header comment length usually is 77 characters (to fill the line). ___ Reply to this item at:

[Freeciv-Dev] [patch #1942] refactor first portion of ai_airlift into find_neediest_airlift_city

2010-09-09 Thread James Spahlinger
Follow-up Comment #2, patch #1942 (project freeciv): Thanks for the input, consistant style is important. Both are easy enough to fix. - I changed my emacs code template for C functions to have a new line before that '{' brace. No clue why I missed that detail, the rest of the functions follow i

[Freeciv-Dev] [patch #1942] refactor first portion of ai_airlift into find_neediest_airlift_city

2010-09-09 Thread pepeto
Follow-up Comment #1, patch #1942 (project freeciv): The patch looks correct, except for coding style: static struct city* find_neediest_airlift_city(const struct player *pplayer) { * '*' should be preceded of a space and not followed. Not documented yet (I will add this) but respected as an i

[Freeciv-Dev] [patch #1942] refactor first portion of ai_airlift into find_neediest_airlift_city

2010-09-08 Thread James Spahlinger
URL: Summary: refactor first portion of ai_airlift into find_neediest_airlift_city Project: Freeciv Submitted by: nixeagle Submitted on: Thursday 09/09/2010 at 03:58 Category: ai