[Freeciv-Dev] [patch #2588] Gtk goto/airlift dialog no longer shows cities' airlift capacity

2011-03-08 Thread Jacob Nevins

Update of patch #2588 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?2588

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2588] Gtk goto/airlift dialog no longer shows cities' airlift capacity

2011-03-06 Thread Jacob Nevins

Additional Item Attachment, patch #2588 (project freeciv):

File name: airlift_info.png   Size:184 KB


___

Reply to this item at:

  http://gna.org/patch/?2588

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2588] Gtk goto/airlift dialog no longer shows cities' airlift capacity

2011-03-06 Thread Jacob Nevins

Update of patch #2588 (project freeciv):

  Depends on: = patch #2589


___

Reply to this item at:

  http://gna.org/patch/?2588

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2588] Gtk goto/airlift dialog no longer shows cities' airlift capacity

2011-03-05 Thread Jacob Nevins

URL:
  http://gna.org/patch/?2588

 Summary: Gtk goto/airlift dialog no longer shows cities'
airlift capacity
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun Mar  6 00:11:58 2011
Category: client-gtk-2.0
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.3.0,2.4.0

___

Details:

Bug #15313 revamped the Gtk airlift/goto dialog while adding the ability to
airlift to/from allied cities. However, it lost the column of checkboxes
indicating whether an airlift is possible; now you have to go to an individual
city and see if the Airlift button is greyed out to know if you can try an
airlift.

The column of checkboxes has bugged me for a while, anyway; (a) it's
unlabelled; (b) you can't tell if a city is unchecked because it doesn't have
an airport or because its capacity has been used this turn; (c) it doesn't
distinguish failure to airlift because of lack of capacity at the source and
destination cities. So it made airlifting a bit of guesswork.




___

Reply to this item at:

  http://gna.org/patch/?2588

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2588] Gtk goto/airlift dialog no longer shows cities' airlift capacity

2011-03-05 Thread Jacob Nevins

Update of patch #2588 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #1:

Attached working patch for trunk, to attract comment (and screenshot of
result). I may tweak this further, otherwise S2_3 version will follow (if
different).
* Add a new Airlift column to the Goto/Airlift dialog, containing textual
info about airlift capability of the destination:
** 0/1 and 1/2 show remaining airlift capacity of own cities; Yes shows
infinite sink capacity (airliftingstyle=DEST_UNLIMITED); ? shows unknown
capacity of allied city; - shows airlift is known to be impossible
** The function generating this text is available to any client
* Add a text label at the start showing information about the city/ies the
selected unit/s are in, if any (up to 10); this shows ones which are
airlift-capable and whether they have any capacity left (using the same sort
of labels)
* (This patch propagates slightly further the memory-leaking pattern I
describe under bug #17846. Fixing that is a big job that I don't want to wait
for, but in the unlikely event that it gets fixed first, I'll rebase this
patch.)

(file #12621, file #12622)
___

Additional Item Attachment:

File name: trunk-gtk-airlift-dialog.diff  Size:14 KB
File name: airlift_info.png   Size:228 KB


___

Reply to this item at:

  http://gna.org/patch/?2588

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev