[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Matthias Pfafferodt
Follow-up Comment #12, patch #3001 (project freeciv): > Here's one addressing issues you found. As a crash fix probably > causing problems for many users will commit immediately. Do you know why it crashs for some and for others not? ___ R

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Marko Lindqvist
Follow-up Comment #10, patch #3001 (project freeciv): > OK, don't think it's that store after all. Well, as condition is for() was broken, it ended up storing to traits[-1]. > (No patch file as it's past my bedtime) Here's one addressing issues you found. As a crash fix probably causing proble

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Jacob Nevins
Follow-up Comment #9, patch #3001 (project freeciv): OK, don't think it's that store after all. Error continued to happen with -O0. Think it's this in ruleset_load_traits(): for (tr = trait_begin(); trait_names[tr] != NULL && tr < trait_end(); tr = trait_next(tr)) { The specenum iterators p

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Jacob Nevins
Follow-up Comment #8, patch #3001 (project freeciv): Seems to be the store to traits[tr] where it barfs. I can't see why either. Haven't tried winding down optimisation yet, but it seems pretty stable over perturbations to source code (e.g. changing load_ruleset_nations:default_traits[] to a hard

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Marko Lindqvist
Follow-up Comment #7, patch #3001 (project freeciv): CAnnot reproduce and see no obvious error by reading sources. Does it happen if you disable optimization with CFLAGS="-g -O0"? If so, you may get more informative backtrace from that kind of compilation, without compiler inlining and omitting s

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Matthias Pfafferodt
Follow-up Comment #6, patch #3001 (project freeciv): I can not confirm - svn 20513 is running fine for me (did a short test game). As 'bus error' is something which could be connected to the environment here some data: freeciv trunk (svn20513) compile with '--enable-debug=checks --enable-client=

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Jacob Nevins
Follow-up Comment #5, patch #3001 (project freeciv): I've confirmed that r20500 is the commit where it starts dying for me. Not attempted to work out why it's dying. ___ Reply to this item at: _

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Jacob Nevins
Follow-up Comment #4, patch #3001 (project freeciv): On a checkout of latest trunk (r20513), the server dies immediately with a bus error for me. Since it dies in ruleset_load_traits(), I'm assuming this checkin (r20500 ) is somehow impl

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Matthias Pfafferodt
Follow-up Comment #3, patch #3001 (project freeciv): The problem in comment #2 is solved. Part of the svn checkout was missing. ___ Reply to this item at: ___ N

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Matthias Pfafferodt
Follow-up Comment #2, patch #3001 (project freeciv): is it correct that aitraits.h is included by plrhand.c? This breaks build as the AI header files are not available for the server ... ___ Reply to this item at:

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Marko Lindqvist
Update of patch #3001 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed ___

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-06 Thread Marko Lindqvist
Follow-up Comment #1, patch #3001 (project freeciv): - Updated against svn - Added specenum trait. Since one cannot have specenum with zero values, it now has one value: TRAIT_PLACEHOLDER - Added trait value accessor function (API that ai modules will use) ai_trait_get_value() - Moved stuff that

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-01 Thread Marko Lindqvist
URL: Summary: AI traits framework Project: Freeciv Submitted by: cazfi Submitted on: Tue 01 Nov 2011 05:12:25 PM EET Category: ai Priority: 5 - Normal Status: