[Freeciv-Dev] [patch #3837] Unify UCF_ATT*NON_NATIVE and relevant type flags

Update of patch #3837 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #3837] Unify UCF_ATT*NON_NATIVE and relevant type flags

Update of patch #3837 (project freeciv): Status:None => Ready For Test Assigned to:None => cazfi Planned Release: => 2.3.5, 2.4.0, 2.5.0, 2.6.0 _

[Freeciv-Dev] [patch #3837] Unify UCF_ATT*NON_NATIVE and relevant type flags

Follow-up Comment #7, patch #3837 (project freeciv): Then I'm just confused, and this should work for S2_4. (file #17769) ___ Additional Item Attachment: File name: S2_4-use-can_attack-foo-functions-more.patch Size:2 KB _

[Freeciv-Dev] [patch #3837] Unify UCF_ATT*NON_NATIVE and relevant type flags

Follow-up Comment #6, patch #3837 (project freeciv): S2_4: Umh, but before 2.5 city tile always had road, no matter the terrain. ___ Reply to this item at: ___ M

[Freeciv-Dev] [patch #3837] Unify UCF_ATT*NON_NATIVE and relevant type flags

Follow-up Comment #5, patch #3837 (project freeciv): Patch attached for S2_3. The pf_tools functions are not adjusted, as the nature of the flags in question don't have much meaning for UMT_LAND units (which restriction is imposed by pft_fill_parameter()). For S2_4, I'm much less certain of the

[Freeciv-Dev] [patch #3837] Unify UCF_ATT*NON_NATIVE and relevant type flags

Follow-up Comment #4, patch #3837 (project freeciv): Makes sense. I'll prepare some similar branches for S2_4 and S2_3, with less focus on "nativity", but rather focusing on ensuring that there aren't too many assumptions preventing defining e.g. ships with embedded marine components or similar o

[Freeciv-Dev] [patch #3837] Unify UCF_ATT*NON_NATIVE and relevant type flags

Follow-up Comment #3, patch #3837 (project freeciv): I think lack of some of the checks you add here are actually bugs in stable brances too. Where you now check for UCF_ATTACK_FROM_NON_NATIVE, old versions should check for sea moving units (attack out from harbour city) etc.

[Freeciv-Dev] [patch #3837] Unify UCF_ATT*NON_NATIVE and relevant type flags

Follow-up Comment #2, patch #3837 (project freeciv): And excitingly, the files matched precisely before and after the patch. I'll be sure to also check this way when I do not expect a behavioural difference. ___ Reply to this item at: <

[Freeciv-Dev] [patch #3837] Unify UCF_ATT*NON_NATIVE and relevant type flags

Follow-up Comment #1, patch #3837 (project freeciv): Just a note that if you expect there to be no changes in autogames for some ruleset with some patch, check just that. Run autogame with same gameseed and mapseed before and after the patch and compare md5sums of their final savegames. With curre

[Freeciv-Dev] [patch #3837] Unify UCF_ATT*NON_NATIVE and relevant type flags

URL: Summary: Unify UCF_ATT*NON_NATIVE and relevant type flags Project: Freeciv Submitted by: persia Submitted on: Sun 07 Apr 2013 09:27:23 PM JST Category: general Priority: 5