[Freeciv-Dev] [patch #3937] Remove const.TRUE and const.FALSE from Lua API before the stable release.

[Jacob Nevins]

Update of patch #3937 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 
 Planned Release:   2.4.0-RC1 => 2.4.0-RC1,2.5.0,2.6.0  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3937] Remove const.TRUE and const.FALSE from Lua API before the stable release.

[Jacob Nevins]

Update of patch #3937 (project freeciv):

 Assigned to:None => jtn

___

Follow-up Comment #5:

After some more poking around I don't see any reason not to remove these
(boolean interface to the game seems to be Lua true/false), and having a
const.FALSE that doesn't evaluate as false seems dangerous.

So I intend to commit this before 2.4.0-RC1 (since it's had time for review).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3937] Remove const.TRUE and const.FALSE from Lua API before the stable release.

[Jacob Nevins]

Update of patch #3937 (project freeciv):

Priority:  5 - Normal => 7 - High   
  Status:None => Ready For Test 

___

Follow-up Comment #4:

This was added in patch #2872; no further rationale for the TRUE/FALSE
constants given there or in the metaticket it's linked to.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3937] Remove const.TRUE and const.FALSE from Lua API before the stable release.

[Marko Lindqvist]

Update of patch #3937 (project freeciv):

Category:None => general
 Planned Release: 2.4 => 2.4.0-RC1  

___

Follow-up Comment #3:

Well, this one have to be handled about NOW for it to make it to 2.4.0-RC1.
I'm ok with freeze exception (for 2.4 data file format freeze, which dictates
also scripting API) in this case, but only if the change has been made before
RC1

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3937] Remove const.TRUE and const.FALSE from Lua API before the stable release.

[Ulrik Sverdrup]

Follow-up Comment #2, patch #3937 (project freeciv):

Are const.TRUE and const.FALSE needed anywhere? I think our bindings should
handle the translation from lua's `true` and `false`.

Further confusion comes from 0 and thus const.FALSE being having boolean value
`true` in lua context, the only values with `false` boolean value are `false`
and `nil`.

___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3937] Remove const.TRUE and const.FALSE from Lua API before the stable release.

[Marko Lindqvist]

Follow-up Comment #1, patch #3937 (project freeciv):

> Let's remove this before 2.4 goes stable

Strictly speaking 2.4 API has been frozen for a long time already.

I think TRUE and FALSE here are meant to mirror the fact that our C-code uses
such number types.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3937] Remove const.TRUE and const.FALSE from Lua API before the stable release.

[Ulrik Sverdrup]

URL:
  

 Summary: Remove const.TRUE and const.FALSE from Lua API
before the stable release.
 Project: Freeciv
Submitted by: englabenny
Submitted on: sön  9 jun 2013 01.40.00
Category: None
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4

___

Details:

I think

const.TRUE = 1
and
const.FALSE = 0

were added to demonstrate the const module. It would be a mistake anyway,
since lua already has the keywords `true` and `false` (of boolean, not number
type).

Let's remove this before 2.4 goes stable so it doesn't have to stay in the API
forever.

Patch removes the two variable definitions but leaves the empty const table
intact.

Patch applies for master and 2.4.



___

File Attachments:


---
Date: sön  9 jun 2013 01.40.00  Name:
0001-Remove-const.TRUE-const.FALSE-from-lua-API.patch  Size: 798 B   By:
englabenny
Simple patch.


___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev