[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-31 Thread Sveinung Kvilhaugsvik 
Follow-up Comment #13, patch #4078 (project freeciv):

At http://freeciv.wikia.com/wiki/Editing_rulesets I see that other concepts in
game.ruleset aren't documented. Should I, may I or should I not document it
there?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-31 Thread Sveinung Kvilhaugsvik 
Update of patch #4078 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-30 Thread Sveinung Kvilhaugsvik 
Follow-up Comment #11, patch #4078 (project freeciv):

Be stronger typed in packets.def

(file #18800)
___

Additional Item Attachment:

File name: action_enablers_ruleset.patch  Size:19 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-29 Thread Sveinung Kvilhaugsvik 
Update of patch #4078 (project freeciv):

  Status: In Progress => Ready For Test 
 Assigned to:None => sveinung   

___

Follow-up Comment #10:

> Of course, one may argue that effort should be targeted to removing the
limitation rather than to patching it.
I was planning to look at the "Spy" vs "Diplomat" issue after moving the
remaining diplomatic actions to action enablers.

> There's no units with "Spy" flag in alien ruleset, and thus it shouldn't
have action enablers for such units either.
Nice catch. Fixed for alien and civ1. Checked all the others.

(file #18792)
___

Additional Item Attachment:

File name: action_enablers_ruleset.patch  Size:18 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-29 Thread Marko Lindqvist 
Update of patch #4078 (project freeciv):

  Status:  Ready For Test => In Progress
 Assigned to:   cazfi => None   

___

Follow-up Comment #9:

- There's no units with "Spy" flag in alien ruleset, and thus it shouldn't
have action enablers for such units either. Uhm... probably applies to civ1
ruleset too.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-29 Thread Marko Lindqvist 
Follow-up Comment #8, patch #4078 (project freeciv):

One tangential: As "Spy" *must* be also "Diplomat", that should be also
checked by ruleset sanity checking, but it probably isn't. Of course, one may
argue that effort should be targeted to removing the limitation rather than to
patching it.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-28 Thread Marko Lindqvist 
Follow-up Comment #7, patch #4078 (project freeciv):

> If a new patch version at this stage somehow cause problems

It just means that new (minimum of) 24h inspection period starts now.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-28 Thread Sveinung Kvilhaugsvik 
Follow-up Comment #6, patch #4078 (project freeciv):

I discovered that the unit flag description in units.ruleset mentioned
behavior this patch moves to the rule set. Fixed.

If a new patch version at this stage somehow cause problems I don't mind
redoing the description changes in a separate patch.

(file #18786)
___

Additional Item Attachment:

File name: action_enablers_ruleset.patch  Size:21 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-25 Thread Marko Lindqvist 
Update of patch #4078 (project freeciv):

  Status: In Progress => Ready For Test 
 Assigned to:None => cazfi  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-25 Thread Sveinung Kvilhaugsvik 
Follow-up Comment #5, patch #4078 (project freeciv):

Remove action enabler requirements that aren't moved to the rule set yet.

(file #18764)
___

Additional Item Attachment:

File name: action_enablers_ruleset.patch  Size:18 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-25 Thread Marko Lindqvist 
Update of patch #4078 (project freeciv):

  Status:None => In Progress

___

Follow-up Comment #4:

Since the requirement for "Diplomat" flag is anyway hardcoded, and that is
even documented in the comment, do not add it to enabler requirements - it
makes people think that they can remove it.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-22 Thread Sveinung Kvilhaugsvik 
Follow-up Comment #3, patch #4078 (project freeciv):

Add comment

(file #18735)
___

Additional Item Attachment:

File name: action_enablers_ruleset.patch  Size:20 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-19 Thread Sveinung Kvilhaugsvik 
Follow-up Comment #2, patch #4078 (project freeciv):

Update to apply on top of patch #4077

(file #18714)
___

Additional Item Attachment:

File name: action_enablers_ruleset.patch  Size:19 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-16 Thread Marko Lindqvist 
Update of patch #4078 (project freeciv):

Category:None => general
 Planned Release: => 2.6.0  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-12 Thread Sveinung Kvilhaugsvik 
Follow-up Comment #1, patch #4078 (project freeciv):

Updated to apply on top of trunk svn revision 16510 and patch #4077.

(file #18675)
___

Additional Item Attachment:

File name: action_enablers_ruleset_2.patch Size:19 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4078] read the action enablers from the rule set (and send them to the client)

2013-08-08 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: read the action enablers from the rule set (and send
them to the client)
 Project: Freeciv
Submitted by: sveinung
Submitted on: Thu 08 Aug 2013 07:51:04 PM GMT
Category: None
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Read the action enablers from the rule set. Send them to the client.

Hard coded requirements are added to the requirement vector to make the
forward compatible.



___

File Attachments:


---
Date: Thu 08 Aug 2013 07:51:04 PM GMT  Name: action_enablers_ruleset.patch 
Size: 20kB   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev