[Freeciv-Dev] [patch #4204] Make "Establish Embassy" use the action enabler framework

2013-09-23 Thread Sveinung Kvilhaugsvik 
Update of patch #4204 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #4:

Created patch #4208 so Marko's idea won't be forgotten.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4204] Make "Establish Embassy" use the action enabler framework

2013-09-21 Thread Sveinung Kvilhaugsvik 
Update of patch #4204 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #2:

> I wonder if it would be easy and sensible to use action enablers framework
to create game logic (not player) initiated action Cancel Embassy.
If we imagine that your court/a mob/your senate does the "Expel Embassy"
action I can't see anything wrong in doing it.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4204] Make "Establish Embassy" use the action enabler framework

2013-09-20 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Make "Establish Embassy" use the action enabler
framework
 Project: Freeciv
Submitted by: sveinung
Submitted on: Fri 20 Sep 2013 05:33:56 PM GMT
Category: general
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Make it a hard requirement that no embassy already exist as I don't see the
point in establishing an embassy when a real embassy already exist.

Make the requirements for No_Diplomacy negated requirements on the action.
(This enables rule set authors to feed the diplomats of careless players to
the barbarians by removing them) For alien this is "Lunatic" and "Madmen", for
civ1 this is "Barbarian", civ2 don't have No_Diplomacy and for the rest
"Barbarian" and "Pirate".



___

File Attachments:


---
Date: Fri 20 Sep 2013 05:33:56 PM GMT  Name:
action_enabler_establish_emabssy.patch  Size: 11kB   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4204] Make "Establish Embassy" use the action enabler framework

2013-09-20 Thread Marko Lindqvist 
Follow-up Comment #1, patch #4204 (project freeciv):

I wonder if it would be easy and sensible to use action enablers framework to
create game logic (not player) initiated action Cancel Embassy. Server could
try to do such an action for every embassy every turn, and if it success (=
action enabler requirements allow it) embassy is cancelled. That way ruleset
author could control under which conditions embassies get cancelled (I
remember feature request long ago for cancelling embassies when nations enter
war)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev