[Freeciv-Dev] [patch #4406] players_in_same_range() and other refactoring

[Jacob Nevins]

Update of patch #4406 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4406] players_in_same_range() and other refactoring

[Jacob Nevins]

Update of patch #4406 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #3:

After a bit of testing, I'm considering this ready to commit.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4406] players_in_same_range() and other refactoring

[Jacob Nevins]

Follow-up Comment #2, patch #4406 (project freeciv):

No problem :)

(I also considered a players_range_iterate() like city_range_iterate() in the
AI, but decided that was overdoing it.)

(file #19667)
___

Additional Item Attachment:

File name: trunk-requirements-range-refactor.patch Size:8 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4406] players_in_same_range() and other refactoring

[Marko Lindqvist]

Follow-up Comment #1, patch #4406 (project freeciv):

> Invent new players_in_same_range() for use in the various
> functions that look for player with some property within a
> requirement range.

Sorry for leaving that out when implementing Alliance range. I considered it,
but then listened inner "don't overdesign" voice.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4406] players_in_same_range() and other refactoring

[Jacob Nevins]

URL:
  

 Summary: players_in_same_range() and other refactoring
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat Jan  4 19:13:44 2014
Category: None
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Some refactoring in requirements.c on the way to patch #4388.
* Invent new players_in_same_range() for use in the various functions that
look for player with some property within a requirement range. Not saving much
yet, but it will when REQ_RANGE_TEAM is added.
* Rework buildings_in_range() 'survives' to use a switch statement.
* Factor out is_achievement_in_range()
Untested so far.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev