[Freeciv-Dev] [patch #5020] Introduce can_unit_act_when_unit_state_is

[Sveinung Kvilhaugsvik]

Update of patch #5020 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5020] Introduce can_unit_act_when_unit_state_is

[Sveinung Kvilhaugsvik]

Update of patch #5020 (project freeciv):

  Status:Done => Ready For Test 
 Open/Closed:  Closed => Open   

___

Follow-up Comment #5:

Comments that should have been a part of this patch.

(file #21736)
___

Additional Item Attachment:

File name: 0001-Forgotten-comments.patch  Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5020] Introduce can_unit_act_when_unit_state_is

[Sveinung Kvilhaugsvik]

Update of patch #5020 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 

___

Follow-up Comment #4:

_Things that could be wrong_
Glad that the choices I made weren't wrong enough to make anyone object.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5020] Introduce can_unit_act_when_unit_state_is

[Sveinung Kvilhaugsvik]

Follow-up Comment #2, patch #5020 (project freeciv):

Things that could be wrong:
 * the cache is a static array looked up by unit id. Alternatively it could be
a filed in the unit struct or some other data structure. (At the moment only
some unit types can perform action enabler controlled actions)
 * the cache is eagerly filled on ruleset load in stead of being filled
lazily. (At the moment only one unit state property is checked)
 * it lives in unittypes.c/h and not in actions.c/h

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5020] Introduce can_unit_act_when_unit_state_is

[Sveinung Kvilhaugsvik]

Update of patch #5020 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #1:

unit_state_chache.patch is the patch. The other files are for testing.

To test it apply patch #4671, 0003-Test.patch (to allow spy units but not
diplomats to perform the action "Establish embassy" from non native terrain),
load the savegame spy_and_diplomat_in_ship.sav.bz2 and find the transport with
the diplomat and the spy next to a foreign city.

(file #21693, file #21694, file #21695)
___

Additional Item Attachment:

File name: unit_state_chache.patchSize:11 KB
File name: spy_and_diplomat_in_ship.sav.bz2 Size:14 KB
File name: 0003-Test.patchSize:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5020] Introduce can_unit_act_when_unit_state_is

[Sveinung Kvilhaugsvik]

URL:
  

 Summary: Introduce can_unit_act_when_unit_state_is
 Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 04 Aug 2014 07:14:47 PM UTC
Category: None
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Use it to prevent patch #4671 from introducing bugs.

Should be cached since its used in path finding.

Ideas for the future:
 * use it in more places and for other things
 * handle requirements related to (via flags, classes, etc) Terrain, Extras
and Resources.
 * handle destination tile requirements.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev