[Freeciv-Dev] [patch #5088] CMA enable/disable button icon

[Jacob Nevins]

Follow-up Comment #2, patch #5088 (project freeciv):

(Committed to trunk as r26130
, S2_5 as
r26131 .)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5088] CMA enable/disable button icon

[mir3x]

Update of patch #5088 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5088] CMA enable/disable button icon

[mir3x]

Update of patch #5088 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => mir3x  
 Planned Release: => 2.5.0, 2.6.0   

___

Follow-up Comment #1:

Done. (removed icon from button, added new label with scaled pixmap to 2 x
size of that icon)

(file #21932)
___

Additional Item Attachment:

File name: QtCMA.patchSize:4 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5088] CMA enable/disable button icon

[Marko Lindqvist]

URL:
  

 Summary: CMA enable/disable button icon
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 24 Aug 2014 08:25:44 PM EEST
Category: client-qt
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Icon in Qt-clients "Enable CMA" button works opposite to the gtk-clients one.
The gtk logic is that it shows current state - green when governor is enabled
and working correctly, red when disabled - qt client logic is that it shows
what the toggle button would do - red when it would disable currently active
governor, green when it would enable currently disabled governor.

I prefer gtk-clients solution of displaying green when everything is ok, but I
see how that could be problematic in a button that would toggle it to not-ok
when pressed.

Could we have the icon moved out of the button? So that there would be green
or red light telling governor's current state separately, and the button to
toggle it would have just the "enable" or "disable" text.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev