Re: [Freeciv-Dev] (PR#40054) Percentages in helpdata.c

2008-01-27 Thread William Allen Simpson

http://bugs.freeciv.org/Ticket/Display.html?id=40054 >

Joan Creus wrote:
> I've noticed that, in the last remodelation of helpdata.c, for trunk and 2.2,
> three strings which contained "50%%" have been changed to "50%". But two of
> them are still flagged as c-format, 

That's very odd.  The other message doesn't have any problem:

   #: client/helpdata.c:1045
   msgid ""
   "* Must end turn in a city or next to land, or has a 50% risk of being lost "
   "at sea.\n"

The xgettext heuristic is guessing wrong for two cases.


> ... and msgfmt doesn't like them ("The
> format specifications of argument 1 in msgid and msgstr are not the same",
> and "msgstr is not a valid conversion specifier").
> 
I don't get this warning, but it sounds like a good idea!  There are
quite a few of these problems in *all* the po files. (PR#39970)


> The problematic strings are:
> "* May be disbanded in a city to recover 50% of the production cost.\n"
> "* May fortify, granting a 50% defensive bonus.\n"
> 
> How do you remove the c-format?
> 
Some in data/helpdata.txt and various rulesets have:
   #, no-c-format

They have:
   /* xgettext:no-c-format */

I'll add it immediately!

Details at:
   
http://www.gnu.org/software/gettext/manual/html_node/c_002dformat-Flag.html#c_002dformat-Flag



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#40054) Percentages in helpdata.c

2008-01-27 Thread Marko Lindqvist

http://bugs.freeciv.org/Ticket/Display.html?id=40054 >

On 27/01/2008, Joan Creus  wrote:
>
> How do you remove the c-format?

 Not really answering your question, but related news:
 I just today stumbled upon script fragment in the end of configure.ac
that does some postprocessing for po/Makefile.  One comment there
says:
"Vast quantities of meaningless errors from xgettext is also annoying.
 We fix this by forcing xgettext to assume all files are C source files."

 I'll investigate this a bit more.


 - ML



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#40054) Percentages in helpdata.c

2008-01-27 Thread Christian Knoke
Joan Creus wrote on Jan 27, 08:14 (-0800):
> 
> http://bugs.freeciv.org/Ticket/Display.html?id=40054 >
> 
> I've noticed that, in the last remodelation of helpdata.c, for trunk and 2.2,
> three strings which contained "50%%" have been changed to "50%". But two of
> them are still flagged as c-format, and msgfmt doesn't like them ("The
> format specifications of argument 1 in msgid and msgstr are not the same",
> and "msgstr is not a valid conversion specifier").
> 
> The problematic strings are:
> "* May be disbanded in a city to recover 50% of the production cost.\n"
> "* May fortify, granting a 50% defensive bonus.\n"
> 
> How do you remove the c-format?

More, lots of strings have "50 %". Maybe we decide between "50%%" and 
"50 %"?

Christian

-- 
Christian Knoke* * *http://cknoke.de
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev