Re: [Freeciv-Dev] (PR#8737) mapview centering error caused by panel resize

2007-12-11 Thread William Allen Simpson

http://bugs.freeciv.org/Ticket/Display.html?id=8737 >

Christian Knoke wrote:
> Line 1: Road|Railroad, Irrigation
> Line 2: Mined, Oil|River|...
> 
I almost agree.  More like:

1: terrain description
2: Irrigation, Mine
3: (river)
4: F:%d P:%d T:%d (abbreviations for better right-left translations)
5: %s territory
6: (%d turn cease-fire)
7: cityname, or "Minor Tribe Village"
...

The current version has most of the lines optional, and that should work.


> If the left panel gets a (vertical) scrollbar it needs space for it, and
> you'll either get a horizontal scrollbar, too, or you'll have to resize the
> panel again.
> 
Let's try to avoid scrollbars here.  We already have key conflicts for
PageUp/Down (upper window), and Shift PageUp/Down (lower window), and
don't really want another set for upper left pane

The current version already has some kind of popup feature on the panel,
and that should work!

The multi-line improvement (above) would help all clients, and be useful
for the option/middle mouse button popup, too!



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#8737) mapview centering error caused by panel resize

2007-12-11 Thread Christian Knoke

http://bugs.freeciv.org/Ticket/Display.html?id=8737 >

Jason schrieb am 10. Dec um 22:51 Uhr:

> > What about adding just one (constant) line and break up the terrain
> > properties properly?
> 
> What does that mean?

Line 1: Road|Railroad, Irrigation
Line 2: Mined, Oil|River|...

> >> An alternative might be to embed this widget into a scrollable frame. 
> >> Then if it exceeds the size rather than resizing the container it will
> >> just add scrollbars.  Not perfect but surely better than the current 
> >> system.
> > 
> > Hey you'll get two scrollbars then ...
> 
> You mean in addition to the mapview scrollbar?  That's not a problem.

If the left panel gets a (vertical) scrollbar it needs space for it, and
you'll either get a horizontal scrollbar, too, or you'll have to resize the
panel again.

Christian

-- 
Christian Knoke* * *http://cknoke.de
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#8737) mapview centering error caused by panel resize

2007-12-10 Thread Jason Dorje Short

http://bugs.freeciv.org/Ticket/Display.html?id=8737 >

Christian Knoke wrote:
> http://bugs.freeciv.org/Ticket/Display.html?id=8737 >
> 
> Jason schrieb am 09. Dec um 22:48 Uhr:
> 
>> I stand by my claim that the proper solution is that the widget should
>> auto-resize to be larger but never to be smaller.  I find it hard to
>> believe GTK cannot be easily configured for this, though vasco seemed to
>> think that was the case and that intercepting the signal was the only
>> solution.  Even if this were done there might still be some translation
>> issues as there is no real upper bound on how long a "line" might be.
> 
> What about adding just one (constant) line and break up the terrain
> properties properly?

What does that mean?

>> An alternative might be to embed this widget into a scrollable frame. 
>> Then if it exceeds the size rather than resizing the container it will
>> just add scrollbars.  Not perfect but surely better than the current system.
> 
> Hey you'll get two scrollbars then ...

You mean in addition to the mapview scrollbar?  That's not a problem.

-jason



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#8737) mapview centering error caused by panel resize

2007-12-10 Thread Christian Knoke

http://bugs.freeciv.org/Ticket/Display.html?id=8737 >

Jason schrieb am 09. Dec um 22:48 Uhr:

> I stand by my claim that the proper solution is that the widget should
> auto-resize to be larger but never to be smaller.  I find it hard to
> believe GTK cannot be easily configured for this, though vasco seemed to
> think that was the case and that intercepting the signal was the only
> solution.  Even if this were done there might still be some translation
> issues as there is no real upper bound on how long a "line" might be.

What about adding just one (constant) line and break up the terrain
properties properly?

> An alternative might be to embed this widget into a scrollable frame. 
> Then if it exceeds the size rather than resizing the container it will
> just add scrollbars.  Not perfect but surely better than the current system.

Hey you'll get two scrollbars then ...

Christian

-- 
Christian Knoke* * *http://cknoke.de
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#8737) mapview centering error caused by panel resize

2007-12-07 Thread Christian Knoke

http://bugs.freeciv.org/Ticket/Display.html?id=8737 >

Du schriebst am 07. Dec um 02:58 Uhr:
> 
> http://bugs.freeciv.org/Ticket/Display.html?id=8737 >
> 
> Christian Knoke wrote:
> > A vertical resize could be avoided if you move the minimap to the top.
> > 
> I don't understand this comment.  The minimap is already on the top here.
> 
> It makes sense to split the lines, there is plenty of vertical space.

I'm not sure, but it looks to me that the rectangle with the minimap is
a resizable object which fills up all the space left in the left bar.
So, given a 1024*768 screen, and a *variable* number of lines in the
terrain description, I expect some resizing in the bar.

Christian

-- 
Christian Knoke* * *http://cknoke.de
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#8737) mapview centering error caused by panel resize

2007-12-07 Thread William Allen Simpson

http://bugs.freeciv.org/Ticket/Display.html?id=8737 >

Christian Knoke wrote:
> A vertical resize could be avoided if you move the minimap to the top.
> 
I don't understand this comment.  The minimap is already on the top here.

It makes sense to split the lines, there is plenty of vertical space.

Marko already had some recent code to add an extra line for SDL.  That
whole function could be re-thought a bit for all clients!



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#8737) mapview centering error caused by panel resize

2007-12-07 Thread Christian Knoke

http://bugs.freeciv.org/Ticket/Display.html?id=8737 >

me wrote on Dec 07, 00:52 (-0800):

> This is an ugly bug.

I should add: This is 2.1.1+ and GTK2

Some improvements had been made since this was first.

But some combinations (Railroad+Irrigation+Fortification) still cause
this.

It might be sufficient to have one more line break, between
Railroad+Irrigation and the rest of the tags.

A vertical resize could be avoided if you move the minimap to the top.

> A solution that can be successful is, AFAICS, twofold:
> 
> - break up the terrain description in the left status bar into
>   several lines, but avoiding to go too far down (causing a vertical
>   resize...)
> - block any resize in direction to a *smaller* left status bar

Christian

-- 
Christian Knoke* * *http://cknoke.de
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev