Re: [Freedreno] [PATCH] drm: msm: avoid false-positive -Wmaybe-uninitialized warning

2017-12-04 Thread Arnd Bergmann
On Mon, Dec 4, 2017 at 5:36 PM, Laurent Pinchart wrote: > Hi Arnd, > > Thank you for the patch. > > On Monday, 4 December 2017 16:44:23 EET Arnd Bergmann wrote: >> gcc-8 -fsanitize-coverage=trace-pc produces a false-positive warning: >> >> drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c: In function >>

Re: [Freedreno] [PATCH] drm: msm: avoid false-positive -Wmaybe-uninitialized warning

2017-12-04 Thread Laurent Pinchart
Hi Arnd, Thank you for the patch. On Monday, 4 December 2017 16:44:23 EET Arnd Bergmann wrote: > gcc-8 -fsanitize-coverage=trace-pc produces a false-positive warning: > > drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c: In function > 'mdp5_plane_mode_set.isra.8': > drivers/gpu/drm/msm/mdp/mdp5/mdp5_pl

[Freedreno] [PATCH] drm: msm: avoid false-positive -Wmaybe-uninitialized warning

2017-12-04 Thread Arnd Bergmann
gcc-8 -fsanitize-coverage=trace-pc produces a false-positive warning: drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c: In function 'mdp5_plane_mode_set.isra.8': drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c:1053:3: error: 'crtc_x_r' may be used uninitialized in this function [-Werror=maybe-uninitialized]

[Freedreno] [PATCH] drm/msm: fix leak in failed get_pages

2017-12-04 Thread Sharat Masetty
From: Prakash Kamliya get_pages doesn't keep a reference of the pages allocated when it fails later in the code path. This can lead to a memory leak. Keep reference of the allocated pages so that it can be freed when msm_gem_free_object gets called later during cleanup. Signed-off-by: Prakash Ka

[Freedreno] [PATCH] drm/msm: Memory leak bug fix

2017-12-04 Thread Sharat Masetty
This patch fixes a possible memory leak in get_pages() Prakash Kamliya (1): drm/msm: fix leak in failed get_pages drivers/gpu/drm/msm/msm_gem.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) -- 1.9.1 ___ Freedreno mailing lis

[Freedreno] [PATCH] drm/msm: fix leak in failed get_pages

2017-12-04 Thread Sharat Masetty
From: Prakash Kamliya get_pages doesn't keep a reference of the pages allocated when it fails later in the code path. This can lead to a memory leak. Keep reference of the allocated pages so that it can be freed when msm_gem_free_object gets called later during cleanup. Signed-off-by: Prakash Ka

[Freedreno] [PATCH] drm/msm: Memory leak bug fix

2017-12-04 Thread Sharat Masetty
This patch fixes a possible memory leak in get_pages() Prakash Kamliya (1): drm/msm: fix leak in failed get_pages drivers/gpu/drm/msm/msm_gem.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) -- 1.9.1 ___ Freedreno mailing lis

Re: [Freedreno] [PATCH] mdp5: Return error values from mdp5_cfg_init

2017-12-04 Thread Archit Taneja
On 12/01/2017 02:34 AM, Will Newton wrote: The return value of this function is a pointer checked with IS_ERR, so we should be returning an error pointer rather than NULL when the init fails. Reviewed-by: Archit Taneja Signed-off-by: Will Newton --- drivers/gpu/drm/msm/mdp/mdp5/mdp5_cf