Re: [Freedreno] [PATCH v2 7/7] drm/msm/dpu: Make _dpu_plane_get_aspace void

2018-09-21 Thread Sean Paul
On Thu, Sep 20, 2018 at 12:49:24PM -0400, Bruce Wang wrote: > Remove unneeded checks from _dpu_plane_get_aspace. The function > no longer needs to return anything so it is changed to void. > > Signed-off-by: Bruce Wang > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 25

Re: [Freedreno] [PATCH v2 6/7] drm/msm/dpu: Make dpu_plane_danger_signal_ctrl void

2018-09-21 Thread Sean Paul
On Thu, Sep 20, 2018 at 11:38:54AM -0600, Jordan Crouse wrote: > On Thu, Sep 20, 2018 at 12:49:23PM -0400, Bruce Wang wrote: > > Removed all impossible checks from the function, which eliminates > > the need for a return value. This function is also never used > > outside of dpu_plane.c, so the

Re: [Freedreno] [PATCH v2 5/7] drm/msm/dpu: Change _dpu_crtc_vblank_enable_no_lock to void

2018-09-21 Thread Sean Paul
On Thu, Sep 20, 2018 at 12:49:22PM -0400, Bruce Wang wrote: > Removes redundant tests for _dpu_crtc_vblank_enable_no_lock. > Function return type is now void and all function calls have > been changed accordingly. > > Signed-off-by: Bruce Wang Still Reviewed-by: Sean Paul > --- >

Re: [Freedreno] [PATCH v2 4/7] drm/msm/dpu: Change _dpu_crtc_power_enable to void

2018-09-21 Thread Sean Paul
On Thu, Sep 20, 2018 at 11:36:34AM -0600, Jordan Crouse wrote: > On Thu, Sep 20, 2018 at 12:49:21PM -0400, Bruce Wang wrote: > > All checks for _dpu_crtc_power_enable are not true, so the function > > can never return an error code. All calls of the function have also > > been changed so that they

Re: [Freedreno] [PATCH v2 3/7] drm/msm/dpu: Remove unneeded checks in dpu_crtc.c

2018-09-21 Thread Sean Paul
On Thu, Sep 20, 2018 at 12:49:20PM -0400, Bruce Wang wrote: > Removes impossible checks in dpu_crtc.c. > Variable assignments are moved up to be initializations where > possible. Some variables are no longer used, these are removed. > > Signed-off-by: Bruce Wang > --- >

Re: [Freedreno] [PATCH v2 2/7] drm/msm/dpu: Clean up plane atomic disable/update

2018-09-21 Thread Sean Paul
On Thu, Sep 20, 2018 at 12:49:19PM -0400, Bruce Wang wrote: > Removes unnecessary checks from dpu_plane_atomic_disable, old_state > argument for both dpu_plane_atomic_disable and > dpu_plane_sspp_atomic_update is removed as it is no longer used. > > Signed-off-by: Bruce Wang Reviewed-by: Sean

Re: [Freedreno] [PATCH v2 1/7] drm/msm/dpu: Remove unneeded checks in dpu_plane.c

2018-09-21 Thread Sean Paul
On Thu, Sep 20, 2018 at 12:49:18PM -0400, Bruce Wang wrote: > Removes some checks from dpu_plane.c that will never result in an error. > Subsequent variable assignments become part of the initialization wherever > possible. Unused variables are removed. > > Signed-off-by: Bruce Wang