Re: [Freedreno] [PATCH 01/25] drm/msm/dpu: fix hw ctl retrieval for mixer muxing

2018-10-09 Thread Jeykumar Sankaran
On 2018-10-09 11:07, Sean Paul wrote: On Mon, Oct 08, 2018 at 09:27:18PM -0700, Jeykumar Sankaran wrote: Layer mixer/pingpong block counts and hw ctl block counts will not be same for all the topologies (e.g. layer mixer muxing to single interface) Use the encoder's split_role info to retrieve

Re: [Freedreno] [PATCH 06/25] drm/msm/dpu: clean up redundant hw type

2018-10-09 Thread kbuild test robot
Hi Jeykumar, Thank you for the patch! Yet something to improve: [auto build test ERROR on robclark/msm-next] [also build test ERROR on next-20181009] [cannot apply to v4.19-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [Freedreno] [PATCH 07/25] drm/msm/dpu: reserve using crtc state

2018-10-09 Thread kbuild test robot
Hi Jeykumar, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robclark/msm-next] [also build test WARNING on next-20181009] [cannot apply to v4.19-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url

Re: [Freedreno] [PATCH 07/25] drm/msm/dpu: reserve using crtc state

2018-10-09 Thread Sean Paul
On Mon, Oct 08, 2018 at 09:27:24PM -0700, Jeykumar Sankaran wrote: > DPU maintained reservation lists to cache assigned > HW blocks for the display and a retrieval mechanism for > the individual DRM components to query their respective > HW blocks. > > This patch uses the sub-classed CRTC state

Re: [Freedreno] [PATCH] drm/msm: Grab a vblank reference when waiting for commit_done

2018-10-09 Thread Abhinav Kumar
On 2018-10-09 06:59, Sean Paul wrote: On Mon, Oct 08, 2018 at 06:38:11PM -0700, Abhinav Kumar wrote: On 2018-10-03 13:22, Sean Paul wrote: > From: Sean Paul > > Similar to the atomic helpers, we should enable vblank while we're > waiting for the commit to finish. DPU needs this, MDP5 seems to

Re: [Freedreno] [PATCH 06/25] drm/msm/dpu: clean up redundant hw type

2018-10-09 Thread Sean Paul
On Mon, Oct 08, 2018 at 09:27:23PM -0700, Jeykumar Sankaran wrote: > struct dpu_hw_blk has hw block type info. Remove duplicate > type tracking in struct dpu_rm_hw_blk. > > Signed-off-by: Jeykumar Sankaran > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 17 - > 1 file changed,

[Freedreno] [PATCH] drm/msm: dpu: Simplify conn->state->connector to conn

2018-10-09 Thread Sean Paul
From: Sean Paul state->connector is just a backpointer to conn with the added risk of state being NULL. Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

Re: [Freedreno] [PATCH 05/25] drm/msm/dpu: remove encoder from crtc mixer struct

2018-10-09 Thread Sean Paul
On Mon, Oct 08, 2018 at 09:27:22PM -0700, Jeykumar Sankaran wrote: > Not actively used. Clean up the crtc mixer struct. > > Signed-off-by: Jeykumar Sankaran Reviewed-by: Sean Paul > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 -- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h | 2 -- > 2

Re: [Freedreno] [PATCH 04/25] drm/msm/dpu: clean up dpu_rm_check_property_topctl declaration

2018-10-09 Thread Sean Paul
On Mon, Oct 08, 2018 at 09:27:21PM -0700, Jeykumar Sankaran wrote: > Definition was removed already. Clean up header declaration. > > Signed-off-by: Jeykumar Sankaran Reviewed-by: Sean Paul > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 8 > 1 file changed, 8 deletions(-) > >

Re: [Freedreno] [PATCH 03/25] drm/msm/dpu: remove dev from RM

2018-10-09 Thread Sean Paul
On Mon, Oct 08, 2018 at 09:27:20PM -0700, Jeykumar Sankaran wrote: > Not used. Remove from RM. > > Signed-off-by: Jeykumar Sankaran Reviewed-by: Sean Paul > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 3 +-- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 7 ++- >

Re: [Freedreno] [PATCH 24/25] drm/msm/dpu: remove mutex locking for RM interfaces

2018-10-09 Thread Sean Paul
On Mon, Oct 08, 2018 at 09:27:41PM -0700, Jeykumar Sankaran wrote: > Since HW reservations are happening through atomic_check > and all the display commits are catered by a single commit thread, > it is not necessary to protect the interfaces by a separate > mutex. > > Signed-off-by: Jeykumar

Re: [Freedreno] [PATCH 00/25] reserve RM resources in CRTC state

2018-10-09 Thread Sean Paul
On Mon, Oct 08, 2018 at 09:27:17PM -0700, Jeykumar Sankaran wrote: > Submitting series of patches to clean up DPU resource manager (RM) > of complicated hw iterations, redundant data maintenence and eventually > modifying the DPU to reserve display HW blocks only in atomic check > and caching the

Re: [Freedreno] [PATCH 1/2] drm/msm: dpu: Fix memory leak caused by dropped reference

2018-10-09 Thread Sean Paul
On Tue, Oct 09, 2018 at 11:43:25AM -0700, Jeykumar Sankaran wrote: > On 2018-10-04 11:09, Sean Paul wrote: > > From: Sean Paul > > > > We are currently leaking a drm_crtc_commit struct for every atomic > > commit containing plane state. The dpu plane destroy function cleans up > dpu plane

Re: [Freedreno] [PATCH 2/2] drm/msm: dpu: Remove checks from dpu_plane_destroy_state()

2018-10-09 Thread Jeykumar Sankaran
On 2018-10-04 11:09, Sean Paul wrote: From: Sean Paul They're not needed. Signed-off-by: Sean Paul --- Reviewed-by: Jeykumar Sankaran drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git

Re: [Freedreno] [PATCH 1/2] drm/msm: dpu: Fix memory leak caused by dropped reference

2018-10-09 Thread Jeykumar Sankaran
On 2018-10-04 11:09, Sean Paul wrote: From: Sean Paul We are currently leaking a drm_crtc_commit struct for every atomic commit containing plane state. The dpu plane destroy function cleans up dpu plane destroy -> dpu_plane_destroy_state the fb reference manually, but fails to release the

Re: [Freedreno] [PATCH 18/25] drm/msm/dpu: merge RM interface reservation helpers

2018-10-09 Thread Jeykumar Sankaran
On 2018-10-09 09:50, Jordan Crouse wrote: On Mon, Oct 08, 2018 at 09:27:35PM -0700, Jeykumar Sankaran wrote: we don't have enough reasons why the HW block looping's cannot happen in the same function. So merge them. looping's -> looping. So there are reasons one might break them out but not

Re: [Freedreno] [PATCH v3] drm/msm: validate display and event threads

2018-10-09 Thread Jeykumar Sankaran
On 2018-10-09 07:24, Sean Paul wrote: On Mon, Oct 08, 2018 at 04:55:45PM -0700, Jeykumar Sankaran wrote: While creating display and event threads per crtc, validate them before setting their priorities. changes in v2: - use dev_warn (Abhinav Kumar) changes in v3: - fix

Re: [Freedreno] [PATCH 18/25] drm/msm/dpu: merge RM interface reservation helpers

2018-10-09 Thread Jordan Crouse
On Mon, Oct 08, 2018 at 09:27:35PM -0700, Jeykumar Sankaran wrote: > we don't have enough reasons why the HW block looping's > cannot happen in the same function. So merge them. looping's -> looping. So there are reasons one might break them out but not interesting ones? > Signed-off-by:

Re: [Freedreno] [PATCH 10/25] drm/msm/dpu: maintain hw_mdp in kms

2018-10-09 Thread Jordan Crouse
On Mon, Oct 08, 2018 at 09:27:27PM -0700, Jeykumar Sankaran wrote: > hw_mdp block is common for displays. No need > to reserve per display. > > Signed-off-by: Jeykumar Sankaran > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 7 ++- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 20

Re: [Freedreno] [PATCH] drm/msm: Grab a vblank reference when waiting for commit_done

2018-10-09 Thread Sean Paul
On Mon, Oct 08, 2018 at 06:38:11PM -0700, Abhinav Kumar wrote: > On 2018-10-03 13:22, Sean Paul wrote: > > From: Sean Paul > > > > Similar to the atomic helpers, we should enable vblank while we're > > waiting for the commit to finish. DPU needs this, MDP5 seems to work > > fine without it. > >

Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: clean up references of DPU custom bus scaling

2018-10-09 Thread skolluku
On 2018-10-08 14:57, Sravanthi Kollukuduru wrote: Since the upstream interconnect bus framework has landed upstream, the existing references of custom bus scaling needs to be cleaned up. Signed-off-by: Sravanthi Kollukuduru --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c| 157