Re: [Freedreno] [PATCH 5/6] drm: msm: a6xx: use dev_pm_opp_set_bw to set DDR bandwidth

On Thu, May 14, 2020 at 04:24:18PM +0530, Sharat Masetty wrote: > This patches replaces the previously used static DDR vote and uses > dev_pm_opp_set_bw() to scale GPU->DDR bandwidth along with scaling > GPU frequency. > > Signed-off-by: Sharat Masetty > --- >

Re: [Freedreno] [PATCH 4/6] drm: msm: a6xx: send opp instead of a frequency

On Thu, May 14, 2020 at 05:39:57PM -0700, Matthias Kaehlcke wrote: > On Thu, May 14, 2020 at 04:24:17PM +0530, Sharat Masetty wrote: > > This patch changes the plumbing to send the devfreq recommended opp rather > > than the frequency. Also consolidate and rearrange the code in a6xx to set > > the

Re: [Freedreno] [PATCH 4/6] drm: msm: a6xx: send opp instead of a frequency

On Thu, May 14, 2020 at 04:24:17PM +0530, Sharat Masetty wrote: > This patch changes the plumbing to send the devfreq recommended opp rather > than the frequency. Also consolidate and rearrange the code in a6xx to set > the GPU frequency and the icc vote in preparation for the upcoming > changes

Re: [Freedreno] [PATCH 3/6] OPP: Add and export helper to set bandwidth

On Thu, May 14, 2020 at 04:24:16PM +0530, Sharat Masetty wrote: > From: Sibi Sankar > > Add and export 'dev_pm_opp_set_bw' to set the bandwidth > levels associated with an OPP for a given frequency. Wait, this looks very much like Sibi's patch from v4 of the "DDR/L3 Scaling support on SDM845

Re: [Freedreno] [PATCH 0/6] Add support for GPU DDR BW scaling

On Thu, May 14, 2020 at 04:24:13PM +0530, Sharat Masetty wrote: > Subject: [PATCH 0/6] Add support for GPU DDR BW scaling For anything but the first version the subject (for all patches) should include the version (i.e. [v2, 0/6], etc for this series). > This is a rework of my previous series

Re: [Freedreno] [PATCH 2/6] arm64: dts: qcom: sc7180: Add opp-peak-kBps to GPU opp

On Thu, May 14, 2020 at 04:24:15PM +0530, Sharat Masetty wrote: > Subject: arm64: dts: qcom: sc7180: Add opp-peak-kBps to GPU opp nit: s/opp/OPPs/ > > Add opp-peak-kBps bindings to the GPU opp table, listing the peak > GPU -> DDR bandwidth requirement for each opp level. This will be > used to

Re: [Freedreno] [PATCH 1/6] arm64: dts: qcom: sc7180: Add interconnect bindings for GPU

Hi Sharat, On Thu, May 14, 2020 at 04:24:14PM +0530, Sharat Masetty wrote: > Subject: arm64: dts: qcom: sc7180: Add interconnect bindings for GPU > > This patch adds the interconnect bindings to the GPU node. This enables > the GPU->DDR path bandwidth voting. This patch doesn't add any

[Freedreno] [PATCH] drm/msm: Don't call dma_buf_vunmap without _vmap

I honestly don't exactly understand what's going on here, but the current code is wrong for sure: It calls dma_buf_vunmap without ever calling dma_buf_vmap. What I'm not sure about is whether the WARN_ON is correct: - msm imports dma-buf using drm_prime_sg_to_page_addr_arrays. Which is a pretty

Re: [Freedreno] [PATCH] drm/msm/dpu: ensure device suspend happens during PM sleep

Hi, On Fri, May 1, 2020 at 6:31 AM Kalyan Thota wrote: > > "The PM core always increments the runtime usage counter > before calling the ->suspend() callback and decrements it > after calling the ->resume() callback" > > DPU and DSI are managed as runtime devices. When > suspend is triggered, PM

[Freedreno] [PATCH 1/6] arm64: dts: qcom: sc7180: Add interconnect bindings for GPU

This patch adds the interconnect bindings to the GPU node. This enables the GPU->DDR path bandwidth voting. Signed-off-by: Sharat Masetty --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi

[Freedreno] [PATCH 0/6] Add support for GPU DDR BW scaling

This is a rework of my previous series [1], but this time based on the bindings from Georgi [2] + a few fixes which look to be fixed in v8 of Georgi's series [3]. The work is based on the chromeOS tip. [1]: https://patchwork.freedesktop.org/series/75291/ [2]:

[Freedreno] [PATCH 6/6] dt-bindings: drm/msm/gpu: Document gpu opp table

Update documentation to list the gpu opp table bindings including the newly added "opp-peak-kBps" needed for GPU-DDR bandwidth scaling. Signed-off-by: Sharat Masetty --- .../devicetree/bindings/display/msm/gpu.txt| 28 ++ 1 file changed, 28 insertions(+) diff --git

[Freedreno] [PATCH 4/6] drm: msm: a6xx: send opp instead of a frequency

This patch changes the plumbing to send the devfreq recommended opp rather than the frequency. Also consolidate and rearrange the code in a6xx to set the GPU frequency and the icc vote in preparation for the upcoming changes for GPU->DDR scaling votes. Signed-off-by: Sharat Masetty ---

[Freedreno] [PATCH 2/6] arm64: dts: qcom: sc7180: Add opp-peak-kBps to GPU opp

Add opp-peak-kBps bindings to the GPU opp table, listing the peak GPU -> DDR bandwidth requirement for each opp level. This will be used to scale the DDR bandwidth along with the GPU frequency dynamically. Signed-off-by: Sharat Masetty --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 7 +++ 1

[Freedreno] [PATCH 3/6] OPP: Add and export helper to set bandwidth

From: Sibi Sankar Add and export 'dev_pm_opp_set_bw' to set the bandwidth levels associated with an OPP for a given frequency. Signed-off-by: Sibi Sankar Signed-off-by: Sharat Masetty --- drivers/opp/core.c | 43 +++ include/linux/pm_opp.h | 6

[Freedreno] [PATCH 5/6] drm: msm: a6xx: use dev_pm_opp_set_bw to set DDR bandwidth

This patches replaces the previously used static DDR vote and uses dev_pm_opp_set_bw() to scale GPU->DDR bandwidth along with scaling GPU frequency. Signed-off-by: Sharat Masetty --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git