Re: [Freedreno] [PATCH v2 11/28] drm/msm/dsi: stop setting clock parents manually

2021-03-26 Thread Dmitry Baryshkov
On 26/03/2021 23:48, abhin...@codeaurora.org wrote: Hi Dmitry On 2021-03-26 13:36, Dmitry Baryshkov wrote: On 26/03/2021 21:05, abhin...@codeaurora.org wrote: Hi Dmitry On 2021-03-24 08:18, Dmitry Baryshkov wrote: There is no reason to set clock parents manually, use device tree to assign DS

[Freedreno] [PATCH 1/2] iommu/arm-smmu-qcom: Skip the TTBR1 quirk for db820c.

2021-03-26 Thread Eric Anholt
db820c wants to use the qcom smmu path to get HUPCF set (which keeps the GPU from wedging and then sometimes wedging the kernel after a page fault), but it doesn't have separate pagetables support yet in drm/msm so we can't go all the way to the TTBR1 path. Signed-off-by: Eric Anholt --- We've b

[Freedreno] [PATCH 2/2] arm64: dts: msm8996: Mark the GPU's SMMU as an adreno one.

2021-03-26 Thread Eric Anholt
This enables the adreno-specific SMMU path that sets HUPCF so (user-managed) page faults don't wedge the GPU. Signed-off-by: Eric Anholt --- We've been seeing a flaky test per day or so in Mesa CI where the kernel gets wedged after an iommu fault turns into CP errors. With this patch, the CI is

Re: [Freedreno] [PATCH v2 11/28] drm/msm/dsi: stop setting clock parents manually

2021-03-26 Thread abhinavk
Hi Dmitry On 2021-03-26 13:36, Dmitry Baryshkov wrote: On 26/03/2021 21:05, abhin...@codeaurora.org wrote: Hi Dmitry On 2021-03-24 08:18, Dmitry Baryshkov wrote: There is no reason to set clock parents manually, use device tree to assign DSI/display clock parents to DSI PHY clocks. Dropping t

[Freedreno] [PATCH v2 09/20] drm/dp: Pass drm_dp_aux to drm_dp*_link_train_channel_eq_delay()

2021-03-26 Thread Lyude Paul
So that we can start using drm_dbg_*() for drm_dp_link_train_channel_eq_delay() and drm_dp_lttpr_link_train_channel_eq_delay(). Signed-off-by: Lyude Paul Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 +- drivers/gpu/drm/drm_dp_helper.c

[Freedreno] [PATCH v2 05/20] drm/dp: Add backpointer to drm_device in drm_dp_aux

2021-03-26 Thread Lyude Paul
This is something that we've wanted for a while now: the ability to actually look up the respective drm_device for a given drm_dp_aux struct. This will also allow us to transition over to using the drm_dbg_*() helpers for debug message printing, as we'll finally have a drm_device to reference for d

[Freedreno] [PATCH v2 08/20] drm/dp: Pass drm_dp_aux to drm_dp_link_train_clock_recovery_delay()

2021-03-26 Thread Lyude Paul
So that we can start using drm_dbg_*() in drm_dp_link_train_clock_recovery_delay(). Signed-off-by: Lyude Paul Reviewed-by: Laurent Pinchart Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/amd/amdgpu/atombios_dp.c | 2 +- drivers/gpu/drm/drm_dp_helper.c | 3 ++-

Re: [Freedreno] [PATCH v2 11/28] drm/msm/dsi: stop setting clock parents manually

2021-03-26 Thread Dmitry Baryshkov
On 26/03/2021 21:05, abhin...@codeaurora.org wrote: Hi Dmitry On 2021-03-24 08:18, Dmitry Baryshkov wrote: There is no reason to set clock parents manually, use device tree to assign DSI/display clock parents to DSI PHY clocks. Dropping this manual setup allows us to drop repeating code and to

Re: [Freedreno] [PATCH v2 11/28] drm/msm/dsi: stop setting clock parents manually

2021-03-26 Thread abhinavk
Hi Dmitry On 2021-03-24 08:18, Dmitry Baryshkov wrote: There is no reason to set clock parents manually, use device tree to assign DSI/display clock parents to DSI PHY clocks. Dropping this manual setup allows us to drop repeating code and to move registration of hw clock providers to generic

Re: [Freedreno] [PATCH v2 10/28] drm/msm/dsi: remove msm_dsi_pll_set_usecase

2021-03-26 Thread abhinavk
On 2021-03-24 08:18, Dmitry Baryshkov wrote: msm_dsi_pll_set_usecase() function is not used outside of individual DSI PHY drivers, so drop it in favour of calling the the respective set_usecase functions directly. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/d

Re: [Freedreno] [PATCH v2 09/28] drm/msm/dsi: move min/max PLL rate to phy config

2021-03-26 Thread abhinavk
On 2021-03-24 08:18, Dmitry Baryshkov wrote: Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 3 +++ drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 6 -- drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 6 -- driv

Re: [Freedreno] [PATCH v2 08/28] drm/msm/dsi: drop global msm_dsi_phy_type enumaration

2021-03-26 Thread abhinavk
On 2021-03-24 08:18, Dmitry Baryshkov wrote: With the current upstream driver the msm_dsi_phy_type enum does not make much sense: all DSI PHYs are probed using the dt bindings, the phy type is not passed between drivers. Use quirks in phy individual PHY drivers to differentiate minor harware dif

Re: [Freedreno] [PATCH v2 04/28] drm/msm/dsi: replace PHY's init callback with configurable data

2021-03-26 Thread abhinavk
On 2021-03-24 08:18, Dmitry Baryshkov wrote: DSI PHY init callback would either map dsi_phy_regulator or dsi_phy_lane depending on the PHY type. Replace those callbacks with configuration options governing mapping those regions. Signed-off-by: Dmitry Baryshkov This is a nice cleanup which wil

Re: [Freedreno] [PATCH v2 07/28] drm/msm/dsi: move all PLL callbacks into PHY config struct

2021-03-26 Thread abhinavk
On 2021-03-24 08:18, Dmitry Baryshkov wrote: Move all PLL-related callbacks into struct msm_dsi_phy_cfg. This limits the amount of data in the struct msm_dsi_pll. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/dsi.h | 6 -- drivers/gp

Re: [Freedreno] [PATCH v2 03/28] clk: divider: add devm_clk_hw_register_divider

2021-03-26 Thread abhinavk
On 2021-03-24 08:18, Dmitry Baryshkov wrote: Add devm_clk_hw_register_divider() - devres version of clk_hw_register_divider(). Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- include/linux/clk-provider.h | 17 + 1 file changed, 17 insertions(+) diff --git a/i

Re: [Freedreno] [PATCH v2 02/28] clk: mux: provide devm_clk_hw_register_mux()

2021-03-26 Thread abhinavk
On 2021-03-24 08:18, Dmitry Baryshkov wrote: Add devm_clk_hw_register_mux() - devres-managed version of clk_hw_register_mux(). Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/clk/clk-mux.c| 35 +++ include/linux/clk-provider.h |

Re: [Freedreno] [PATCH v2 06/28] drm/msm/dsi: drop multiple pll enable_seq support

2021-03-26 Thread abhinavk
On 2021-03-24 08:18, Dmitry Baryshkov wrote: The only PLL using multiple enable sequences is the 28nm PLL, which just does the single step in the loop. Push that support back into the PLL code. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/phy/dsi_p

Re: [Freedreno] [PATCH v2 01/28] clk: fixed: add devm helper for clk_hw_register_fixed_factor()

2021-03-26 Thread abhinavk
Hi Dmitry On 2021-03-24 08:18, Dmitry Baryshkov wrote: From: Daniel Palmer Add a devm helper for clk_hw_register_fixed_factor() so that drivers that internally register fixed factor clocks for things like dividers don't need to manually unregister them on remove or if probe fails. Signed-off-