Re: [Freedreno] [PATCH igt v2 3/3] msm: Add submit ioctl tests

2021-08-26 Thread Petri Latvala
On Thu, Aug 26, 2021 at 08:37:19AM -0700, Rob Clark wrote: > On Wed, Aug 25, 2021 at 10:28 PM Petri Latvala > wrote: > > > > On Wed, Aug 25, 2021 at 04:31:39PM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > Add an initial set of tests for the submit ioctl. > > > > > > Signed-off-by:

Re: [Freedreno] [PATCH v2 3/5] drm/msm/dp: Support up to 3 DP controllers

2021-08-26 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-08-25 16:42:31) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index 2c7de43f655a..4a6132c18e57 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -78,6 +78,8 @@ struct

Re: [Freedreno] [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-08-26 Thread Doug Anderson
Hi, On Wed, Aug 25, 2021 at 6:31 PM Stephen Boyd wrote: > > Quoting Bjorn Andersson (2021-07-26 16:13:51) > > eDP panels might need some power sequencing and backlight management, > > so make it possible to associate a drm_panel with a DP instance and > > prepare and enable the panel

Re: [Freedreno] [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-08-26 Thread Doug Anderson
Hi, On Mon, Jul 26, 2021 at 4:15 PM Bjorn Andersson wrote: > > +static int dp_parser_find_panel(struct dp_parser *parser) > +{ > + struct device_node *np = parser->pdev->dev.of_node; > + int rc; > + > + rc = drm_of_find_panel_or_bridge(np, 2, 0, >drm_panel, NULL); > + if

Re: [Freedreno] [PATCH v2 3/5] drm/msm/dp: Support up to 3 DP controllers

2021-08-26 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-08-26 09:57:18) > On Thu 26 Aug 00:13 PDT 2021, Stephen Boyd wrote: > > Quoting Bjorn Andersson (2021-08-25 16:42:31) > > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > > > b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > [..] > > > @@ -203,8 +204,8 @@

Re: [Freedreno] [PATCH v2 3/5] drm/msm/dp: Support up to 3 DP controllers

2021-08-26 Thread Bjorn Andersson
On Thu 26 Aug 00:13 PDT 2021, Stephen Boyd wrote: > Quoting Bjorn Andersson (2021-08-25 16:42:31) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > > b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c [..] > > @@ -203,8 +204,8 @@ static int dpu_kms_debugfs_init(struct msm_kms *kms, > >

Re: [Freedreno] [PATCH v5 16/20] drm/msm: Don't break exclusive fence ordering

2021-08-26 Thread Rob Clark
On Thu, Aug 5, 2021 at 3:47 AM Daniel Vetter wrote: > > There's only one exclusive slot, and we must not break the ordering. > > Adding a new exclusive fence drops all previous fences from the > dma_resv. To avoid violating the signalling order we err on the side of > over-synchronizing by

Re: [Freedreno] [PATCH v5 12/20] drm/msm: Use scheduler dependency handling

2021-08-26 Thread Rob Clark
On Thu, Aug 5, 2021 at 3:47 AM Daniel Vetter wrote: > > drm_sched_job_init is already at the right place, so this boils down > to deleting code. > > Signed-off-by: Daniel Vetter > Cc: Rob Clark > Cc: Sean Paul > Cc: Sumit Semwal > Cc: "Christian König" > Cc: linux-arm-...@vger.kernel.org >

Re: [Freedreno] [PATCH] drm/msm: Improve drm/sched point of no return rules

2021-08-26 Thread Rob Clark
On Thu, Aug 26, 2021 at 2:33 AM Daniel Vetter wrote: > > Originally drm_sched_job_init was the point of no return, after which > drivers really should submit a job. I've split that up, which allows > us to fix this issue pretty easily. > > Only thing we have to take care of is to not skip to

Re: [Freedreno] [PATCH igt v2 3/3] msm: Add submit ioctl tests

2021-08-26 Thread Rob Clark
On Wed, Aug 25, 2021 at 10:28 PM Petri Latvala wrote: > > On Wed, Aug 25, 2021 at 04:31:39PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > Add an initial set of tests for the submit ioctl. > > > > Signed-off-by: Rob Clark > > --- > > tests/meson.build | 1 + > > tests/msm_submit.c |

[Freedreno] [PATCH] drm/msm: Improve drm/sched point of no return rules

2021-08-26 Thread Daniel Vetter
Originally drm_sched_job_init was the point of no return, after which drivers really should submit a job. I've split that up, which allows us to fix this issue pretty easily. Only thing we have to take care of is to not skip to error paths after that. Other drivers do this the same for out-fence

Re: [Freedreno] [PATCH v2 5/5] drm/msm/dp: Add sc8180x DP controllers

2021-08-26 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-08-25 16:42:33) > The sc8180x has 2 DP and 1 eDP controllers, add support for these to the > DP driver. > > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd

Re: [Freedreno] [PATCH v2 3/5] drm/msm/dp: Support up to 3 DP controllers

2021-08-26 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-08-25 16:42:31) > Based on the removal of the g_dp_display and the movement of the > priv->dp lookup into the DP code it's now possible to have multiple > DP instances. > > In line with the other controllers in the MSM driver, introduce a > per-compatible list of base

Re: [Freedreno] [PATCH v2 2/5] drm/msm/dp: Modify prototype of encoder based API

2021-08-26 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-08-25 16:42:30) > Functions in the DisplayPort code that relates to individual instances > (encoders) are passed both the struct msm_dp and the struct drm_encoder. But > in a situation where multiple DP instances would exist this means that > the caller need to

Re: [Freedreno] [PATCH v2 1/5] drm/msm/dp: Remove global g_dp_display variable

2021-08-26 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-08-25 16:42:29) > As the Qualcomm DisplayPort driver only supports a single instance of > the driver the commonly used struct dp_display is kept in a global > variable. As we introduce additional instances this obviously doesn't > work. > > Replace this with a