Re: [Freedreno] [PATCH v2 2/2] clk: qcom: gcc-sdm660: Remove transient global "xo" clock

2021-09-01 Thread Stephen Boyd
Quoting Marijn Suijten (2021-09-01 01:57:15) > On 2021-08-31 22:35:56, Stephen Boyd wrote: > > Quoting Marijn Suijten (2021-08-30 11:24:45) > > > The DSI PHY/PLL was relying on a global "xo" clock to be found, but the > > > real clock is named "xo_board" in the DT. The standard nowadays is to > >

Re: [Freedreno] [PATCH v2 1/2] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent

2021-09-01 Thread Stephen Boyd
Quoting Marijn Suijten (2021-09-01 01:49:10) > Hi Stephen, > > On 2021-08-31 22:35:12, Stephen Boyd wrote: > > Quoting Marijn Suijten (2021-08-30 16:10:26) > > > > > > I'm 95% sure this shouldn't cause any problems given current DTs and > > > their history, but that's probably not enough. This

[Freedreno] [PATCH 3/3] dt-bindings: display: msm: Add binding for msm8998 dpu

2021-09-01 Thread AngeloGioacchino Del Regno
Add yaml binding for msm8998 dpu1 support. Signed-off-by: AngeloGioacchino Del Regno --- .../bindings/display/msm/dpu-msm8998.yaml | 220 ++ 1 file changed, 220 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml diff --git

[Freedreno] [PATCH 2/3] drm/msm/dpu1: Add MSM8998 to hw catalog

2021-09-01 Thread AngeloGioacchino Del Regno
Bringup functionality for MSM8998 in the DPU, driver which is mostly the same as SDM845 (just a few variations). Signed-off-by: AngeloGioacchino Del Regno --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 335 +- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 +

[Freedreno] [PATCH 1/3] drm/msm/dpu1: Add DMA2, DMA3 clock control to enum

2021-09-01 Thread AngeloGioacchino Del Regno
The enum dpu_clk_ctrl_type misses DPU_CLK_CTRL_DMA{2,3} even though this driver does actually handle both, if present: add the two in preparation for adding support for SoCs having them. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 ++ 1 file

[Freedreno] [PATCH 2/2] drm/msm/dpu: Fix timeout issues on command mode panels

2021-09-01 Thread AngeloGioacchino Del Regno
In function dpu_encoder_phys_cmd_wait_for_commit_done we are always checking if the relative CTL is started by waiting for an interrupt to fire: it is fine to do that, but then sometimes we call this function while the CTL is up and has never been put down, but that interrupt gets raised only when

[Freedreno] [PATCH 1/2] drm/msm/dpu: Add a function to retrieve the current CTL status

2021-09-01 Thread AngeloGioacchino Del Regno
Add a function that returns whether the requested CTL is active or not: this will be used in a later commit to fix command mode panel issues. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 6 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 7

Re: [Freedreno] [PATCH v2 2/2] clk: qcom: gcc-sdm660: Remove transient global "xo" clock

2021-09-01 Thread Marijn Suijten
On 2021-08-31 22:35:56, Stephen Boyd wrote: > Quoting Marijn Suijten (2021-08-30 11:24:45) > > The DSI PHY/PLL was relying on a global "xo" clock to be found, but the > > real clock is named "xo_board" in the DT. The standard nowadays is to > > never use global clock names anymore but require the

Re: [Freedreno] [PATCH v2 1/2] drm/msm/dsi: Use "ref" fw clock instead of global name for VCO parent

2021-09-01 Thread Marijn Suijten
Hi Stephen, On 2021-08-31 22:35:12, Stephen Boyd wrote: > Quoting Marijn Suijten (2021-08-30 16:10:26) > > > > I'm 95% sure this shouldn't cause any problems given current DTs and > > their history, but that's probably not enough. This might also impact > > DTs that have not yet been