Re: [Freedreno] [PATCH v2 02/34] component: Introduce the aggregate bus_type

2021-10-06 Thread Greg Kroah-Hartman
On Wed, Oct 06, 2021 at 12:37:47PM -0700, Stephen Boyd wrote: > The component driver only provides 'bind' and 'unbind' callbacks to tell > the host driver that it is time to assemble the aggregate driver now > that all the components have probed. The component driver model doesn't > attempt to

Re: [Freedreno] [PATCH v2 01/34] component: Introduce struct aggregate_device

2021-10-06 Thread Laurent Pinchart
Hi Stephen, Thank you for the patch. On Wed, Oct 06, 2021 at 12:37:46PM -0700, Stephen Boyd wrote: > Replace 'struct master' with 'struct aggregate_device' and then rename > 'master' to 'adev' everywhere in the code. While we're here, put a > struct device inside the aggregate device so that we

Re: [Freedreno] [PATCH v2 33/34] component: Remove component_master_ops and friends

2021-10-06 Thread kernel test robot
config: hexagon-randconfig-r045-20211006 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c0039de2953d15815448b4b3c3bafb45607781e0) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin

Re: [Freedreno] [PATCH v2 02/34] component: Introduce the aggregate bus_type

2021-10-06 Thread kernel test robot
config: hexagon-randconfig-r045-20211006 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c0039de2953d15815448b4b3c3bafb45607781e0) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin

Re: [Freedreno] [PATCH v2 06/34] drm/of: Add a drm_of_aggregate_probe() API

2021-10-06 Thread kernel test robot
config: s390-randconfig-r044-20211006 (attached as .config) compiler: s390-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https

Re: [Freedreno] [PATCH v2 06/34] drm/of: Add a drm_of_aggregate_probe() API

2021-10-06 Thread kernel test robot
config: hexagon-randconfig-r041-20211006 (attached as .config) compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project c0039de2953d15815448b4b3c3bafb45607781e0) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O

[Freedreno] [PATCH 2/2] drm/msm/dsi: stop setting clock parents manually

2021-10-06 Thread Dmitry Baryshkov
There is no reason to set clock parents manually, use device tree to assign DSI/display clock parents to DSI PHY clocks. Dropping this manual setup allows us to drop repeating code and to move registration of hw clock providers to generic place. Signed-off-by: Dmitry Baryshkov ---

[Freedreno] [PATCH 1/2] drm/msm/dsi: untangle cphy setting from the src pll setting

2021-10-06 Thread Dmitry Baryshkov
Move DPHY/CPHY setting from msm_dsi_host_set_src_pll() to new function msm_dsi_host_set_phy_mode(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi.h | 2 ++ drivers/gpu/drm/msm/dsi/dsi_host.c| 8 drivers/gpu/drm/msm/dsi/dsi_manager.c | 3 +++ 3 files

Re: [Freedreno] [PATCH v4 5/7] drm/msm/dp: Support up to 3 DP controllers

2021-10-06 Thread Bjorn Andersson
On Wed 06 Oct 11:59 PDT 2021, Stephen Boyd wrote: > Quoting Bjorn Andersson (2021-10-06 11:05:09) > > On Wed 06 Oct 10:19 PDT 2021, Stephen Boyd wrote: > > > > > Quoting Bjorn Andersson (2021-10-06 10:07:17) > > > > On Tue 05 Oct 21:26 PDT 2021, Stephen Boyd wrote: > > > > > > > > > Quoting Bjorn

Re: [Freedreno] [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-06 Thread Prashant Malani
(CC+ Heikki) Hi, On Wed, Oct 6, 2021 at 8:19 AM Doug Anderson wrote: > > Hi, > > On Tue, Oct 5, 2021 at 7:27 PM Bjorn Andersson > wrote: > > > > > > For reference, this is how I thought one is supposed to tie the Type-C > > > > controller to the display driver: > > > >

[Freedreno] [PATCH v2 30/34] sound: hdac: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Kai Vehmanen Cc: Daniel Vetter Cc: "Rafael J. Wysocki"

[Freedreno] [PATCH v2 34/34] component: Remove all references to 'master'

2021-10-06 Thread Stephen Boyd
Remove all references to 'master' in the code now that we've migrated all the users of the ops structure to the aggregate driver. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 19

[Freedreno] [PATCH v2 27/34] mei: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Tomas Winkler Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Daniel Vetter Cc: "Rafael J.

[Freedreno] [PATCH v2 29/34] fbdev: omap2: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Cc: Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana

[Freedreno] [PATCH v2 26/34] iommu/mtk: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Yong Wu Cc: Joerg Roedel Cc: Will Deacon Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob

[Freedreno] [PATCH v2 33/34] component: Remove component_master_ops and friends

2021-10-06 Thread Stephen Boyd
The struct is unused now so drop it along with the functions that use it. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/base/component.c | 109 +++---

[Freedreno] [PATCH v2 32/34] component: Get rid of drm_of_component_probe()

2021-10-06 Thread Stephen Boyd
There aren't any users anymore so drop it. Cc: Laurent Pinchart Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd --- drivers/gpu/drm/drm_of.c | 87 +--- include/drm/drm_of.h |

[Freedreno] [PATCH v2 31/34] ASoC: codecs: wcd938x: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Mark Brown Cc: Jaroslav Kysela Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc:

[Freedreno] [PATCH v2 28/34] power: supply: ab8500: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Sebastian Reichel Cc: Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell

[Freedreno] [PATCH v2 23/34] drm/tilcdc: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Jyri Sarha Cc: Tomi Valkeinen Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc:

[Freedreno] [PATCH v2 25/34] drm/zte: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan

[Freedreno] [PATCH v2 17/34] drm/mediatek: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark

[Freedreno] [PATCH v2 18/34] drm/meson: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Neil Armstrong Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King

[Freedreno] [PATCH v2 22/34] drm/sun4i: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Maxime Ripard Cc: Chen-Yu Tsai Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc:

[Freedreno] [PATCH v2 21/34] drm/sti: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Benjamin Gaignard Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King

[Freedreno] [PATCH v2 19/34] drm/omap: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Tomi Valkeinen Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King

[Freedreno] [PATCH v2 24/34] drm/vc4: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Emma Anholt Cc: Maxime Ripard Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc:

[Freedreno] [PATCH v2 15/34] drm/ingenic: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. TODO: Move the helpers to PM in aggregate driver hooks. Cc: Paul Cercueil Cc: Daniel Vetter Cc:

[Freedreno] [PATCH v2 20/34] drm/rockchip: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Sandy Huang Cc: "Heiko Stübner" Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark

[Freedreno] [PATCH v2 16/34] drm/mcde: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan

[Freedreno] [PATCH v2 14/34] drm/imx: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Philipp Zabel Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc:

[Freedreno] [PATCH v2 11/34] drm/etnaviv: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Lucas Stach Cc: Russell King Cc: Christian Gmeiner Cc: Daniel Vetter Cc: "Rafael J.

[Freedreno] [PATCH v2 13/34] drm/exynos: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Cc: Daniel Vetter Cc:

[Freedreno] [PATCH v2 09/34] drm/malidp: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. TODO: This can be updated to move the drm helper logic into the aggregate driver shutdown op. Cc:

[Freedreno] [PATCH v2 05/34] component: Add {bind, unbind}_component() ops that take aggregate device

2021-10-06 Thread Stephen Boyd
We'd like to get more device model features in the component framework so let's pass the struct aggregate_device pointer instead of the parent device pointer to the component binding functions. This will allow drivers to inspect and control things related to the aggregate device in case they need

[Freedreno] [PATCH v2 12/34] drm/kirin: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Xinliang Liu Cc: Tian Tao Cc: John Stultz Cc: Xinwei Kong Cc: Chen Feng Cc: Daniel Vetter

[Freedreno] [PATCH v2 10/34] drm/armada: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Russell King Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Saravana Kannan

[Freedreno] [PATCH v2 07/34] drm/komeda: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: James Qian Wang (Arm Technology China) Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob

[Freedreno] [PATCH v2 08/34] drm/arm/hdlcd: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
Use an aggregate driver instead of component ops so that we can get proper driver probe ordering of the aggregate device with respect to all the component devices that make up the aggregate device. Cc: Liviu Dudau Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc:

[Freedreno] [PATCH v2 03/34] component: Move struct aggregate_device out to header file

2021-10-06 Thread Stephen Boyd
This allows aggregate driver writers to use the device passed to their probe/remove/shutdown functions properly instead of treating it as an opaque pointer. Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell King Cc: Saravana Kannan Signed-off-by: Stephen Boyd ---

[Freedreno] [PATCH v2 06/34] drm/of: Add a drm_of_aggregate_probe() API

2021-10-06 Thread Stephen Boyd
Similar to drm_of_component_probe() but using the new API that registers a driver instead of an ops struct. This allows us to migrate the users of drm_of_component_probe() to the new way of doing things. Cc: Laurent Pinchart Cc: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Rob Clark Cc: Russell

[Freedreno] [PATCH v2 04/34] drm/msm: Migrate to aggregate driver

2021-10-06 Thread Stephen Boyd
The device lists are poorly ordered when the component device code is used. This is because component_master_add_with_match() returns 0 regardless of component devices calling component_add() first. It can really only fail if an allocation fails, in which case everything is going bad and we're out

[Freedreno] [PATCH v2 00/34] component: Make into an aggregate bus

2021-10-06 Thread Stephen Boyd
This series is from discussion we had on reordering the device lists for drm shutdown paths[1]. I've introduced an 'aggregate' bus that we put the aggregate device onto and then we probe the aggregate device once all the components are probed and call component_add(). The probe/remove hooks are

[Freedreno] [PATCH v2 02/34] component: Introduce the aggregate bus_type

2021-10-06 Thread Stephen Boyd
The component driver only provides 'bind' and 'unbind' callbacks to tell the host driver that it is time to assemble the aggregate driver now that all the components have probed. The component driver model doesn't attempt to resolve runtime PM or suspend/resume ordering, and explicitly mentions

[Freedreno] [PATCH v2 01/34] component: Introduce struct aggregate_device

2021-10-06 Thread Stephen Boyd
Replace 'struct master' with 'struct aggregate_device' and then rename 'master' to 'adev' everywhere in the code. While we're here, put a struct device inside the aggregate device so that we can register it with a bus_type in the next patch. The diff is large but that's because this is mostly a

Re: [Freedreno] [PATCH v4 5/7] drm/msm/dp: Support up to 3 DP controllers

2021-10-06 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-10-06 11:05:09) > On Wed 06 Oct 10:19 PDT 2021, Stephen Boyd wrote: > > > Quoting Bjorn Andersson (2021-10-06 10:07:17) > > > On Tue 05 Oct 21:26 PDT 2021, Stephen Boyd wrote: > > > > > > > Quoting Bjorn Andersson (2021-10-05 19:37:52) > > > > > On Tue 05 Oct 19:06

Re: [Freedreno] [PATCH v4 5/7] drm/msm/dp: Support up to 3 DP controllers

2021-10-06 Thread Bjorn Andersson
On Wed 06 Oct 10:19 PDT 2021, Dmitry Baryshkov wrote: > On 06/10/2021 20:07, Bjorn Andersson wrote: > > On Tue 05 Oct 21:26 PDT 2021, Stephen Boyd wrote: > > > > > Quoting Bjorn Andersson (2021-10-05 19:37:52) > > > > On Tue 05 Oct 19:06 PDT 2021, Stephen Boyd wrote: > > > > > > > > > Quoting

Re: [Freedreno] mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o)

2021-10-06 Thread Randy Dunlap
On 10/6/21 12:24 AM, Christian König wrote: Am 06.10.21 um 09:20 schrieb Stephen Rothwell: Hi Randy, On Tue, 5 Oct 2021 22:48:03 -0700 Randy Dunlap wrote: on i386: ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg' Full randconfig

Re: [Freedreno] [PATCH v4 5/7] drm/msm/dp: Support up to 3 DP controllers

2021-10-06 Thread Bjorn Andersson
On Wed 06 Oct 10:19 PDT 2021, Stephen Boyd wrote: > Quoting Bjorn Andersson (2021-10-06 10:07:17) > > On Tue 05 Oct 21:26 PDT 2021, Stephen Boyd wrote: > > > > > Quoting Bjorn Andersson (2021-10-05 19:37:52) > > > > On Tue 05 Oct 19:06 PDT 2021, Stephen Boyd wrote: > > > > > > > > > Quoting Bjorn

Re: [Freedreno] [PATCH] drm/msm/dp: Shorten SETUP timeout

2021-10-06 Thread Bjorn Andersson
On Wed 06 Oct 08:37 PDT 2021, khs...@codeaurora.org wrote: > On 2021-10-05 19:10, Bjorn Andersson wrote: > > On Tue 05 Oct 16:04 PDT 2021, khs...@codeaurora.org wrote: > > > > > On 2021-10-05 15:36, Stephen Boyd wrote: > > > > Quoting Bjorn Andersson (2021-10-05 14:40:38) > > > > > On Tue 05 Oct

Re: [Freedreno] [PATCH v4 5/7] drm/msm/dp: Support up to 3 DP controllers

2021-10-06 Thread Dmitry Baryshkov
On 06/10/2021 20:07, Bjorn Andersson wrote: On Tue 05 Oct 21:26 PDT 2021, Stephen Boyd wrote: Quoting Bjorn Andersson (2021-10-05 19:37:52) On Tue 05 Oct 19:06 PDT 2021, Stephen Boyd wrote: Quoting Bjorn Andersson (2021-10-05 18:43:16) On Tue 05 Oct 17:43 PDT 2021, Stephen Boyd wrote:

Re: [Freedreno] [PATCH v4 5/7] drm/msm/dp: Support up to 3 DP controllers

2021-10-06 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-10-06 10:07:17) > On Tue 05 Oct 21:26 PDT 2021, Stephen Boyd wrote: > > > Quoting Bjorn Andersson (2021-10-05 19:37:52) > > > On Tue 05 Oct 19:06 PDT 2021, Stephen Boyd wrote: > > > > > > > Quoting Bjorn Andersson (2021-10-05 18:43:16) > > > > > On Tue 05 Oct 17:43

Re: [Freedreno] [PATCH v4 5/7] drm/msm/dp: Support up to 3 DP controllers

2021-10-06 Thread Bjorn Andersson
On Tue 05 Oct 21:26 PDT 2021, Stephen Boyd wrote: > Quoting Bjorn Andersson (2021-10-05 19:37:52) > > On Tue 05 Oct 19:06 PDT 2021, Stephen Boyd wrote: > > > > > Quoting Bjorn Andersson (2021-10-05 18:43:16) > > > > On Tue 05 Oct 17:43 PDT 2021, Stephen Boyd wrote: > > > > > > > > > Quoting Bjorn

[Freedreno] [PATCH] drm/msm/dp: do not initialize combo phy until plugin interrupt

2021-10-06 Thread Kuogee Hsieh
Combo phy support both USB3 and DP simultaneously. USB3 is the master of combo phy so that USB3 should initialize and power on its phy before DP initialize its phy. At current implementation, DP driver initialize its phy happen earlier than USB3 initialize its phy which cause timeout error at

Re: [Freedreno] [PATCH] drm/msm/dp: Shorten SETUP timeout

2021-10-06 Thread khsieh
On 2021-10-05 19:10, Bjorn Andersson wrote: On Tue 05 Oct 16:04 PDT 2021, khs...@codeaurora.org wrote: On 2021-10-05 15:36, Stephen Boyd wrote: > Quoting Bjorn Andersson (2021-10-05 14:40:38) > > On Tue 05 Oct 11:45 PDT 2021, Stephen Boyd wrote: > > > > > Quoting Bjorn Andersson (2021-10-04

Re: [Freedreno] [RFC] drm/msm/dp: Allow attaching a drm_panel

2021-10-06 Thread Doug Anderson
Hi, On Tue, Oct 5, 2021 at 7:27 PM Bjorn Andersson wrote: > > > > For reference, this is how I thought one is supposed to tie the Type-C > > > controller to the display driver: > > > https://lore.kernel.org/all/20211005022451.2037405-1-bjorn.anders...@linaro.org/ > > > > OK, so I looked at that

Re: [Freedreno] [PATCH 08/11] drm/msm/disp/dpu1: Add support for DSC in encoder

2021-10-06 Thread Vinod Koul
On 02-08-21, 17:57, abhin...@codeaurora.org wrote: > On 2021-07-14 23:52, Vinod Koul wrote: > > When DSC is enabled in DT, we need to configure the encoder for DSC > > configuration, calculate DSC parameters for the given timing. > > > > This patch adds that support by adding

Re: [Freedreno] [PATCH 08/11] drm/msm/disp/dpu1: Add support for DSC in encoder

2021-10-06 Thread Vinod Koul
On 29-07-21, 23:54, Dmitry Baryshkov wrote: > On 15/07/2021 09:52, Vinod Koul wrote: > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > > b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > > index 8d942052db8a..41140b781e66 100644 > > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c >

Re: [Freedreno] [PATCH 07/11] drm/msm/disp/dpu1: Don't use DSC with mode_3d

2021-10-06 Thread Vinod Koul
On 02-08-21, 17:24, abhin...@codeaurora.org wrote: > On 2021-07-14 23:51, Vinod Koul wrote: > > We cannot enable mode_3d when we are using the DSC. So pass > > configuration to detect DSC is enabled and not enable mode_3d > > when we are using DSC > > > > We add a helper

Re: [Freedreno] [PATCH 06/11] drm/msm/disp/dpu1: Add DSC support in hw_ctl

2021-10-06 Thread Vinod Koul
On 02-08-21, 17:00, abhin...@codeaurora.org wrote: > On 2021-07-14 23:51, Vinod Koul wrote: > > Later gens of hardware have DSC bits moved to hw_ctl, so configure these > > bits so that DSC would work there as well > > > > Signed-off-by: Vinod Koul > Please correct me if wrong but here you seem

Re: [Freedreno] [PATCH 06/11] drm/msm/disp/dpu1: Add DSC support in hw_ctl

2021-10-06 Thread Vinod Koul
On 30-07-21, 01:15, Dmitry Baryshkov wrote: > On 15/07/2021 09:51, Vinod Koul wrote: > > Later gens of hardware have DSC bits moved to hw_ctl, so configure these > > bits so that DSC would work there as well > > > > Signed-off-by: Vinod Koul > > --- > >

Re: [Freedreno] [PATCH v4 5/7] drm/msm/dp: Support up to 3 DP controllers

2021-10-06 Thread Dmitry Baryshkov
Hi, On Wed, 6 Oct 2021 at 10:06, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2021-10-05 23:10:22) > > On Wed, 6 Oct 2021 at 07:26, Stephen Boyd wrote: > > > > > > Quoting Bjorn Andersson (2021-10-05 19:37:52) > > > > On Tue 05 Oct 19:06 PDT 2021, Stephen Boyd wrote: > > > > > > > > >

Re: [Freedreno] mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o)

2021-10-06 Thread Christian König
Am 06.10.21 um 09:20 schrieb Stephen Rothwell: Hi Randy, On Tue, 5 Oct 2021 22:48:03 -0700 Randy Dunlap wrote: on i386: ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg' Full randconfig fle is attached. This would be because

Re: [Freedreno] [PATCH 05/11] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog

2021-10-06 Thread Vinod Koul
On 02-08-21, 16:29, abhin...@codeaurora.org wrote: > On 2021-07-14 23:51, Vinod Koul wrote: > > This add SDM845 DSC blocks into hw_catalog > /add --> adds > > > > Signed-off-by: Vinod Koul > > --- > > Changes since RFC: > > - use BIT values from MASK > > > >

Re: [Freedreno] [PATCH 05/11] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog

2021-10-06 Thread Vinod Koul
On 29-07-21, 23:25, Dmitry Baryshkov wrote: > On 15/07/2021 09:51, Vinod Koul wrote: > > This add SDM845 DSC blocks into hw_catalog > > > > Signed-off-by: Vinod Koul > > --- > > Changes since RFC: > > - use BIT values from MASK > > > > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 22

Re: [Freedreno] [PATCH 04/11] drm/msm/disp/dpu1: Add DSC support in RM

2021-10-06 Thread Vinod Koul
On 02-08-21, 16:24, abhin...@codeaurora.org wrote: > On 2021-07-14 23:51, Vinod Koul wrote: > > @@ -476,6 +498,9 @@ static int _dpu_rm_reserve_intf( > > } > > > > global_state->intf_to_enc_id[idx] = enc_id; > > + > > + global_state->dsc_to_enc_id[0] = enc_id; > > +

Re: [Freedreno] [PATCH 04/11] drm/msm/disp/dpu1: Add DSC support in RM

2021-10-06 Thread Vinod Koul
On 29-07-21, 23:23, Dmitry Baryshkov wrote: > On 15/07/2021 09:51, Vinod Koul wrote: > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c > > b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c > > index fd2d104f0a91..4da6d72b7996 100644 > > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c > > +++

Re: [Freedreno] mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o)

2021-10-06 Thread Stephen Rothwell
Hi Randy, On Tue, 5 Oct 2021 22:48:03 -0700 Randy Dunlap wrote: > > on i386: > > ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference > to `msm_hdmi_phy_8996_cfg' > > > Full randconfig fle is attached. This would be because CONFIG_DRM_MSM is set but

Re: [Freedreno] [PATCH v4 5/7] drm/msm/dp: Support up to 3 DP controllers

2021-10-06 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-10-05 23:10:22) > On Wed, 6 Oct 2021 at 07:26, Stephen Boyd wrote: > > > > Quoting Bjorn Andersson (2021-10-05 19:37:52) > > > On Tue 05 Oct 19:06 PDT 2021, Stephen Boyd wrote: > > > > > > > Quoting Bjorn Andersson (2021-10-05 18:43:16) > > > > > On Tue 05 Oct 17:43

Re: [Freedreno] [PATCH v4 5/7] drm/msm/dp: Support up to 3 DP controllers

2021-10-06 Thread Dmitry Baryshkov
On Wed, 6 Oct 2021 at 07:26, Stephen Boyd wrote: > > Quoting Bjorn Andersson (2021-10-05 19:37:52) > > On Tue 05 Oct 19:06 PDT 2021, Stephen Boyd wrote: > > > > > Quoting Bjorn Andersson (2021-10-05 18:43:16) > > > > On Tue 05 Oct 17:43 PDT 2021, Stephen Boyd wrote: > > > > > > > > > Quoting