Re: [Freedreno] [PATCH] drm/msm/a6xx: Add missing suspend_count increment

2022-01-24 Thread Dmitry Baryshkov
On 13/01/2022 19:32, Rob Clark wrote: From: Rob Clark Reported-by: Danylo Piliaiev Fixes: 3ab1c5cc3939 ("drm/msm: Add param for userspace to query suspend count") Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 ++ 1 file changed,

Re: [Freedreno] [PATCH] drm/msm: Fix wrong size calculation

2022-01-24 Thread Dmitry Baryshkov
On 12/01/2022 15:33, Xianting Tian wrote: For example, memory-region in .dts as below, reg = <0x0 0x5000 0x0 0x2000> We can get below values, struct resource r; r.start = 0x5000; r.end = 0x6fff; So the size should be: size = r.end - r.start + 1 = 0x2000

Re: [Freedreno] [PATCH] drm/msm/dsi: invalid parameter check in msm_dsi_phy_enable

2022-01-24 Thread Dmitry Baryshkov
On 16/01/2022 21:18, José Expósito wrote: The function performs a check on the "phy" input parameter, however, it is used before the check. Initialize the "dev" variable after the sanity check to avoid a possible NULL pointer dereference. Fixes: 5c8290284402b ("drm/msm/dsi: Split PHY drivers

Re: [Freedreno] [v3 2/3] drm/msm/dsi: Add dsi phy tuning configuration support

2022-01-24 Thread Dmitry Baryshkov
On 18/01/2022 23:38, Rajeev Nandan wrote: Add support for MSM DSI PHY tuning configuration. Current design is to support drive strength and drive level/amplitude tuning for 10nm PHY version, but this can be extended to other PHY versions. Signed-off-by: Rajeev Nandan Reviewed-by: Dmitry

Re: [Freedreno] [v3 3/3] drm/msm/dsi: Add 10nm dsi phy tuning configuration support

2022-01-24 Thread Dmitry Baryshkov
On 18/01/2022 23:38, Rajeev Nandan wrote: The clock and data lanes of the DSI PHY have a calibration circuitry feature. As per the MSM DSI PHY tuning guidelines, the drive strength tuning can be done by adjusting rescode offset for hstop/hsbot, and the drive level tuning can be done by adjusting

Re: [Freedreno] [PATCH] drm/msm/dp: add connector type to enhance debug messages

2022-01-24 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-24 14:44:52) > DP driver is a generic driver which supports both eDP and DP. > For debugging purpose it is required to have capabilities to > differentiate message are generated from eDP or DP. This patch > add connector type into debug messages for this purpose. > >

[Freedreno] [PATCH v2] drm/msm/dp: always add fail-safe mode into connector mode list

2022-01-24 Thread Kuogee Hsieh
Some of DP link compliant test expects to return fail-safe mode if prefer detailed timing mode can not be supported by mainlink's lane and rate after link training. Therefore add fail-safe mode into connector mode list as backup mode. This patch fixes test case 4.2.2.1. Changes in v2: -- add

[Freedreno] [PATCH] drm/msm/dp: add connector type to enhance debug messages

2022-01-24 Thread Kuogee Hsieh
DP driver is a generic driver which supports both eDP and DP. For debugging purpose it is required to have capabilities to differentiate message are generated from eDP or DP. This patch add connector type into debug messages for this purpose. Signed-off-by: Kuogee Hsieh ---

Re: [Freedreno] [PATCH] drm/msm/dp: always add fail-safe mode into connector mode list

2022-01-24 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-24 13:24:25) > > On 1/24/2022 1:04 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-01-24 12:46:10) > >> Some of DP link compliant test expects to return fail-safe mode > >> if prefer detailed timing mode can not be supported by mainlink's > >> lane and rate

Re: [Freedreno] [PATCH] drm/msm/dp: always add fail-safe mode into connector mode list

2022-01-24 Thread Kuogee Hsieh
On 1/24/2022 1:04 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-01-24 12:46:10) Some of DP link compliant test expects to return fail-safe mode if prefer detailed timing mode can not be supported by mainlink's lane and rate after link training. Therefore add fail-safe mode into connector

Re: [Freedreno] [PATCH] drm/msm/dp: always add fail-safe mode into connector mode list

2022-01-24 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-24 12:46:10) > Some of DP link compliant test expects to return fail-safe mode > if prefer detailed timing mode can not be supported by mainlink's > lane and rate after link training. Therefore add fail-safe mode > into connector mode list as backup mode. This patch

[Freedreno] [PATCH] drm/msm/dp: always add fail-safe mode into connector mode list

2022-01-24 Thread Kuogee Hsieh
Some of DP link compliant test expects to return fail-safe mode if prefer detailed timing mode can not be supported by mainlink's lane and rate after link training. Therefore add fail-safe mode into connector mode list as backup mode. This patch fixes test case 4.2.2.1. Signed-off-by: Kuogee

Re: [Freedreno] [PATCH v1 2/2] drm/panel-edp: Add sharp panel support for sc7280

2022-01-24 Thread Doug Anderson
Hi, On Mon, Jan 24, 2022 at 10:16 AM Sankeerth Billakanti wrote: > > Add eDP panel support for sc7280 CRD platform. > > Signed-off-by: Sankeerth Billakanti > --- > drivers/gpu/drm/panel/panel-edp.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git

Re: [Freedreno] [PATCH v1 1/2] ARM64: dts: qcom: enable eDP panel support for sc7280

2022-01-24 Thread Doug Anderson
Hi, On Mon, Jan 24, 2022 at 10:15 AM Sankeerth Billakanti wrote: > > Enable the eDP display panel support with backlight on sc7280 platform. > > Signed-off-by: Sankeerth Billakanti > --- > arch/arm64/boot/dts/qcom/sc7280-crd.dts | 127 > > 1 file changed, 127

[Freedreno] [PATCH v1 2/2] drm/panel-edp: Add sharp panel support for sc7280

2022-01-24 Thread Sankeerth Billakanti
Add eDP panel support for sc7280 CRD platform. Signed-off-by: Sankeerth Billakanti --- drivers/gpu/drm/panel/panel-edp.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 176ef0c..bb2e346 100644 ---

[Freedreno] [PATCH v1 1/2] ARM64: dts: qcom: enable eDP panel support for sc7280

2022-01-24 Thread Sankeerth Billakanti
Enable the eDP display panel support with backlight on sc7280 platform. Signed-off-by: Sankeerth Billakanti --- arch/arm64/boot/dts/qcom/sc7280-crd.dts | 127 1 file changed, 127 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts

[Freedreno] [PATCH v1 0/2] Add support for the eDP panel on sc7280 CRD

2022-01-24 Thread Sankeerth Billakanti
Add support for the eDP panel on sc7280 CRD platform. These changes are dependent on the following series: https://patchwork.kernel.org/project/linux-arm-msm/list/?series=586263=both=* https://patchwork.kernel.org/project/linux-arm-msm/list/?series=560587=%2A=both Sankeerth Billakanti (2):

Re: [Freedreno] [PATCH v3 2/3] drm/msm/dpu: simplify clocks handling

2022-01-24 Thread Dmitry Baryshkov
On Fri, 21 Jan 2022 at 23:44, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2022-01-20 23:37:45) > > On Fri, 21 Jan 2022 at 07:30, Stephen Boyd wrote: > > > > > > Quoting Dmitry Baryshkov (2022-01-19 14:16:15) > > > > diff --git a/drivers/gpu/drm/msm/msm_io_utils.c > > > >