OK, I am sorry. Thanks
主 题：Re: [PATCH RESEND] drm/msm/dsi: fix the inconsistent indenting
日 期：2022-08-27 00:10
发件人：Abhinav Kumar
收件人：孙立明christian.koenig@amd.comrobdclark@gmail.comdmitry.barysh...@linaro.org
On
Hi Dmitry,
On Fri, Aug 26, 2022 at 04:52:12PM +0300, Dmitry Baryshkov wrote:
> On 26/08/2022 14:55, Laurent Pinchart wrote:
> > On Fri, Aug 26, 2022 at 01:17:43PM +0300, Dmitry Baryshkov wrote:
> >> On 22/08/2022 19:31, Dmitry Baryshkov wrote:
> >>> On 09/08/2022 22:40, Laurent Pinchart wrote:
> >
On 8/26/2022 1:19 AM, Dmitry Baryshkov wrote:
On 24/08/2022 22:16, Abhinav Kumar wrote:
On 8/24/2022 1:25 AM, Dmitry Baryshkov wrote:
On Wed, 24 Aug 2022 at 01:59, Abhinav Kumar
wrote:
On 8/23/2022 3:41 PM, Dmitry Baryshkov wrote:
On Wed, 24 Aug 2022 at 01:07, Abhinav Kumar
wrote:
On 8/26/2022 1:49 AM, sunliming wrote:
Fix the inconsistent indenting in function msm_dsi_dphy_timing_calc_v3().
Fix the following smatch warnings:
drivers/gpu/drm/msm/dsi/phy/dsi_phy.c:350 msm_dsi_dphy_timing_calc_v3() warn:
inconsistent indenting
Fixes: f1fa7ff44056 ("drm/msm/dsi: implem
On 04/07/2022 19:11, Dmitry Baryshkov wrote:
Add #clock-cells property to the HDMI PHY device node to let other nodes
resolve the hdmipll clock. While we are at it, also add the XO clock to
the device node.
Acked-by: Krzysztof Kozlowski
Signed-off-by: Dmitry Baryshkov
Bjorn, I'm picking the
On 24/08/2022 20:20, Abhinav Kumar wrote:
On 8/24/2022 1:29 AM, Dmitry Baryshkov wrote:
On Wed, 24 Aug 2022 at 04:25, Abhinav Kumar
wrote:
On 6/20/2022 2:30 PM, Dmitry Baryshkov wrote:
The rest of the code expects that master's device drvdata is the
struct msm_drm_private instance. Do no
On 27/06/2022 14:56, Kalyan Thota wrote:
Thanks for the comments, Dmitry. I haven't noticed mode->hdisplay being used.
My idea was to run thru the topology and tie up the encoders with dspp to the
CRTCs.
Since mode is available only in the commit, we cannot use the
dpu_encoder_get_topology dur
On 26/08/2022 14:55, Laurent Pinchart wrote:
Hello,
On Fri, Aug 26, 2022 at 01:17:43PM +0300, Dmitry Baryshkov wrote:
On 22/08/2022 19:31, Dmitry Baryshkov wrote:
On 09/08/2022 22:40, Laurent Pinchart wrote:
On Mon, Aug 08, 2022 at 05:35:30PM -0700, Abhinav Kumar wrote:
adv7533 bridge tries
Hi Abhinav,
On Tue, Aug 09, 2022 at 02:47:32PM -0700, Abhinav Kumar wrote:
> On 8/9/2022 12:40 PM, Laurent Pinchart wrote:
> > On Mon, Aug 08, 2022 at 05:35:30PM -0700, Abhinav Kumar wrote:
> >> adv7533 bridge tries to dynamically switch lanes based on the
> >> mode by detaching and attaching the
Hello,
On Fri, Aug 26, 2022 at 01:17:43PM +0300, Dmitry Baryshkov wrote:
> On 22/08/2022 19:31, Dmitry Baryshkov wrote:
> > On 09/08/2022 22:40, Laurent Pinchart wrote:
> >> On Mon, Aug 08, 2022 at 05:35:30PM -0700, Abhinav Kumar wrote:
> >>> adv7533 bridge tries to dynamically switch lanes based
On 08/08/2022 13:44, Kalyan Thota wrote:
-Original Message-
From: Dmitry Baryshkov
Sent: Thursday, August 4, 2022 9:29 PM
To: Kalyan Thota (QUIC)
Cc: dri-de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org;
freedreno@lists.freedesktop.org; devicet...@vger.kernel.org; linux-
ke
On 22/08/2022 19:31, Dmitry Baryshkov wrote:
On 09/08/2022 22:40, Laurent Pinchart wrote:
Hi Abhinav,
Thank you for the patch.
On Mon, Aug 08, 2022 at 05:35:30PM -0700, Abhinav Kumar wrote:
adv7533 bridge tries to dynamically switch lanes based on the
mode by detaching and attaching the mipi
On 24/08/2022 23:15, Kuogee Hsieh wrote:
At current implementation there is an extra 0 at 1.62G link rate which cause
no correct pixel_div selected for 1.62G link rate to calculate mvid and nvid.
This patch delete the extra 0 to have mvid and nvid be calculated correctly.
Changes in v2:
-- fix F
On 26/08/2022 11:45, Yang Yingliang wrote:
Use memdup_user_nul() helper instead of open-coding to
simplify the code.
Signed-off-by: Yang Yingliang
Reviewed-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions
On 23/08/2022 17:56, Rob Herring wrote:
In order to ensure only documented properties are present, node schemas
must have unevaluatedProperties or additionalProperties set to false
(typically).
Signed-off-by: Rob Herring
---
Documentation/devicetree/bindings/display/arm,komeda.yaml| 1
On 26/08/2022 12:53, Dan Carpenter wrote:
On Fri, Aug 26, 2022 at 12:45:09PM +0300, Dmitry Baryshkov wrote:
On 24/07/2022 10:36, wangjianli wrote:
Delete the redundant word 'in'.
Could you please:
- adjust the commit subject to follow the rest of commit messages,
- drop the extra whitespac
On Fri, Aug 26, 2022 at 12:45:09PM +0300, Dmitry Baryshkov wrote:
> On 24/07/2022 10:36, wangjianli wrote:
> > Delete the redundant word 'in'.
>
> Could you please:
> - adjust the commit subject to follow the rest of commit messages,
> - drop the extra whitespace at the beginning of the commit m
On 17/08/2022 09:20, Krzysztof Kozlowski wrote:
The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses
opp-table, so reference it which allows restricting DPU schema to fixed
list of properties.
Fixes: 3d7a0dd8f39b ("dt-bindings: msm: disp: add yaml schemas for DPU
bindings")
Sig
On 17/08/2022 09:20, Krzysztof Kozlowski wrote:
The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses
opp-table, so reference it which allows restricting DPU schema to fixed
list of properties.
Fixes: 57fd4f34ddac ("dt-bindings: msm: add DT bindings for sc7280")
Signed-off-by: Kr
On 17/08/2022 09:20, Krzysztof Kozlowski wrote:
The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses
opp-table, so reference it which allows restricting DPU schema to fixed
list of properties.
Fixes: 3d7a0dd8f39b ("dt-bindings: msm: disp: add yaml schemas for DPU
bindings")
Sig
On 17/08/2022 09:20, Krzysztof Kozlowski wrote:
The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses
opp-table, so reference it which allows restricting DPU schema to fixed
list of properties.
Fixes: 164f69d9d45a ("dt-bindings: msm: disp: add yaml schemas for QCM2290 DPU
bindin
On 17/08/2022 09:20, Krzysztof Kozlowski wrote:
The 'display-controller' child (DPU) of Display SubSystem (MDSS) uses
opp-table, so reference it which allows restricting DPU schema to fixed
list of properties.
Fixes: 6e986a8f1cf1 ("dt-bindings: display: msm: Add binding for msm8998 dpu")
Signed-
On 25/08/2022 14:33, Krzysztof Kozlowski wrote:
minItems, if missing, are implicitly equal to maxItems, so drop
redundant piece to reduce size of code.
Signed-off-by: Krzysztof Kozlowski
---
Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml | 1 -
.../devicetree/bindings/displa
On 23/08/2022 14:56, Jilin Yuan wrote:
Delete the redundant word 'power'.
Delete the redundant word 'in'.
Delete the redundant word 'for'.
Signed-off-by: Jilin Yuan
Could you please:
- adjust the commit subject to follow the rest of commit messages,
- drop the extra whitespace at the be
On 24/07/2022 10:36, wangjianli wrote:
Delete the redundant word 'in'.
Could you please:
- adjust the commit subject to follow the rest of commit messages,
- drop the extra whitespace at the beginning of the commit message,
- add a correct Fixes tag.
Thank you
Signed-off-by: wangjianli
-
On 23/08/2022 14:54, Jilin Yuan wrote:
Delete the redundant word 'one'.
The whitespace is unnecessary.
Signed-off-by: Jilin Yuan
Reviewed-by: Dmitry Baryshkov
Fixes: 7198e6b03155 ("drm/msm: add a3xx gpu support")
---
drivers/gpu/drm/msm/msm_gem.h | 2 +-
1 file changed, 1 inserti
To continue the idea of failing the probe() rather than failing the
bind(), move the call to msm_hdmi_get_phy() function to
msm_hdmi_dev_probe(), so that the driver fails the probe if PHY is not
yet available rather than succeeding the probe and then failing the
bind() with -EPROBE_DEFER.
Signed-o
Rather than having all resource allocation happen in the _bind function
(resulting in possible EPROBE_DEFER returns and component bind/unbind
cycles) allocate and check all resources in _probe function. While we
are at it, use platform_get_irq() to get the IRQ rather than going
through the irq_of_p
The of_find_device_by_node() already increments the device's usage
count, so there is no need to increment it again using get_device().
Drop this extra get_device().
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
Use devm_pm_runtime_enable() to enable runtime PM. This way its effect
will be reverted on device unbind/destruction.
Fixes: 6ed9ed484d04 ("drm/msm/hdmi: Set up runtime PM for HDMI")
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +-
1 file ch
All MSM HDMI devices use "core_physical" and "qfprom_physical" names for
register areas. Drop them from the platform config.
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
drivers/gpu/drm/msm/hdmi/hdmi.c | 9 +++--
drivers/gpu/drm/msm/hdmi/hdmi.h | 3 ---
2 files changed, 3
As pointed several times in the discussions, start moving resource
allocation from component bind to the probe function. This simplifies
boot process, as the component will not be registered until all
resources (clocks, regulators, IRQ, etc.) are not registered.
Changes since v1:
- Moved a call t
On 24/08/2022 00:31, Stephen Boyd wrote:
Quoting Dmitry Baryshkov (2022-08-05 04:56:30)
diff --git a/drivers/gpu/drm/msm/msm_io_utils.c
b/drivers/gpu/drm/msm/msm_io_utils.c
index 7b504617833a..d02cd29ce829 100644
--- a/drivers/gpu/drm/msm/msm_io_utils.c
+++ b/drivers/gpu/drm/msm/msm_io_utils.c
On 05/08/2022 15:24, Marijn Suijten wrote:
On 2022-08-05 14:56:30, Dmitry Baryshkov wrote:
The commit 6874f48bb8b0 ("drm/msm: make mdp5/dpu devices master
components") changed the MDP5 driver to look for the interconnect paths
in the MDSS device rather than in the MDP5 device itself. This was le
On 26/08/2022 11:49, sunliming wrote:
Fix the inconsistent indenting in function msm_dsi_dphy_timing_calc_v3().
Fix the following smatch warnings:
drivers/gpu/drm/msm/dsi/phy/dsi_phy.c:350 msm_dsi_dphy_timing_calc_v3() warn:
inconsistent indenting
Fixes: f1fa7ff44056 ("drm/msm/dsi: implement
On 15/07/2022 22:14, Abhinav Kumar wrote:
dpu_encoder_helper_phys_cleanup() was not populating neither
wb or intf to the intf_cfg before calling the reset_intf_cfg().
This causes the reset of the active bits of wb/intf to be
skipped which is incorrect.
Fix this by populating the relevant wb or
On 23/06/2022 03:25, Stephen Boyd wrote:
This API isn't really more than a couple lines now that we don't store
the pixel_rate to the struct member. Inline it into the caller.
Cc: Kuogee Hsieh
Signed-off-by: Stephen Boyd
Reviewed-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/dp/dp_ctrl.c
On 23/06/2022 03:25, Stephen Boyd wrote:
This struct member is stored to in the function that calls the function
which uses it. That's possible with a function argument instead of
storing to a struct member. Pass the pixel_rate as an argument instead
to simplify the code. Note that dp_ctrl_link_m
On 24/08/2022 02:58, Abhinav Kumar wrote:
On 6/16/2022 12:59 AM, Dmitry Baryshkov wrote:
Rather than having all resource allocation happen in the _bind function
(resulting in possible EPROBE_DEFER returns and component bind/unbind
cycles) allocate and check all resources in _probe function. Wh
Fix the inconsistent indenting in function msm_dsi_dphy_timing_calc_v3().
Fix the following smatch warnings:
drivers/gpu/drm/msm/dsi/phy/dsi_phy.c:350 msm_dsi_dphy_timing_calc_v3() warn:
inconsistent indenting
Fixes: f1fa7ff44056 ("drm/msm/dsi: implement auto PHY timing calculator for
10nm PHY
On 15/06/2022 15:23, Dmitry Baryshkov wrote:
On 03/06/2022 12:42, Vinod Polimera wrote:
During probe defer, drm device is not initialized and an external
trigger to shutdown is trying to clean up drm device leading to crash.
Add checks to avoid drm device cleanup in such cases.
BUG: unable to h
On 26/08/2022 10:28, cgel@gmail.com wrote:
From: ye xingchen
Return the value msm_dsi_phy_enable() directly instead of storing it in
another redundant variable.
Reported-by: Zeal Robot
Signed-off-by: ye xingchen
Reviewed-by: Dmitry Baryshkov
--
With best wishes
Dmitry
On 24/08/2022 22:16, Abhinav Kumar wrote:
On 8/24/2022 1:25 AM, Dmitry Baryshkov wrote:
On Wed, 24 Aug 2022 at 01:59, Abhinav Kumar
wrote:
On 8/23/2022 3:41 PM, Dmitry Baryshkov wrote:
On Wed, 24 Aug 2022 at 01:07, Abhinav Kumar
wrote:
On 8/22/2022 11:33 AM, Dmitry Baryshkov wrote:
On
From: ye xingchen
Return the value msm_dsi_phy_enable() directly instead of storing it in
another redundant variable.
Reported-by: Zeal Robot
Signed-off-by: ye xingchen
---
drivers/gpu/drm/msm/dsi/dsi_manager.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gp
44 matches
Mail list logo
