Re: [Freedreno] [PATCH v3 1/2] dt-bindings: display/msm: Add QCM2290 DSI phy

2022-09-26 Thread Rob Herring
On Sat, 24 Sep 2022 15:18:59 +0300, Dmitry Baryshkov wrote: > From: Loic Poulain > > QCM2290 platform uses the 14nm DSI PHY driver. > > Signed-off-by: Loic Poulain > Signed-off-by: Dmitry Baryshkov > --- > Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml | 1 + > 1 file

Re: [Freedreno] [PATCH] drm/msm/dpu: use DEFINE_SHOW_ATTRIBUTE to simplify dpu_regset32

2022-09-26 Thread Abhinav Kumar
On 9/22/2022 7:21 AM, Liu Shixin wrote: Use DEFINE_SHOW_ATTRIBUTE helper macro to simplify the code. No functional change. Signed-off-by: Liu Shixin Looks reasonable to me Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 +++--- 1 file changed,

Re: [Freedreno] [PATCH v2 10/10] drm/msm/dsi: drop modeset sanity checks

2022-09-26 Thread Abhinav Kumar
On 9/13/2022 1:53 AM, Johan Hovold wrote: Drop the overly defensive modeset sanity checks of function parameters which have already been checked or used by the callers. Reviewed-by: Dmitry Baryshkov Signed-off-by: Johan Hovold The change LGTM, hence Reviewed-by: Abhinav Kumar I think

Re: [Freedreno] [PATCH v2 09/10] drm/msm/dp: drop modeset sanity checks

2022-09-26 Thread Abhinav Kumar
On 9/13/2022 1:53 AM, Johan Hovold wrote: Drop the overly defensive modeset sanity checks of function parameters which have already been checked or used by the callers. Reviewed-by: Dmitry Baryshkov Signed-off-by: Johan Hovold The change LGTM, hence Reviewed-by: Abhinav Kumar I think

Re: [Freedreno] [PATCH v2 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-09-26 Thread Krzysztof Kozlowski
On 26/09/2022 17:13, Rob Herring wrote: > On Thu, Sep 22, 2022 at 05:37:39PM +0200, Krzysztof Kozlowski wrote: >> On 22/09/2022 02:14, Bjorn Andersson wrote: >>> On Tue, Sep 20, 2022 at 09:09:13AM +0200, Krzysztof Kozlowski wrote: On 19/09/2022 23:18, Bjorn Andersson wrote: > On Sat, Sep

Re: [Freedreno] [PATCH v2 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-09-26 Thread Rob Herring
On Thu, Sep 22, 2022 at 05:37:39PM +0200, Krzysztof Kozlowski wrote: > On 22/09/2022 02:14, Bjorn Andersson wrote: > > On Tue, Sep 20, 2022 at 09:09:13AM +0200, Krzysztof Kozlowski wrote: > >> On 19/09/2022 23:18, Bjorn Andersson wrote: > >>> On Sat, Sep 17, 2022 at 06:03:27PM +0100, Krzysztof