Re: [Freedreno] [PATCH 06/10] drm/msm: fix vram leak on bind errors

2023-03-24 Thread Dmitry Baryshkov
On Mon, 6 Mar 2023 at 12:09, Johan Hovold wrote: > > Make sure to release the VRAM buffer also in a case a subcomponent fails > to bind. > > Fixes: d863f0c7b536 ("drm/msm: Call msm_init_vram before binding the gpu") > Cc: sta...@vger.kernel.org # 5.11 > Cc: Craig Tatlor > Signed-off-by:

Re: [Freedreno] [PATCH 05/10] drm/msm: fix drm device leak on bind errors

2023-03-24 Thread Dmitry Baryshkov
On Wed, 22 Mar 2023 at 09:46, Johan Hovold wrote: > > On Tue, Mar 21, 2023 at 04:54:51PM +0200, Dmitry Baryshkov wrote: > > On 06/03/2023 12:07, Johan Hovold wrote: > > > Make sure to free the DRM device also in case of early errors during > > > bind(). > > > > > > Fixes: 2027e5b3413d ("drm/msm:

[Freedreno] [PATCH] drm/msm: Avoid rounding down to zero jiffies

2023-03-24 Thread Rob Clark
From: Rob Clark If userspace asked for a timeout greater than zero, but less than a jiffy, they clearly weren't planning on spinning. So it is better to round up to one. This fixes an issue with supertuxkart that was (for some reason) spinning on a gl sync with 1ms timeout. CPU time for a

Re: [Freedreno] [PATCH v2 2/4] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes

2023-03-24 Thread Krzysztof Kozlowski
On 24/03/2023 20:57, Bjorn Andersson wrote: > On Fri, Mar 24, 2023 at 08:27:12PM +0100, Krzysztof Kozlowski wrote: >> On 24/03/2023 18:45, Bjorn Andersson wrote: >>> On Fri, Mar 24, 2023 at 10:28:47AM +0100, Neil Armstrong wrote: Fixes the following DT bindings check error: >>> >>> Is that

Re: [Freedreno] [PATCH v7 10/10] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2023-03-24 Thread Dmitry Baryshkov
On Fri, 24 Mar 2023 at 21:21, Mark Yacoub wrote: > > From: Sean Paul > > Add HDCP 1.x support to msm DP bridges using the new HDCP > helpers. > > Cc: Stephen Boyd > Reviewed-by: Stephen Boyd > Signed-off-by: Sean Paul > Signed-off-by: Mark Yacoub > > --- > > Changes in v2: > -Squash [1] into

[Freedreno] [PATCH v7 10/10] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2023-03-24 Thread Mark Yacoub
From: Sean Paul Add HDCP 1.x support to msm DP bridges using the new HDCP helpers. Cc: Stephen Boyd Reviewed-by: Stephen Boyd Signed-off-by: Sean Paul Signed-off-by: Mark Yacoub --- Changes in v2: -Squash [1] into this patch with the following changes (Stephen) -Update the sc7180 dtsi

[Freedreno] [PATCH v7 08/10] dt-bindings: msm/dp: Add bindings for HDCP registers

2023-03-24 Thread Mark Yacoub
From: Sean Paul Add the bindings for the MSM DisplayPort HDCP registers which are required to write the HDCP key into the display controller as well as the registers to enable HDCP authentication/key exchange/encryption. Cc: Rob Herring Cc: Stephen Boyd Reviewed-by: Rob Herring

[Freedreno] [PATCH v7 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2023-03-24 Thread Mark Yacoub
From: Sean Paul The shim functions return error codes, but they are discarded in intel_hdcp.c. This patch plumbs the return codes through so they are properly handled. Acked-by: Jani Nikula Reviewed-by: Rodrigo Vivi Signed-off-by: Sean Paul Signed-off-by: Mark Yacoub --- Changes in v2:

[Freedreno] [PATCH v7 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller

2023-03-24 Thread Mark Yacoub
From: Sean Paul Add the register ranges required for HDCP key injection and HDCP TrustZone interaction as described in the dt-bindings for the sc7180 dp controller. Signed-off-by: Sean Paul Signed-off-by: Mark Yacoub --- Changes in v3: -Split off into a new patch containing just the dts

[Freedreno] [PATCH v7 07/10] drm/i915/hdcp: Use HDCP helpers for i915

2023-03-24 Thread Mark Yacoub
From: Sean Paul Now that all of the HDCP 1.x logic has been migrated to the central HDCP helpers, use it in the i915 driver. The majority of the driver code for HDCP 1.x will live in intel_hdcp.c, however there are a few helper hooks which are connector-specific and need to be partially or

[Freedreno] [PATCH v7 04/10] drm/hdcp: Expand HDCP helper library for enable/disable/check

2023-03-24 Thread Mark Yacoub
From: Sean Paul Expand upon the HDCP helper library to manage HDCP enable, disable, and check. Previous to this patch, the majority of the state management and sink interaction is tucked inside the Intel driver with the understanding that once a new platform supported HDCP we could make good

[Freedreno] [PATCH v7 05/10] drm/i915/hdcp: Consolidate HDCP setup/state cache

2023-03-24 Thread Mark Yacoub
From: Sean Paul Stick all of the setup for HDCP into a dedicated function. No functional change, but this will facilitate moving HDCP logic into helpers. Acked-by: Jani Nikula Reviewed-by: Rodrigo Vivi Signed-off-by: Sean Paul --- Changes in v2: -None Changes in v3: -None Changes in v4:

[Freedreno] [PATCH v7 03/10] drm/hdcp: Update property value on content type and user changes

2023-03-24 Thread Mark Yacoub
From: Sean Paul Update the connector's property value in 2 cases which were previously missed: 1- Content type changes. The value should revert back to DESIRED from ENABLED in case the driver must re-authenticate the link due to the new content type. 2- Userspace sets value to DESIRED

[Freedreno] [PATCH v7 02/10] drm/hdcp: Avoid changing crtc state in hdcp atomic check

2023-03-24 Thread Mark Yacoub
From: Sean Paul Instead of forcing a modeset in the hdcp atomic check, rename to drm_hdcp_has_changed and return true if the content protection value is changing and let the driver decide whether a modeset is required or not. Acked-by: Jani Nikula Reviewed-by: Rodrigo Vivi Signed-off-by: Sean

[Freedreno] [PATCH v7 01/10] drm/hdcp: Add drm_hdcp_atomic_check()

2023-03-24 Thread Mark Yacoub
From: Sean Paul Move the hdcp atomic check from i915 to drm_hdcp so other drivers can use it. No functional changes, just cleaned up some of the code when moving it over. Acked-by: Jani Nikula Reviewed-by: Rodrigo Vivi Reviewed-by: Dmitry Baryshkov Signed-off-by: Sean Paul Signed-off-by:

[Freedreno] [PATCH v7 00/10] drm/hdcp: Pull HDCP auth/exchange/check into helpers

2023-03-24 Thread Mark Yacoub
From: Mark Yacoub Hi all, This is v7 of the HDCP patches. The patches are authored by Sean Paul. I rebased and addressed the review comments in v6-v7. Patches 1-4 focus on moving the common HDCP helpers to common DRM. This introduces a slight change in the original intel flow as it splits the

Re: [Freedreno] [PATCH v2 2/4] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes

2023-03-24 Thread Bjorn Andersson
On Fri, Mar 24, 2023 at 08:27:12PM +0100, Krzysztof Kozlowski wrote: > On 24/03/2023 18:45, Bjorn Andersson wrote: > > On Fri, Mar 24, 2023 at 10:28:47AM +0100, Neil Armstrong wrote: > >> Fixes the following DT bindings check error: > > > > Is that because idle-state-name and local-timer-stop

Re: [Freedreno] [Intel-gfx] [PATCH v6 07/10] drm/i915/hdcp: Use HDCP helpers for i915

2023-03-24 Thread Mark Yacoub
On Tue, Mar 14, 2023 at 1:54 AM Kandpal, Suraj wrote: > > > > > From: Sean Paul > > > > Now that all of the HDCP 1.x logic has been migrated to the central HDCP > > helpers, use it in the i915 driver. > > > > The majority of the driver code for HDCP 1.x will live in intel_hdcp.c, > > however

Re: [Freedreno] [PATCH v6 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2023-03-24 Thread Mark Yacoub
On Thu, Mar 23, 2023 at 3:18 AM Kandpal, Suraj wrote: > > > > > -Original Message- > > From: Kandpal, Suraj > > Sent: Friday, March 10, 2023 1:55 PM > > To: Mark Yacoub ; quic_khs...@quicinc.com; > > linux-arm-...@vger.kernel.org; dri-de...@lists.freedesktop.org; > >

Re: [Freedreno] [PATCH v2 2/4] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes

2023-03-24 Thread Krzysztof Kozlowski
On 24/03/2023 18:45, Bjorn Andersson wrote: > On Fri, Mar 24, 2023 at 10:28:47AM +0100, Neil Armstrong wrote: >> Fixes the following DT bindings check error: > > Is that because idle-state-name and local-timer-stop should not be > defined for domain-idle-states or are you just clearing out the >

[Freedreno] [PATCH v7 10/10] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2023-03-24 Thread Mark Yacoub
From: Sean Paul Add HDCP 1.x support to msm DP bridges using the new HDCP helpers. Cc: Stephen Boyd Reviewed-by: Stephen Boyd Signed-off-by: Sean Paul Signed-off-by: Mark Yacoub --- Changes in v2: -Squash [1] into this patch with the following changes (Stephen) -Update the sc7180 dtsi

[Freedreno] [PATCH v7 08/10] dt-bindings: msm/dp: Add bindings for HDCP registers

2023-03-24 Thread Mark Yacoub
From: Sean Paul Add the bindings for the MSM DisplayPort HDCP registers which are required to write the HDCP key into the display controller as well as the registers to enable HDCP authentication/key exchange/encryption. Cc: Rob Herring Cc: Stephen Boyd Reviewed-by: Rob Herring

Re: [Freedreno] [PATCH v2] drm/msm/dpu: Add support for AR30 format

2023-03-24 Thread Jessica Zhang
On 3/20/2023 7:58 PM, Leonard Lausen wrote: Commit da7716a249b699978fb5 ("drm/msm/dpu: Add support for XR30 format") enabled support for the 10-bit XR30 color format but missed enabling support for the corresponding per-pixel alpha-blending AR30 color format. Declaring only XR30 but not AR30

Re: [Freedreno] (subset) [PATCH v2 0/4] arm64: qcom: sm8450: bindings check cleanup

2023-03-24 Thread Bjorn Andersson
On Fri, 24 Mar 2023 10:28:45 +0100, Neil Armstrong wrote: > A few fixes to pass the DT bindings check successfully > for sm8450 qrd & hdk DTs. > > The following are still needed to pass all the checks: > - > https://lore.kernel.org/r/20230308082424.140224-3-manivannan.sadhasi...@linaro.org > -

Re: [Freedreno] (subset) [PATCH v6 0/5] arm64: dts: qcom: add DP Controller to SM8350 & SM8450 DTS

2023-03-24 Thread Bjorn Andersson
On Fri, 17 Mar 2023 16:06:31 +0100, Neil Armstrong wrote: > Switch the QMP PHY to the newly documented USB3/DP Combo PHY > bindings at [1] and add the DP controller nodes. > > The DP output is shared with the USB3 SuperSpeed lanes and is > usually connected to an USB-C port which Altmode is

Re: [Freedreno] [PATCH v2 2/4] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes

2023-03-24 Thread Bjorn Andersson
On Fri, Mar 24, 2023 at 10:28:47AM +0100, Neil Armstrong wrote: > Fixes the following DT bindings check error: Is that because idle-state-name and local-timer-stop should not be defined for domain-idle-states or are you just clearing out the dtbs_check warning? According to cpu-capacity.txt

Re: [Freedreno] [PATCH] drm/msm/a6xx: add CONFIG_PM dependency

2023-03-24 Thread Ulf Hansson
On Fri, 24 Mar 2023 at 10:55, Arnd Bergmann wrote: > > From: Arnd Bergmann > > Selecting CONFIG_PM_GENERIC_DOMAINS causes a build failure when CONFIG_PM > is not enabled: > > WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS > Depends on [n]: PM [=n] > Selected by [m]: > -

Re: [Freedreno] [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node

2023-03-24 Thread Luca Weiss
Hi Eric, On Fri Mar 24, 2023 at 7:52 AM CET, Eric Biggers wrote: > Hi Neil, > > On Thu, Mar 23, 2023 at 02:10:44PM +0100, Neil Armstrong wrote: > > Hi, > > > > On 23/03/2023 11:49, Krzysztof Kozlowski wrote: > > > On 23/03/2023 11:25, Neil Armstrong wrote: > > > > Fixes the following DT bindings

[Freedreno] [PATCH] drm/msm/a6xx: add CONFIG_PM dependency

2023-03-24 Thread Arnd Bergmann
From: Arnd Bergmann Selecting CONFIG_PM_GENERIC_DOMAINS causes a build failure when CONFIG_PM is not enabled: WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS Depends on [n]: PM [=n] Selected by [m]: - DRM_MSM [=m] && HAS_IOMEM [=y] && DRM [=m] && (ARCH_QCOM [=y] ||

Re: [Freedreno] [PATCH v2 1/4] dt-bindings: display: msm: sm8450-mdss: Fix DSI compatible

2023-03-24 Thread Krzysztof Kozlowski
On 24/03/2023 10:28, Neil Armstrong wrote: > The DSI compatible changed between patchset revisions, but that wasn't > reflected in the bindings. Fix it. > > Fixes: 0eda3c6cb1c5 ("dt-bindings: display/msm: add support for the display > on SM8450") > Signed-off-by: Neil Armstrong > ---

[Freedreno] [PATCH v2 2/4] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes

2023-03-24 Thread Neil Armstrong
Fixes the following DT bindings check error: domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: 'pinctrl-[0-9]+' domain-idle-states: cluster-sleep-1: 'idle-state-name', 'local-timer-stop' do not match any of the regexes: 'pinctrl-[0-9]+'

[Freedreno] [PATCH v2 3/4] arm64: dts: qcom: sm8450: remove invalid power-domain-names in pcie nodes

2023-03-24 Thread Neil Armstrong
Fixes the following DT bindings check error: pci@1c0: Unevaluated properties are not allowed ('power-domain-names' were unexpected) Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 -- 1 file changed, 2 deletions(-) diff --git

[Freedreno] [PATCH v2 4/4] arm64: dts: qcom: sm8450: fix pcie1 gpios properties name

2023-03-24 Thread Neil Armstrong
Add the final "s" to the pgio properties and fix the invalid "enable" name to the correct "wake", checked against the HDK8450 schematics. Fixes: bc6588bc25fb ("arm64: dts: qcom: sm8450: add PCIe1 root device") Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ++-- 1

[Freedreno] [PATCH v2 1/4] dt-bindings: display: msm: sm8450-mdss: Fix DSI compatible

2023-03-24 Thread Neil Armstrong
The DSI compatible changed between patchset revisions, but that wasn't reflected in the bindings. Fix it. Fixes: 0eda3c6cb1c5 ("dt-bindings: display/msm: add support for the display on SM8450") Signed-off-by: Neil Armstrong ---

[Freedreno] [PATCH v2 0/4] arm64: qcom: sm8450: bindings check cleanup

2023-03-24 Thread Neil Armstrong
A few fixes to pass the DT bindings check successfully for sm8450 qrd & hdk DTs. The following are still needed to pass all the checks: - https://lore.kernel.org/r/20230308082424.140224-3-manivannan.sadhasi...@linaro.org -

Re: [Freedreno] [PATCH 6/8] arm64: dts: qcom: sm8450: remove invalid npl clock in vamacro node

2023-03-24 Thread neil . armstrong
On 24/03/2023 08:17, Krzysztof Kozlowski wrote: On 23/03/2023 14:13, Neil Armstrong wrote: On 23/03/2023 11:47, Krzysztof Kozlowski wrote: On 23/03/2023 11:25, Neil Armstrong wrote: Fixes the following DT bindings check error: codec@33f: clocks: [[137, 57, 1], [137, 102, 1], [137, 103,

Re: [Freedreno] [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node

2023-03-24 Thread Krzysztof Kozlowski
On 24/03/2023 08:26, Luca Weiss wrote: > Hi Eric, > > On Fri Mar 24, 2023 at 7:52 AM CET, Eric Biggers wrote: >> Hi Neil, >> >> On Thu, Mar 23, 2023 at 02:10:44PM +0100, Neil Armstrong wrote: >>> Hi, >>> >>> On 23/03/2023 11:49, Krzysztof Kozlowski wrote: On 23/03/2023 11:25, Neil Armstrong

Re: [Freedreno] [PATCH 6/8] arm64: dts: qcom: sm8450: remove invalid npl clock in vamacro node

2023-03-24 Thread Krzysztof Kozlowski
On 23/03/2023 14:13, Neil Armstrong wrote: > On 23/03/2023 11:47, Krzysztof Kozlowski wrote: >> On 23/03/2023 11:25, Neil Armstrong wrote: >>> Fixes the following DT bindings check error: >>> codec@33f: clocks: [[137, 57, 1], [137, 102, 1], [137, 103, 1], [137, >>> 70, 1]] is too long >>>

Re: [Freedreno] [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node

2023-03-24 Thread Krzysztof Kozlowski
On 24/03/2023 07:52, Eric Biggers wrote: > Hi Neil, > > On Thu, Mar 23, 2023 at 02:10:44PM +0100, Neil Armstrong wrote: >> Hi, >> >> On 23/03/2023 11:49, Krzysztof Kozlowski wrote: >>> On 23/03/2023 11:25, Neil Armstrong wrote: Fixes the following DT bindings check error: ufshc@1d84000:

Re: [Freedreno] [PATCH 4/8] arm64: dts: qcom: sm8450: remove invalid properties in cluster-sleep nodes

2023-03-24 Thread Krzysztof Kozlowski
On 23/03/2023 14:14, Neil Armstrong wrote: > On 23/03/2023 11:51, Krzysztof Kozlowski wrote: >> On 23/03/2023 11:25, Neil Armstrong wrote: >>> Fixes the following DT bindings check error: >>> domain-idle-states: cluster-sleep-0: 'idle-state-name', 'local-timer-stop' >>> do not match any of the

Re: [Freedreno] [PATCH 7/8] arm64: dts: qcom: sm8450: remove invalid reg-names from ufs node

2023-03-24 Thread Eric Biggers
Hi Neil, On Thu, Mar 23, 2023 at 02:10:44PM +0100, Neil Armstrong wrote: > Hi, > > On 23/03/2023 11:49, Krzysztof Kozlowski wrote: > > On 23/03/2023 11:25, Neil Armstrong wrote: > > > Fixes the following DT bindings check error: > > > ufshc@1d84000: Unevaluated properties are not allowed