Re: [Freedreno] [PATCH v3 05/12] dt-bindings: display/msm: Add SM6375 MDSS

2023-05-05 Thread Rob Herring
On Fri, 05 May 2023 23:40:31 +0200, Konrad Dybcio wrote: > Document the SM6375 MDSS. > > Signed-off-by: Konrad Dybcio > --- > .../bindings/display/msm/qcom,sm6375-mdss.yaml | 216 > + > 1 file changed, 216 insertions(+) > My bot found errors running 'make

Re: [Freedreno] [PATCH v3 04/12] dt-bindings: display/msm: Add SM6350 MDSS

2023-05-05 Thread Rob Herring
On Fri, 05 May 2023 23:40:30 +0200, Konrad Dybcio wrote: > Document the SM6350 MDSS. > > Signed-off-by: Konrad Dybcio > --- > .../bindings/display/msm/qcom,sm6350-mdss.yaml | 214 > + > 1 file changed, 214 insertions(+) > My bot found errors running 'make

Re: [Freedreno] [PATCH v2 1/4] drm/msm/dsi: Adjust pclk rate for compression

2023-05-05 Thread Jessica Zhang
On 5/5/2023 2:23 PM, Jessica Zhang wrote: Adjust the pclk rate to divide hdisplay by the compression ratio when DSC is enabled. Changes in v2: - Adjusted pclk_rate math to divide only the hdisplay value by compression ratio Signed-off-by: Jessica Zhang ---

[Freedreno] [PATCH v3 11/12] iommu/arm-smmu-qcom: Add SM6375 DPU compatible

2023-05-05 Thread Konrad Dybcio
Add the SM6375 DPU compatible to clients compatible list, as it also needs the workarounds. Acked-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c

[Freedreno] [PATCH v3 12/12] iommu/arm-smmu-qcom: Add SM6350 DPU compatible

2023-05-05 Thread Konrad Dybcio
From: Konrad Dybcio Add the SM6350 DPU compatible to clients compatible list, as it also needs the workarounds. Signed-off-by: Konrad Dybcio Acked-by: Dmitry Baryshkov Signed-off-by: Konrad Dybcio --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + 1 file changed, 1 insertion(+) diff

[Freedreno] [PATCH v3 09/12] drm/msm: mdss: Add SM6375 support

2023-05-05 Thread Konrad Dybcio
Add support for MDSS on SM6375. Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/msm_mdss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index

[Freedreno] [PATCH v3 10/12] iommu/arm-smmu-qcom: Sort the compatible list alphabetically

2023-05-05 Thread Konrad Dybcio
It got broken at some point, fix it up. Signed-off-by: Konrad Dybcio --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c index

[Freedreno] [PATCH v3 07/12] drm/msm: mdss: Add SM6350 support

2023-05-05 Thread Konrad Dybcio
Add support for MDSS on SM6350. Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/msm_mdss.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index

[Freedreno] [PATCH v3 08/12] drm/msm/dpu: Add SM6375 support

2023-05-05 Thread Konrad Dybcio
Add basic SM6375 support to the DPU1 driver to enable display output. Signed-off-by: Konrad Dybcio --- .../gpu/drm/msm/disp/dpu1/catalog/dpu_6_9_sm6375.h | 152 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h |

[Freedreno] [PATCH v3 06/12] drm/msm/dpu: Add SM6350 support

2023-05-05 Thread Konrad Dybcio
Add SM6350 support to the DPU1 driver to enable display output. It's worth noting that one entry dpu_qos_lut_entry was trimmed off: {.fl = 0, .lut = 0x0011223344556677 }, due to the fact that newer SoCs dropped the .fl (fill level)-based logic and don't provide real values, resulting in all

[Freedreno] [PATCH v3 04/12] dt-bindings: display/msm: Add SM6350 MDSS

2023-05-05 Thread Konrad Dybcio
Document the SM6350 MDSS. Signed-off-by: Konrad Dybcio --- .../bindings/display/msm/qcom,sm6350-mdss.yaml | 214 + 1 file changed, 214 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6350-mdss.yaml

[Freedreno] [PATCH v3 05/12] dt-bindings: display/msm: Add SM6375 MDSS

2023-05-05 Thread Konrad Dybcio
Document the SM6375 MDSS. Signed-off-by: Konrad Dybcio --- .../bindings/display/msm/qcom,sm6375-mdss.yaml | 216 + 1 file changed, 216 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6375-mdss.yaml

[Freedreno] [PATCH v3 03/12] dt-bindings: display/msm: sc7180-dpu: Describe SM6350 and SM6375

2023-05-05 Thread Konrad Dybcio
SC7180, SM6350 and SM6375 use a rather similar hw setup for DPU, with the main exception being that the last one requires an additional throttle clock. It is not well understood yet, but failing to toggle it on makes the display hardware stall and not output any frames. Document SM6350 and

[Freedreno] [PATCH v3 00/12] SM63(50|75) DPU support

2023-05-05 Thread Konrad Dybcio
v2 -> v3: - Don't duplicate qcm2290_lm_sblk - Use DEFAULT_DPU_LINE_WIDTH defines - Fix up sspp clk assignments for sm6350 - Add 6350-6375-common QoS data straight to the common file instead of moving it around after adding it - Fix up iommu compatible order before adding new entries - Reuse

[Freedreno] [PATCH v3 02/12] dt-bindings: display/msm: dsi-controller-main: Add SM6375

2023-05-05 Thread Konrad Dybcio
Add the DSI host found on SM6375. Acked-by: Rob Herring Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml

[Freedreno] [PATCH v3 01/12] dt-bindings: display/msm: dsi-controller-main: Add SM6350

2023-05-05 Thread Konrad Dybcio
Add the DSI host found on SM6350. Acked-by: Rob Herring Signed-off-by: Konrad Dybcio --- Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml

[Freedreno] [PATCH v2 4/4] drm/msm/dpu: Set DATA_COMPRESS for command mode

2023-05-05 Thread Jessica Zhang
Add a DPU INTF op to set DATA_COMPRESS register for command mode panels if the DPU_INTF_DATA_COMPRESS feature flag is set. This flag needs to be enabled in order for DSC v1.2 to work. Note: These changes are for command mode only. Video mode changes will be posted along with the DSC v1.2 support

[Freedreno] [PATCH v2 0/4] Add DSC v1.2 Support for DSI

2023-05-05 Thread Jessica Zhang
This is a series of changes for DSI to enable command mode support for DSC v1.2. This includes: 1) Adjusting pclk_rate to account for compression 2) Fixing the word count calculation for DSC 3) Setting the DATA_COMPRESS bit when DSC is enabled With these changes (and the dependency below), DSC

[Freedreno] [PATCH v2 3/4] drm/msm/dpu: Add DPU_INTF_DATA_COMPRESS feature flag

2023-05-05 Thread Jessica Zhang
Add DATA_COMPRESS feature flag to DPU INTF block. In DPU 7.x and later, DSC/DCE enablement registers have been moved from PINGPONG to INTF. As core_rev (and related macros) was removed from the dpu_kms struct, the most straightforward way to indicate the presence of this register would be to

[Freedreno] [PATCH v2 2/4] drm/msm/dsi: Fix compressed word count calculation

2023-05-05 Thread Jessica Zhang
Currently, word count is calculated using slice_count. This is incorrect as downstream uses slice per packet, which is different from slice_count. Slice count represents the number of soft slices per interface, and its value will not always match that of slice per packet. For example, it is

[Freedreno] [PATCH v2 1/4] drm/msm/dsi: Adjust pclk rate for compression

2023-05-05 Thread Jessica Zhang
Adjust the pclk rate to divide hdisplay by the compression ratio when DSC is enabled. Changes in v2: - Adjusted pclk_rate math to divide only the hdisplay value by compression ratio Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dsi/dsi_host.c | 17 + 1 file changed, 13

Re: [Freedreno] [PATCH v2 1/9] drm/msm/dpu: fix SSPP register definitions

2023-05-05 Thread Dmitry Baryshkov
On Fri, 5 May 2023 at 20:24, Jeykumar Sankaran wrote: > > > > On 5/2/2023 8:05 AM, Dmitry Baryshkov wrote: > > Reorder SSPP register definitions to sort them in the ascending order. > > Move register bitfields after the register definitions. > > > > Signed-off-by: Dmitry Baryshkov > > --- > >

Re: [Freedreno] [PATCH 1/4] drm/msm/dsi: Adjust pclk rate for compression

2023-05-05 Thread Jessica Zhang
On 5/4/2023 2:17 PM, Marijn Suijten wrote: On 2023-05-04 22:33:17, Marijn Suijten wrote: Title suggestion: use the wording "reduce pclk rate" :) (Eventually "when DSC is enabled", instead of "for compression") On 2023-05-02 18:19:12, Jessica Zhang wrote: Divide the pclk rate by the

Re: [Freedreno] [PATCH v2 1/9] drm/msm/dpu: fix SSPP register definitions

2023-05-05 Thread Jeykumar Sankaran
On 5/2/2023 8:05 AM, Dmitry Baryshkov wrote: Reorder SSPP register definitions to sort them in the ascending order. Move register bitfields after the register definitions. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 66 +++-- 1 file

Re: [Freedreno] [PATCH v2 9/9] drm/msm/dpu: use common helper for WB and SSPP QoS setup

2023-05-05 Thread Jeykumar Sankaran
On 5/2/2023 8:05 AM, Dmitry Baryshkov wrote: Rework SSPP and WB code to use common helper for programming QoS settings. Signed-off-by: Dmitry Baryshkov --- .../drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 4 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 31 ++-

Re: [Freedreno] [PATCH v2 8/9] drm/msm/dpu: remove struct dpu_hw_pipe_qos_cfg

2023-05-05 Thread Jeykumar Sankaran
On 5/2/2023 8:05 AM, Dmitry Baryshkov wrote: Now as the struct dpu_hw_pipe_qos_cfg consists of only one bool field, drop the structure and use corresponding bool directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 10 +++---

Re: [Freedreno] [PATCH v2 7/9] drm/msm/dpu: drop DPU_PLANE_QOS_PANIC_CTRL

2023-05-05 Thread Jeykumar Sankaran
On 5/2/2023 8:05 AM, Dmitry Baryshkov wrote: This flag is always passed to _dpu_plane_set_qos_ctrl(), so drop it and remove corresponding conditions from the mentioned function. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 27 +++ 1

Re: [Freedreno] [PATCH v2 6/9] drm/msm/dpu: simplify qos_ctrl handling

2023-05-05 Thread Jeykumar Sankaran
On 5/2/2023 8:05 AM, Dmitry Baryshkov wrote: After removal of DPU_PLANE_QOS_VBLANK_CTRL, several fields of struct dpu_hw_pipe_qos_cfg are fixed to false/0. Drop them from the structure (and drop the corresponding code from the functions). The DPU_PLANE_QOS_VBLANK_AMORTIZE flag is also

Re: [Freedreno] [PATCH v2 5/9] drm/msm/dpu: drop DPU_PLANE_QOS_VBLANK_CTRL

2023-05-05 Thread Jeykumar Sankaran
On 5/2/2023 8:05 AM, Dmitry Baryshkov wrote: Drop support for DPU_PLANE_QOS_VBLANK_CTRL flag. It is not used both in upstream driver and in vendor SDE driver. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 4

Re: [Freedreno] [PATCH v2 4/9] drm/msm/dpu: rearrange QoS setting code

2023-05-05 Thread Jeykumar Sankaran
On 5/2/2023 8:05 AM, Dmitry Baryshkov wrote: Slightly rearrainge code in dpu_plane_sspp_update_pipe() to group QoS/LUT related functions. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff

Re: [Freedreno] [PATCH v2 3/9] drm/msm/dpu: fix the condition for (not) applying QoS to CURSOR SSPP

2023-05-05 Thread Jeykumar Sankaran
On 5/2/2023 8:05 AM, Dmitry Baryshkov wrote: The function dpu_plane_sspp_update_pipe() contains code to skip enabling the QoS and OT limitis for CURSOR pipes. However all DPU since sdm845 repurpose DMA SSPP for the cursor planes because they lack the real CURSOR SSPP. Fix the condition to

Re: [Freedreno] [PATCH v2 2/9] drm/msm/dpu: simplify CDP programming

2023-05-05 Thread Jeykumar Sankaran
On 5/2/2023 8:05 AM, Dmitry Baryshkov wrote: Get rid of intermediatory configuration structure and defines. Pass the format and the enablement bit directly to the new helper. The WB_CDP_CNTL register ignores BIT(2), so we can write it for both SSPP and WB CDP settings. Signed-off-by: Dmitry

Re: [Freedreno] [PATCH v2 03/13] dt-bindings: display/msm: Add SM6350 DPU

2023-05-05 Thread Konrad Dybcio
On 25.04.2023 19:03, Rob Herring wrote: > On Fri, Apr 21, 2023 at 12:31:12AM +0200, Konrad Dybcio wrote: >> Document the SM6350 DPU. >> >> Signed-off-by: Konrad Dybcio >> --- >> .../bindings/display/msm/qcom,sm6350-dpu.yaml | 94 >> ++ >> 1 file changed, 94

Re: [Freedreno] [PATCH v2 07/13] drm/msm/dpu: Add SM6350 support

2023-05-05 Thread Dmitry Baryshkov
On 27/04/2023 18:37, Marijn Suijten wrote: On 2023-04-21 00:31:16, Konrad Dybcio wrote: Add SM6350 support to the DPU1 driver to enable display output. Signed-off-by: Konrad Dybcio Signed-off-by: Konrad Dybcio After addressing the comments from Dmitry (CURSOR0->DMA1 and CURSOR1->DMA2),

Re: [Freedreno] [PATCH v6 06/15] drm/msm/a6xx: Introduce GMU wrapper support

2023-05-05 Thread Konrad Dybcio
On 5.05.2023 10:46, Akhil P Oommen wrote: > On Thu, May 04, 2023 at 08:34:07AM +0200, Konrad Dybcio wrote: >> >> >> On 3.05.2023 22:32, Akhil P Oommen wrote: >>> On Tue, May 02, 2023 at 11:40:26AM +0200, Konrad Dybcio wrote: On 2.05.2023 09:49, Akhil P Oommen wrote: > On Sat,

Re: [Freedreno] [PATCH v6 06/15] drm/msm/a6xx: Introduce GMU wrapper support

2023-05-05 Thread Akhil P Oommen
On Thu, May 04, 2023 at 08:34:07AM +0200, Konrad Dybcio wrote: > > > On 3.05.2023 22:32, Akhil P Oommen wrote: > > On Tue, May 02, 2023 at 11:40:26AM +0200, Konrad Dybcio wrote: > >> > >> > >> On 2.05.2023 09:49, Akhil P Oommen wrote: > >>> On Sat, Apr 01, 2023 at 01:54:43PM +0200, Konrad Dybcio