Re: [PATCH] arm64: dts: qcom: sm6115: fix USB PHY configuration

2024-02-20 Thread Krzysztof Kozlowski
On 20/02/2024 22:23, Konrad Dybcio wrote: > On 20.02.2024 18:31, Dmitry Baryshkov wrote: >> The patch adding Type-C support for sm6115 was misapplied. All the >> orientation switch configuration ended up at the UFS PHY node instead of >> the USB PHY node. Move the data bits to the correct place.

Re: [PATCH v2] drm/msm/dpu: make "vblank timeout" more useful

2024-02-20 Thread Dmitry Baryshkov
On Wed, 21 Feb 2024 at 01:04, Abhinav Kumar wrote: > > > > On 2/20/2024 2:42 PM, Dmitry Baryshkov wrote: > > On Wed, 21 Feb 2024 at 00:40, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 2/19/2024 3:52 AM, Dmitry Baryshkov wrote: > >>> On Wed, 14 Feb 2024 at 22:36, Abhinav Kumar > >>> wrote:

Re: [PATCH v2] drm/msm/dpu: make "vblank timeout" more useful

2024-02-20 Thread Abhinav Kumar
On 2/20/2024 2:42 PM, Dmitry Baryshkov wrote: On Wed, 21 Feb 2024 at 00:40, Abhinav Kumar wrote: On 2/19/2024 3:52 AM, Dmitry Baryshkov wrote: On Wed, 14 Feb 2024 at 22:36, Abhinav Kumar wrote: On 2/14/2024 11:20 AM, Dmitry Baryshkov wrote: On Wed, 14 Feb 2024 at 20:02, Abhinav

Re: [PATCH RFC 3/3] drm/msm/dp: Add support for the X1E80100

2024-02-20 Thread Dmitry Baryshkov
On Wed, 21 Feb 2024 at 00:50, Abel Vesa wrote: > > Add the X1E80100 DP descs and compatible. This platform will be using > a single compatible for both eDP and DP mode. The actual mode will > be set in devicetree via is-edp flag. > > Signed-off-by: Abel Vesa > --- >

Re: [PATCH RFC 2/3] drm/msm/dp: Add support for setting the eDP mode from devicetree

2024-02-20 Thread Dmitry Baryshkov
On Wed, 21 Feb 2024 at 00:50, Abel Vesa wrote: > > Instead of relying on different compatibles for eDP and DP, use > the is-edp property from DT to figure out the connector type and > then pass on that information to the PHY. > > Signed-off-by: Abel Vesa > --- > drivers/gpu/drm/msm/dp/dp_ctrl.c

[PATCH RFC 1/3] dt-bindings: display: msm: dp-controller: document X1E80100 compatible

2024-02-20 Thread Abel Vesa
Add the X1E80100 to the list of compatibles and docoment the is-edp flag. This new flag will be used from now on to dictate the mode from devicetree, instead of having separate compatibles for eDP and DP. Signed-off-by: Abel Vesa ---

[PATCH RFC 2/3] drm/msm/dp: Add support for setting the eDP mode from devicetree

2024-02-20 Thread Abel Vesa
Instead of relying on different compatibles for eDP and DP, use the is-edp property from DT to figure out the connector type and then pass on that information to the PHY. Signed-off-by: Abel Vesa --- drivers/gpu/drm/msm/dp/dp_ctrl.c| 11 +++ drivers/gpu/drm/msm/dp/dp_ctrl.h| 1

[PATCH RFC 3/3] drm/msm/dp: Add support for the X1E80100

2024-02-20 Thread Abel Vesa
Add the X1E80100 DP descs and compatible. This platform will be using a single compatible for both eDP and DP mode. The actual mode will be set in devicetree via is-edp flag. Signed-off-by: Abel Vesa --- drivers/gpu/drm/msm/dp/dp_display.c | 9 + 1 file changed, 9 insertions(+) diff

[PATCH RFC 0/3] drm/msm/dp: Rework the eDP/DP modes and add support for X1E80100

2024-02-20 Thread Abel Vesa
the PHY know which mode it should configure itself. The PHY counterpart patchset is here: https://lore.kernel.org/all/20240220-x1e80100-phy-edp-compatible-refactor-v5-0-e8658adf5...@linaro.org/ Signed-off-by: Abel Vesa --- Abel Vesa (3): dt-bindings: display: msm: dp-controller: document

Re: [PATCH v2] drm/msm/dpu: make "vblank timeout" more useful

2024-02-20 Thread Dmitry Baryshkov
On Wed, 21 Feb 2024 at 00:40, Abhinav Kumar wrote: > > > > On 2/19/2024 3:52 AM, Dmitry Baryshkov wrote: > > On Wed, 14 Feb 2024 at 22:36, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 2/14/2024 11:20 AM, Dmitry Baryshkov wrote: > >>> On Wed, 14 Feb 2024 at 20:02, Abhinav Kumar > >>> wrote:

Re: [PATCH v2] drm/msm/dpu: make "vblank timeout" more useful

2024-02-20 Thread Abhinav Kumar
On 2/19/2024 3:52 AM, Dmitry Baryshkov wrote: On Wed, 14 Feb 2024 at 22:36, Abhinav Kumar wrote: On 2/14/2024 11:20 AM, Dmitry Baryshkov wrote: On Wed, 14 Feb 2024 at 20:02, Abhinav Kumar wrote: On 2/8/2024 6:50 AM, Dmitry Baryshkov wrote: We have several reports of vblank timeout

Re: [PATCH] arm64: dts: qcom: sm6115: fix USB PHY configuration

2024-02-20 Thread Konrad Dybcio
On 20.02.2024 18:31, Dmitry Baryshkov wrote: > The patch adding Type-C support for sm6115 was misapplied. All the > orientation switch configuration ended up at the UFS PHY node instead of > the USB PHY node. Move the data bits to the correct place. > > Fixes: a06a2f12f9e2 ("arm64: dts: qcom:

Re: drm/msm: Second DisplayPort regression in 6.8-rc1

2024-02-20 Thread Abhinav Kumar
Hi Johan On 2/19/2024 2:41 AM, Johan Hovold wrote: On Sat, Feb 17, 2024 at 04:14:58PM +0100, Johan Hovold wrote: On Wed, Feb 14, 2024 at 02:52:06PM +0100, Johan Hovold wrote: On Tue, Feb 13, 2024 at 10:00:13AM -0800, Abhinav Kumar wrote: Since Dmitry had trouble reproducing this issue I

Re: [PATCH v3 2/2] drm/dp: drop the size parameter from drm_dp_vsc_sdp_pack()

2024-02-20 Thread Dmitry Baryshkov
On Tue, 20 Feb 2024 at 21:54, Abhinav Kumar wrote: > > Currently the size parameter of drm_dp_vsc_sdp_pack() is always > the size of struct dp_sdp. Hence lets drop this parameter and > use sizeof() directly. > > Suggested-by: Dmitry Baryshkov > Signed-off-by: Abhinav Kumar > --- >

[PATCH v3 1/2] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-20 Thread Abhinav Kumar
intel_dp_vsc_sdp_pack() can be re-used by other DRM drivers as well. Lets move this to drm_dp_helper to achieve this. changes in v2: - rebased on top of drm-tip Acked-by: Dmitry Baryshkov Signed-off-by: Abhinav Kumar Acked-by: Jani Nikula --- drivers/gpu/drm/display/drm_dp_helper.c |

[PATCH v3 2/2] drm/dp: drop the size parameter from drm_dp_vsc_sdp_pack()

2024-02-20 Thread Abhinav Kumar
Currently the size parameter of drm_dp_vsc_sdp_pack() is always the size of struct dp_sdp. Hence lets drop this parameter and use sizeof() directly. Suggested-by: Dmitry Baryshkov Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/display/drm_dp_helper.c | 8 ++--

Re: [PATCH v2] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-20 Thread Abhinav Kumar
On 2/20/2024 11:41 AM, Ville Syrjälä wrote: On Tue, Feb 20, 2024 at 11:27:18AM -0800, Abhinav Kumar wrote: On 2/20/2024 11:20 AM, Dmitry Baryshkov wrote: On Tue, 20 Feb 2024 at 21:05, Dmitry Baryshkov wrote: On Tue, 20 Feb 2024 at 20:53, Abhinav Kumar wrote: On 2/20/2024 10:49 AM,

Re: [PATCH v2] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-20 Thread Ville Syrjälä
On Tue, Feb 20, 2024 at 11:27:18AM -0800, Abhinav Kumar wrote: > > > On 2/20/2024 11:20 AM, Dmitry Baryshkov wrote: > > On Tue, 20 Feb 2024 at 21:05, Dmitry Baryshkov > > wrote: > >> > >> On Tue, 20 Feb 2024 at 20:53, Abhinav Kumar > >> wrote: > >>> > >>> > >>> > >>> On 2/20/2024 10:49 AM,

Re: [PATCH v2] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-20 Thread Abhinav Kumar
On 2/20/2024 11:20 AM, Dmitry Baryshkov wrote: On Tue, 20 Feb 2024 at 21:05, Dmitry Baryshkov wrote: On Tue, 20 Feb 2024 at 20:53, Abhinav Kumar wrote: On 2/20/2024 10:49 AM, Dmitry Baryshkov wrote: On Thu, 15 Feb 2024 at 21:08, Abhinav Kumar wrote: intel_dp_vsc_sdp_pack() can be

Re: [PATCH v2] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-20 Thread Dmitry Baryshkov
On Tue, 20 Feb 2024 at 21:05, Dmitry Baryshkov wrote: > > On Tue, 20 Feb 2024 at 20:53, Abhinav Kumar wrote: > > > > > > > > On 2/20/2024 10:49 AM, Dmitry Baryshkov wrote: > > > On Thu, 15 Feb 2024 at 21:08, Abhinav Kumar > > > wrote: > > >> > > >> intel_dp_vsc_sdp_pack() can be re-used by

Re: [PATCH v2] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-20 Thread Dmitry Baryshkov
On Tue, 20 Feb 2024 at 21:09, Abhinav Kumar wrote: > > > > On 2/20/2024 11:05 AM, Dmitry Baryshkov wrote: > > On Tue, 20 Feb 2024 at 20:53, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 2/20/2024 10:49 AM, Dmitry Baryshkov wrote: > >>> On Thu, 15 Feb 2024 at 21:08, Abhinav Kumar > >>>

Re: [PATCH v4 13/19] drm/msm/dp: add VSC SDP support for YUV420 over DP

2024-02-20 Thread Paloma Arellano
On 2/20/2024 10:09 AM, Dmitry Baryshkov wrote: On Tue, 20 Feb 2024 at 19:55, Paloma Arellano wrote: On 2/17/2024 12:56 AM, Dmitry Baryshkov wrote: On Sat, 17 Feb 2024 at 01:03, Paloma Arellano wrote: + } + + panel = container_of(dp_panel, struct dp_panel_private, dp_panel); +

Re: [PATCH v2] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-20 Thread Abhinav Kumar
On 2/20/2024 11:05 AM, Dmitry Baryshkov wrote: On Tue, 20 Feb 2024 at 20:53, Abhinav Kumar wrote: On 2/20/2024 10:49 AM, Dmitry Baryshkov wrote: On Thu, 15 Feb 2024 at 21:08, Abhinav Kumar wrote: intel_dp_vsc_sdp_pack() can be re-used by other DRM drivers as well. Lets move this to

Re: [PATCH v2] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-20 Thread Dmitry Baryshkov
On Tue, 20 Feb 2024 at 20:53, Abhinav Kumar wrote: > > > > On 2/20/2024 10:49 AM, Dmitry Baryshkov wrote: > > On Thu, 15 Feb 2024 at 21:08, Abhinav Kumar > > wrote: > >> > >> intel_dp_vsc_sdp_pack() can be re-used by other DRM drivers as well. > >> Lets move this to drm_dp_helper to achieve

Re: [PATCH v2] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-20 Thread Abhinav Kumar
On 2/20/2024 10:49 AM, Dmitry Baryshkov wrote: On Thu, 15 Feb 2024 at 21:08, Abhinav Kumar wrote: intel_dp_vsc_sdp_pack() can be re-used by other DRM drivers as well. Lets move this to drm_dp_helper to achieve this. changes in v2: - rebased on top of drm-tip Acked-by: Dmitry

Re: [PATCH v2] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-20 Thread Dmitry Baryshkov
On Thu, 15 Feb 2024 at 21:08, Abhinav Kumar wrote: > > intel_dp_vsc_sdp_pack() can be re-used by other DRM drivers as well. > Lets move this to drm_dp_helper to achieve this. > > changes in v2: > - rebased on top of drm-tip > > Acked-by: Dmitry Baryshkov v1 had an explicit comment

Re: [PATCH v4 13/19] drm/msm/dp: add VSC SDP support for YUV420 over DP

2024-02-20 Thread Dmitry Baryshkov
On Tue, 20 Feb 2024 at 19:55, Paloma Arellano wrote: > > > On 2/17/2024 12:56 AM, Dmitry Baryshkov wrote: > > On Sat, 17 Feb 2024 at 01:03, Paloma Arellano > > wrote: > >> + } > >> + > >> + panel = container_of(dp_panel, struct dp_panel_private, dp_panel); > >> + catalog =

Re: [PATCH] arm64: dts: qcom: sm6115: fix USB PHY configuration

2024-02-20 Thread Bjorn Andersson
On Tue, 20 Feb 2024 19:31:04 +0200, Dmitry Baryshkov wrote: > The patch adding Type-C support for sm6115 was misapplied. All the > orientation switch configuration ended up at the UFS PHY node instead of > the USB PHY node. Move the data bits to the correct place. > > Applied, thanks! [1/1]

Re: [PATCH v4 13/19] drm/msm/dp: add VSC SDP support for YUV420 over DP

2024-02-20 Thread Paloma Arellano
On 2/17/2024 12:56 AM, Dmitry Baryshkov wrote: On Sat, 17 Feb 2024 at 01:03, Paloma Arellano wrote: Add support to pack and send the VSC SDP packet for DP. This therefore allows the transmision of format information to the sinks which is needed for YUV420 support over DP. Changes in v4:

[PATCH] arm64: dts: qcom: sm6115: fix USB PHY configuration

2024-02-20 Thread Dmitry Baryshkov
The patch adding Type-C support for sm6115 was misapplied. All the orientation switch configuration ended up at the UFS PHY node instead of the USB PHY node. Move the data bits to the correct place. Fixes: a06a2f12f9e2 ("arm64: dts: qcom: qrb4210-rb2: enable USB-C port handling") Signed-off-by:

[PATCH] drm/msm/a6xx: specify UBWC config for sc7180

2024-02-20 Thread Dmitry Baryshkov
(gpu)) gpu->ubwc_config.highest_bank_bit = 13; --- base-commit: 41c177cf354126a22443b5c80cec9fdd313e67e1 change-id: 20240220-fd-sc7180-explicit-ubwc-40953fa55947 Best regards, -- Dmitry Baryshkov

Re: [PATCH] drm: ci: uprev IGT

2024-02-20 Thread Dmitry Baryshkov
On Tue, 20 Feb 2024 at 16:31, Helen Koike wrote: > > > > On 20/02/2024 09:17, Dmitry Baryshkov wrote: > > Bump IGT revision to pick up Rob Clark's fixes for the msm driver: > > > > - msm_submit@invalid-duplicate-bo-submit,Fail > > > > Signed-off-by: Dmitry Baryshkov > > Do you have a gitlab

Re: [PATCH] drm: ci: uprev IGT

2024-02-20 Thread Helen Koike
On 20/02/2024 09:17, Dmitry Baryshkov wrote: Bump IGT revision to pick up Rob Clark's fixes for the msm driver: - msm_submit@invalid-duplicate-bo-submit,Fail Signed-off-by: Dmitry Baryshkov Do you have a gitlab pipeline link I can check? Thanks Helen ---

[PATCH v4 3/4] drm/msm: mdss: Add X1E80100 support

2024-02-20 Thread Abel Vesa
Add support for MDSS on X1E80100. Reviewed-by: Dmitry Baryshkov Signed-off-by: Abel Vesa --- drivers/gpu/drm/msm/msm_mdss.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 65657230bbff..fab6ad4e5107 100644

[PATCH v4 4/4] drm/msm/dpu: Add X1E80100 support

2024-02-20 Thread Abel Vesa
Add definitions for the display hardware used on the Qualcomm X1E80100 platform. Co-developed-by: Abhinav Kumar Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov Signed-off-by: Abel Vesa --- .../drm/msm/disp/dpu1/catalog/dpu_9_2_x1e80100.h | 449 +

[PATCH v4 0/4] drm/msm: Add display support for X1E80100

2024-02-20 Thread Abel Vesa
This patchset adds support for display for X1E80100. The support for embedded DisplayPort on this platform will not be enabled using the connetor type from driver match data, but through some 'is-edp' property via DT. This subsequent work will be part of a separate patchset. Signed-off-by: Abel

[PATCH v4 2/4] dt-bindings: display/msm: Document MDSS on X1E80100

2024-02-20 Thread Abel Vesa
Document the MDSS hardware found on the Qualcomm X1E80100 platform. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Abel Vesa --- .../bindings/display/msm/qcom,x1e80100-mdss.yaml | 251 + 1 file changed, 251 insertions(+) diff --git

[PATCH v4 1/4] dt-bindings: display/msm: Document the DPU for X1E80100

2024-02-20 Thread Abel Vesa
Document the DPU for Qualcomm X1E80100 platform in the SM8650 schema, as they are similar. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Abel Vesa --- Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 1/6] drm/bridge: aux-hpd: fix OF node leaks

2024-02-20 Thread Dmitry Baryshkov
On Tue, 20 Feb 2024 at 14:56, Julia Lawall wrote: > > > > On Tue, 20 Feb 2024, Dmitry Baryshkov wrote: > > > On Tue, 20 Feb 2024 at 13:52, Julia Lawall wrote: > > > > > > > > > > > > On Tue, 20 Feb 2024, Johan Hovold wrote: > > > > > > > On Mon, Feb 19, 2024 at 06:48:30PM +0100, Markus Elfring

Re: [PATCH] drm/msm/a6xx: skip programming of UBWC registers for a618

2024-02-20 Thread Connor Abbott
On Sun, Feb 18, 2024 at 1:44 PM Dmitry Baryshkov wrote: > > Historically the Adreno driver has not been updating memory > configuration registers on a618 (SC7180 platform) implying that the > default configuration is fine. After the rework performed in the commit > 8814455a0e54 ("drm/msm:

Re: [PATCH 1/6] drm/bridge: aux-hpd: fix OF node leaks

2024-02-20 Thread Julia Lawall
On Tue, 20 Feb 2024, Dmitry Baryshkov wrote: > On Tue, 20 Feb 2024 at 13:52, Julia Lawall wrote: > > > > > > > > On Tue, 20 Feb 2024, Johan Hovold wrote: > > > > > On Mon, Feb 19, 2024 at 06:48:30PM +0100, Markus Elfring wrote: > > > > > The two device node references taken during allocation

[PATCH] drm: ci: uprev IGT

2024-02-20 Thread Dmitry Baryshkov
Bump IGT revision to pick up Rob Clark's fixes for the msm driver: - msm_submit@invalid-duplicate-bo-submit,Fail Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/ci/gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ci/gitlab-ci.yml

Re: [PATCH 1/6] drm/bridge: aux-hpd: fix OF node leaks

2024-02-20 Thread Julia Lawall
On Tue, 20 Feb 2024, Johan Hovold wrote: > On Mon, Feb 19, 2024 at 06:48:30PM +0100, Markus Elfring wrote: > > > The two device node references taken during allocation need to be > > > dropped when the auxiliary device is freed. > > … > > > +++ b/drivers/gpu/drm/bridge/aux-hpd-bridge.c > > … >

Re: [PATCH 1/6] drm/bridge: aux-hpd: fix OF node leaks

2024-02-20 Thread Dmitry Baryshkov
On Tue, 20 Feb 2024 at 13:52, Julia Lawall wrote: > > > > On Tue, 20 Feb 2024, Johan Hovold wrote: > > > On Mon, Feb 19, 2024 at 06:48:30PM +0100, Markus Elfring wrote: > > > > The two device node references taken during allocation need to be > > > > dropped when the auxiliary device is freed. >

Re: [PATCH 3/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

2024-02-20 Thread Johan Hovold
On Tue, Feb 20, 2024 at 11:55:57AM +0100, Markus Elfring wrote: > … > > Specifically, the dp-hpd bridge is currently registered before all > > resources have been acquired which means that it can also be > > deregistered on probe deferrals. > > > > In the meantime there is a race window where the

Re: [PATCH v3 1/4] dt-bindings: display/msm: Document the DPU for X1E80100

2024-02-20 Thread Krzysztof Kozlowski
On 16/02/2024 18:01, Abel Vesa wrote: > Document the DPU for Qualcomm X1E80100 platform in the SM8650 schema, as > they are similar. > > Signed-off-by: Abel Vesa Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 8/8] arm64: dts: qcom: qrb2210-rb1: Enable the GPU

2024-02-20 Thread neil . armstrong
On 19/02/2024 22:37, Konrad Dybcio wrote: On 19.02.2024 15:49, Dmitry Baryshkov wrote: On Mon, 19 Feb 2024 at 15:36, Konrad Dybcio wrote: Enable the A702 GPU (also marketed as "3D accelerator by qcom [1], lol). Is it not? Sure, every electronic device is also a heater, I suppose.. I

Re: [PATCH] drm/msm: Wire up tlb ops

2024-02-20 Thread Johan Hovold
On Thu, Feb 15, 2024 at 07:28:53AM -0800, Rob Clark wrote: > On Wed, Feb 14, 2024 at 11:34 PM Johan Hovold wrote: > > > > On Tue, Feb 13, 2024 at 09:23:40AM -0800, Rob Clark wrote: > > > From: Rob Clark > > > > > > The brute force iommu_flush_iotlb_all() was good enough for unmap, but > > > in