Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-08 Thread Bjorn Andersson
On Tue, Apr 09, 2024 at 01:07:57AM +0300, Dmitry Baryshkov wrote: > On Tue, 9 Apr 2024 at 00:23, Abhinav Kumar wrote: > > On 4/8/2024 2:12 PM, Dmitry Baryshkov wrote: > > > On Mon, 8 Apr 2024 at 22:43, Abhinav Kumar > > > wrote: > > >> On 4/7/2024 11:48 AM, Bjorn Andersson wrote: > > >>> On

Re: [PATCH v3 3/6] drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC (fix video mode DSC)

2024-04-08 Thread Jun Nie
Marijn Suijten 于2024年4月9日周二 00:45写道: > > Can we drop (fix video mode DSC) from this patch title? It looks like more > patches are required to get this done, such a mention is more something for > the > cover letter. > > We could also clarify further to "set Word Count for video-mode DSC". >

Re: [PATCH 3/3] drm/msm/dsi: simplify connector creation

2024-04-08 Thread Abhinav Kumar
On 3/9/2024 7:09 AM, Dmitry Baryshkov wrote: Instead of having two functions, msm_dsi_manager_bridge_init() and msm_dsi_manager_ext_bridge_init(), merge them into msm_dsi_manager_connector_init(), moving drm_bridge_attach() to be called from the bridge's attach callback (as most other bridges

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-08 Thread Dmitry Baryshkov
On Tue, 9 Apr 2024 at 00:17, Abhinav Kumar wrote: > > > > On 4/8/2024 2:13 PM, Dmitry Baryshkov wrote: > > On Tue, 9 Apr 2024 at 00:08, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 4/8/2024 1:41 PM, Bjorn Andersson wrote: > >>> On Mon, Apr 08, 2024 at 12:43:34PM -0700, Abhinav Kumar wrote: >

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-08 Thread Dmitry Baryshkov
On Tue, 9 Apr 2024 at 00:23, Abhinav Kumar wrote: > > > > On 4/8/2024 2:12 PM, Dmitry Baryshkov wrote: > > On Mon, 8 Apr 2024 at 22:43, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 4/7/2024 11:48 AM, Bjorn Andersson wrote: > >>> On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote:

Re: [PATCH 2/3] drm/msm/dsi: move next bridge acquisition to dsi_bind

2024-04-08 Thread Abhinav Kumar
On 4/5/2024 11:15 AM, Dmitry Baryshkov wrote: On Fri, 5 Apr 2024 at 20:35, Abhinav Kumar wrote: On 3/9/2024 7:09 AM, Dmitry Baryshkov wrote: Currently the MSM DSI driver looks for the next bridge during msm_dsi_modeset_init(). If the bridge is not registered at that point, this might

Re: [PATCH v2 6/6] drm/msm/dp: Use function arguments for audio operations

2024-04-08 Thread Abhinav Kumar
On 3/28/2024 7:40 AM, Bjorn Andersson wrote: From: Bjorn Andersson The dp_audio read and write operations uses members in struct dp_catalog for passing arguments and return values. This adds unnecessary complexity to the implementation, as it turns out after detangling the logic that no

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-08 Thread Abhinav Kumar
On 4/8/2024 2:12 PM, Dmitry Baryshkov wrote: On Mon, 8 Apr 2024 at 22:43, Abhinav Kumar wrote: On 4/7/2024 11:48 AM, Bjorn Andersson wrote: On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote: From: Kuogee Hsieh [..] diff --git a/drivers/gpu/drm/msm/dp/dp_display.c

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-08 Thread Abhinav Kumar
On 4/8/2024 2:13 PM, Dmitry Baryshkov wrote: On Tue, 9 Apr 2024 at 00:08, Abhinav Kumar wrote: On 4/8/2024 1:41 PM, Bjorn Andersson wrote: On Mon, Apr 08, 2024 at 12:43:34PM -0700, Abhinav Kumar wrote: On 4/7/2024 11:48 AM, Bjorn Andersson wrote: On Fri, Apr 05, 2024 at 08:15:47PM

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-08 Thread Dmitry Baryshkov
On Tue, 9 Apr 2024 at 00:08, Abhinav Kumar wrote: > > > > On 4/8/2024 1:41 PM, Bjorn Andersson wrote: > > On Mon, Apr 08, 2024 at 12:43:34PM -0700, Abhinav Kumar wrote: > >> > >> > >> On 4/7/2024 11:48 AM, Bjorn Andersson wrote: > >>> On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote:

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-08 Thread Dmitry Baryshkov
On Mon, 8 Apr 2024 at 22:43, Abhinav Kumar wrote: > > > > On 4/7/2024 11:48 AM, Bjorn Andersson wrote: > > On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote: > >> From: Kuogee Hsieh > > [..] > >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > >>

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-08 Thread Abhinav Kumar
On 4/8/2024 1:41 PM, Bjorn Andersson wrote: On Mon, Apr 08, 2024 at 12:43:34PM -0700, Abhinav Kumar wrote: On 4/7/2024 11:48 AM, Bjorn Andersson wrote: On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote: From: Kuogee Hsieh [..] diff --git

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-08 Thread Bjorn Andersson
On Mon, Apr 08, 2024 at 12:43:34PM -0700, Abhinav Kumar wrote: > > > On 4/7/2024 11:48 AM, Bjorn Andersson wrote: > > On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote: > > > From: Kuogee Hsieh > > [..] > > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > > >

Re: [PATCH v3] drm/msm/dp: call dp_hpd_plug_handle()/unplug_handle() directly for external HPD

2024-04-08 Thread Abhinav Kumar
On 4/7/2024 11:48 AM, Bjorn Andersson wrote: On Fri, Apr 05, 2024 at 08:15:47PM -0700, Abhinav Kumar wrote: From: Kuogee Hsieh [..] diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index d80f89581760..bfb6dfff27e8 100644 ---

[linux-next:master] BUILD REGRESSION 11cb68ad52ac78c81e33b806b531f097e68edfa2

2024-04-08 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 11cb68ad52ac78c81e33b806b531f097e68edfa2 Add linux-next specific files for 20240408 Error/Warning: (recently discovered and may have been fixed) drivers/gpu/drm/drm_mm.c:152:1: error: unused

Re: [PATCH] drm: ci: fix the xfails for apq8016

2024-04-08 Thread Abhinav Kumar
Hi Helen Gentle reminder on this. If you are okay, we can land it via msm-next tree... Thanks Abhinav On 4/1/2024 1:48 PM, Abhinav Kumar wrote: After IGT migrating to dynamic sub-tests, the pipe prefixes in the expected fails list are incorrect. Lets drop those to accurately match the

Re: [PATCH] drm/msm/dpu: Add callback function pointer check before its call

2024-04-08 Thread Abhinav Kumar
On 4/8/2024 1:55 AM, Aleksandr Mishin wrote: In dpu_core_irq_callback_handler() callback function pointer is compared to NULL, but then callback function is unconditionally called by this pointer. Fix this bug by adding conditional return. Found by Linux Verification Center

Re: [PATCH v3 3/6] drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC (fix video mode DSC)

2024-04-08 Thread Marijn Suijten
Can we drop (fix video mode DSC) from this patch title? It looks like more patches are required to get this done, such a mention is more something for the cover letter. We could also clarify further to "set Word Count for video-mode DSC". - Marijn On 2024-04-03 17:10:59, Jun Nie wrote: > From:

Re: [PATCH v3 5/6] drm/display: Add slice_per_pkt for dsc

2024-04-08 Thread Marijn Suijten
On 2024-04-08 17:58:29, Jun Nie wrote: > Dmitry Baryshkov 于2024年4月3日周三 17:41写道: > > > > On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > > > > > Add variable for slice number of a DSC compression bit stream packet. > > > Its value shall be specified in panel driver, or default value can be set >

Re: [PATCH v1 1/1] drm/msm/hdmi: Replace of_gpio.h by proper one

2024-04-08 Thread Dmitry Baryshkov
On Mon, 4 Mar 2024 at 19:51, Andy Shevchenko wrote: > > of_gpio.h is deprecated and subject to remove. > The driver doesn't use it directly, replace it > with what is really being used. > > Signed-off-by: Andy Shevchenko > --- > drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +- > 1 file changed, 1

[PATCH] drm/msm/dpu: Add callback function pointer check before its call

2024-04-08 Thread Aleksandr Mishin
In dpu_core_irq_callback_handler() callback function pointer is compared to NULL, but then callback function is unconditionally called by this pointer. Fix this bug by adding conditional return. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: c929ac60b3ed ("drm/msm/dpu:

Re: [PATCH v3 6/6] drm/msm/dsi: support DSC configurations with slice_per_pkt > 1

2024-04-08 Thread Jun Nie
Dmitry Baryshkov 于2024年4月3日周三 18:51写道: > > On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > > > From: Jonathan Marek > > > > Support slice_per_pkt in msm driver. > > > > Note that the removed "pkt_per_line = slice_per_intf * slice_per_pkt" > > comment is incorrect. > > > > Also trim the code to

Re: [PATCH v3 5/6] drm/display: Add slice_per_pkt for dsc

2024-04-08 Thread Jun Nie
Dmitry Baryshkov 于2024年4月3日周三 17:41写道: > > On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > > > Add variable for slice number of a DSC compression bit stream packet. > > Its value shall be specified in panel driver, or default value can be set > > in display controller driver if panel driver does

Re: [PATCH] drm/msm: convert all pixel format logging to use %p4cc

2024-04-08 Thread Jani Nikula
On Mon, 08 Apr 2024, Dmitry Baryshkov wrote: > On Mon, 8 Apr 2024 at 11:09, Jani Nikula wrote: >> Thanks! Do you take this via the msm tree? > > Yes, I will Forgot to mention, there's a Tested-by at [1]. Tested-by: Aishwarya TCV [1]

Re: [PATCH] phy: qcom: qmp-combo: Fix VCO div offset on v3

2024-04-08 Thread Johan Hovold
On Thu, Apr 04, 2024 at 04:43:44PM -0700, Stephen Boyd wrote: > Commit ec17373aebd0 ("phy: qcom: qmp-combo: extract common function to > setup clocks") changed the offset that is used to write to > DP_PHY_VCO_DIV from QSERDES_V3_DP_PHY_VCO_DIV to > QSERDES_V4_DP_PHY_VCO_DIV. Unfortunately, this

Re: [PATCH v3 2/6] drm/msm/dsi: set video mode widebus enable bit when widebus is enabled

2024-04-08 Thread Jun Nie
Dmitry Baryshkov 于2024年4月3日周三 18:10写道: > > On Wed, 3 Apr 2024 at 12:11, Jun Nie wrote: > > > > From: Jonathan Marek > > > > The value returned by msm_dsi_wide_bus_enabled() doesn't match what the > > driver is doing in video mode. Fix that by actually enabling widebus for > > video mode. > > >

Re: [PATCH] drm/msm/dpu: Add callback function pointer check before its call

2024-04-08 Thread Dmitry Baryshkov
On Mon, 8 Apr 2024 at 11:57, Aleksandr Mishin wrote: > > In dpu_core_irq_callback_handler() callback function pointer is compared to > NULL, > but then callback function is unconditionally called by this pointer. > Fix this bug by adding conditional return. > > Found by Linux Verification Center

Re: [PATCH] drm/msm: convert all pixel format logging to use %p4cc

2024-04-08 Thread Dmitry Baryshkov
On Mon, 8 Apr 2024 at 11:09, Jani Nikula wrote: > > On Fri, 05 Apr 2024, Dmitry Baryshkov wrote: > > On Fri, Apr 05, 2024 at 12:29:07PM +0300, Jani Nikula wrote: > >> Logging u32 pixel formats using %4.4s format string with a pointer to > >> the u32 is somewhat questionable, as well as dependent

Re: [PATCH] drm/msm: convert all pixel format logging to use %p4cc

2024-04-08 Thread Jani Nikula
On Fri, 05 Apr 2024, Dmitry Baryshkov wrote: > On Fri, Apr 05, 2024 at 12:29:07PM +0300, Jani Nikula wrote: >> Logging u32 pixel formats using %4.4s format string with a pointer to >> the u32 is somewhat questionable, as well as dependent on byte >> order. There's a kernel extension format