[PATCH 0/2] Adreno MAINTAINERS modifications

2024-04-22 Thread Konrad Dybcio
Separate out Adreno from the rest of the drm/msm driver, add myself as a reviewer for the former. Signed-off-by: Konrad Dybcio --- Konrad Dybcio (2): MAINTAINERS: Add a separate entry for Qualcomm Adreno GPU drivers MAINTAINERS: Add Konrad Dybcio as a reviewer for the Adreno driver

[PATCH 2/2] MAINTAINERS: Add Konrad Dybcio as a reviewer for the Adreno driver

2024-04-22 Thread Konrad Dybcio
Add myself as a reviewer for Adreno driver changes. Signed-off-by: Konrad Dybcio --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 179f989a1e4b..80aa006f10bb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6888,6 +6888,7 @@ F:

[PATCH 1/2] MAINTAINERS: Add a separate entry for Qualcomm Adreno GPU drivers

2024-04-22 Thread Konrad Dybcio
The msm driver is.. gigantic and covers display hardware (incl. things concerning (e)DP, DSI, HDMI), as well as the entire lineup of Adreno GPUs (with hw bringup, memory mappings, userspace interaction etc.). Because of that, people listed as M:/R: receive patches concerning drivers for any part

[PATCH 2/2] drm/msm/dsi: Remove dsi_phy_write_[un]delay()

2024-04-22 Thread Konrad Dybcio
These are dummy wrappers that do literally nothing interesting. Remove them. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 3 -- drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 3 +- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c | 81 +++--- 3

[PATCH 1/2] drm/msm/dsi: Remove dsi_phy_read/write()

2024-04-22 Thread Konrad Dybcio
These are dummy wrappers that do literally nothing interesting. Remove them. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 2 - drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 273 +--- drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c |

[PATCH 0/2] Remove more useless wrappers

2024-04-22 Thread Konrad Dybcio
Shaving off some cruft obj files seem to be identical pre and post cleanup which is always a good sign Signed-off-by: Konrad Dybcio --- Konrad Dybcio (2): drm/msm/dsi: Remove dsi_phy_read/write() drm/msm/dsi: Remove dsi_phy_write_[un]delay() drivers/gpu/drm/msm/dsi/phy/dsi_phy.h

Re: [PATCH 2/3] drm/msm/mdp4: don't destroy mdp4_kms in mdp4_kms_init error path

2024-04-22 Thread Dmitry Baryshkov
On Mon, Apr 22, 2024 at 11:17:15AM -0700, Abhinav Kumar wrote: > > > On 4/19/2024 7:33 PM, Dmitry Baryshkov wrote: > > Since commit 3c74682637e6 ("drm/msm/mdp4: move resource allocation to > > the _probe function") the mdp4_kms data is allocated during probe. It is > > an error to destroy it

Re: [PATCH 1/3] drm/msm: don't clean up priv->kms prematurely

2024-04-22 Thread Dmitry Baryshkov
On Mon, Apr 22, 2024 at 09:12:20AM -0700, Abhinav Kumar wrote: > > > On 4/21/2024 3:35 PM, Dmitry Baryshkov wrote: > > On Sat, Apr 20, 2024 at 04:02:00PM -0700, Abhinav Kumar wrote: > > > > > > > > > On 4/19/2024 7:33 PM, Dmitry Baryshkov wrote: > > > > MSM display drivers provide kms

Re: [PATCH 1/3] drm/msm: don't clean up priv->kms prematurely

2024-04-22 Thread Dmitry Baryshkov
On Mon, Apr 22, 2024 at 10:23:18AM -0700, Abhinav Kumar wrote: > > > On 4/21/2024 3:35 PM, Dmitry Baryshkov wrote: > > On Sat, Apr 20, 2024 at 04:02:00PM -0700, Abhinav Kumar wrote: > > > > > > > > > On 4/19/2024 7:33 PM, Dmitry Baryshkov wrote: > > > > MSM display drivers provide kms

Re: [PATCH 2/3] drm/msm/mdp4: don't destroy mdp4_kms in mdp4_kms_init error path

2024-04-22 Thread Abhinav Kumar
On 4/19/2024 7:33 PM, Dmitry Baryshkov wrote: Since commit 3c74682637e6 ("drm/msm/mdp4: move resource allocation to the _probe function") the mdp4_kms data is allocated during probe. It is an error to destroy it during mdp4_kms_init(), as the data is still referenced by the drivers's data and

Re: [PATCH 1/3] drm/msm: don't clean up priv->kms prematurely

2024-04-22 Thread Abhinav Kumar
On 4/21/2024 3:35 PM, Dmitry Baryshkov wrote: On Sat, Apr 20, 2024 at 04:02:00PM -0700, Abhinav Kumar wrote: On 4/19/2024 7:33 PM, Dmitry Baryshkov wrote: MSM display drivers provide kms structure allocated during probe(). Don't clean up priv->kms field in case of an error. Otherwise

Re: [PATCH 1/3] drm/msm: don't clean up priv->kms prematurely

2024-04-22 Thread Abhinav Kumar
On 4/21/2024 3:35 PM, Dmitry Baryshkov wrote: On Sat, Apr 20, 2024 at 04:02:00PM -0700, Abhinav Kumar wrote: On 4/19/2024 7:33 PM, Dmitry Baryshkov wrote: MSM display drivers provide kms structure allocated during probe(). Don't clean up priv->kms field in case of an error. Otherwise

Re: [PATCH 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-22 Thread Dmitry Baryshkov
On Mon, Apr 22, 2024 at 03:10:10PM +0300, Jani Nikula wrote: > Surprisingly many places depend on debugfs.h to be included via > drm_print.h. Fix them. > > v3: Also fix armada, ite-it6505, imagination, msm, sti, vc4, and xe > > v2: Also fix ivpu and vmwgfx > > Reviewed-by: Andrzej Hajda >

Re: [PATCH 4/9] drm/msm/dpu: move dpu_format_populate_plane_sizes to atomic_check

2024-04-22 Thread Dmitry Baryshkov
On Fri, Apr 19, 2024 at 07:37:44PM -0700, Abhinav Kumar wrote: > > > On 4/19/2024 6:34 PM, Dmitry Baryshkov wrote: > > On Fri, Apr 19, 2024 at 05:14:01PM -0700, Abhinav Kumar wrote: > > > > > > > > > On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: > > > > Move a call to

[PATCH 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-22 Thread Jani Nikula
Surprisingly many places depend on debugfs.h to be included via drm_print.h. Fix them. v3: Also fix armada, ite-it6505, imagination, msm, sti, vc4, and xe v2: Also fix ivpu and vmwgfx Reviewed-by: Andrzej Hajda Acked-by: Maxime Ripard Link:

Re: [PATCH 1/9] drm/msm/dpu: drop dpu_format_check_modified_format

2024-04-22 Thread Dmitry Baryshkov
On Fri, Apr 19, 2024 at 07:32:35PM -0700, Abhinav Kumar wrote: > > > On 4/19/2024 6:26 PM, Dmitry Baryshkov wrote: > > On Fri, Apr 19, 2024 at 04:43:20PM -0700, Abhinav Kumar wrote: > > > > > > > > > On 3/19/2024 6:21 AM, Dmitry Baryshkov wrote: > > > > The