Re: [RFC PATCH 1/4] drm/msm: register a fault handler for display mmu faults

2024-05-20 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-05-17 16:37:56) > diff --git a/drivers/gpu/drm/msm/msm_kms.c b/drivers/gpu/drm/msm/msm_kms.c > index af6a6fcb1173..62c8e6163e81 100644 > --- a/drivers/gpu/drm/msm/msm_kms.c > +++ b/drivers/gpu/drm/msm/msm_kms.c > @@ -200,6 +200,28 @@ struct msm_gem_address_space

Re: [PATCH] drm/msm: remove python 3.9 dependency for compiling msm

2024-05-20 Thread Doug Anderson
Hi, On Tue, May 7, 2024 at 4:05 PM Abhinav Kumar wrote: > > Since commit 5acf49119630 ("drm/msm: import gen_header.py script from Mesa"), > compilation is broken on machines having python versions older than 3.9 > due to dependency on argparse.BooleanOptionalAction. > > Switch to use simple bool

Re: [PATCH 08/11] drm/msm/dp: switch to struct drm_edid

2024-05-20 Thread Doug Anderson
Hi, On Sun, May 19, 2024 at 2:01 AM Dmitry Baryshkov wrote: > > On Tue, May 14, 2024 at 03:55:14PM +0300, Jani Nikula wrote: > > Prefer the struct drm_edid based functions for reading the EDID and > > updating the connector. > > > > Simplify the flow by updating the EDID property when the EDID

Re: [PATCH 08/11] drm/msm/dp: switch to struct drm_edid

2024-05-20 Thread Dmitry Baryshkov
On Mon, 20 May 2024 at 15:25, Jani Nikula wrote: > > On Sun, 19 May 2024, Dmitry Baryshkov wrote: > > On Tue, May 14, 2024 at 03:55:14PM +0300, Jani Nikula wrote: > >> Prefer the struct drm_edid based functions for reading the EDID and > >> updating the connector. > >> > >> Simplify the flow by

Re: [PATCH 08/11] drm/msm/dp: switch to struct drm_edid

2024-05-20 Thread Jani Nikula
On Sun, 19 May 2024, Dmitry Baryshkov wrote: > On Tue, May 14, 2024 at 03:55:14PM +0300, Jani Nikula wrote: >> Prefer the struct drm_edid based functions for reading the EDID and >> updating the connector. >> >> Simplify the flow by updating the EDID property when the EDID is read >> instead of

[PATCH 7/7] drm/msm/dpu: support setting the TE source

2024-05-20 Thread Dmitry Baryshkov
Make the DPU driver use the TE source specified in the DT. If none is specified, the driver defaults to the first GPIO (mdp_vsync0). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 44 - 1 file changed, 43 insertions(+), 1

[PATCH 6/7] drm/msm/dsi: parse vsync source from device tree

2024-05-20 Thread Dmitry Baryshkov
Allow board's device tree to specify the vsync source (aka TE source). If the property is omitted, the display controller driver will use the default setting. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi.h | 1 + drivers/gpu/drm/msm/dsi/dsi_host.c| 11 +++

[PATCH 3/7] drm/msm/dsi: drop unused GPIOs handling

2024-05-20 Thread Dmitry Baryshkov
Neither disp-enable-gpios nor disp-te-gpios are defined in the schema. None of the board DT files use those GPIO pins. Drop them from the driver. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_host.c | 37 - 1 file changed, 37 deletions(-)

[PATCH 5/7] drm/msm/dpu: rework vsync_source handling

2024-05-20 Thread Dmitry Baryshkov
The struct msm_display_info has is_te_using_watchdog_timer field which is neither used anywhere nor is flexible enough to specify different sources. Replace it with the field specifying the vsync source using enum dpu_vsync_source. Signed-off-by: Dmitry Baryshkov ---

[PATCH 4/7] drm/msm/dpu: pull the is_cmd_mode out of _dpu_encoder_update_vsync_source()

2024-05-20 Thread Dmitry Baryshkov
Setting vsync source makes sense only for DSI CMD panels. Pull the is_cmd_mode condition out of the function into the calling code, so that it becomes more explicit. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 2/7] drm/msm/dpu: convert vsync source defines to the enum

2024-05-20 Thread Dmitry Baryshkov
Add enum dpu_vsync_source instead of a series of defines. Use this enum to pass vsync information. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 2 +-

[PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-05-20 Thread Dmitry Baryshkov
Command mode panels provide TE signal back to the DSI host to signal that the frame display has completed and update of the image will not cause tearing. Usually it is connected to the first GPIO with the mdp_vsync function, which is the default. In such case the property can be skipped.

[PATCH 0/7] drm/msm/dpu: handle non-default TE source pins

2024-05-20 Thread Dmitry Baryshkov
Command-mode DSI panels need to signal the display controlller when vsync happens, so that the device can start sending the next frame. Some devices (Google Pixel 3) use a non-default pin, so additional configuration is required. Add a way to specify this information in DT and handle it in the DSI