[Freedreno] [PATCH] drm/msm: Slightly simplify memory allocation in submit_lookup_cmds()

If 'sz' is SIZE_MAX, kmalloc() will fail. So there is no need to explicitly check for an hypothetical overflow. Remove the check to save a few lines of code. Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/msm/msm_gem_submit.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions

[Freedreno] [PATCH v2] drm/msm/hdmi: Fix the error handling path of msm_hdmi_dev_probe()

If an error occurs after a successful msm_hdmi_get_phy() call, it must be undone by a corresponding msm_hdmi_put_phy(), as already done in the remove function. Fixes: 437365464043 ("drm/msm/hdmi: move msm_hdmi_get_phy() to msm_hdmi_dev_probe()") Signed-off-by: Christophe JAILLET

[Freedreno] [PATCH] drm/msm/hdm: Fix the error handling path of msm_hdmi_dev_probe()

If an error occurs after a successful msm_hdmi_get_phy() call, it must be undone by a corresponding msm_hdmi_put_phy(), as already done in the remove function. Fixes: 437365464043 ("drm/msm/hdmi: move msm_hdmi_get_phy() to msm_hdmi_dev_probe()") Signed-off-by: Christophe JAILLET --

Re: [Freedreno] [PATCH] drm/msm/dp: Fix a potential double free in an error handling path

Le 05/01/2022 à 21:09, Stephen Boyd a écrit : Quoting Christophe JAILLET (2021-12-26 07:14:05) 'dp_bridge' is devm_alloc'ed, so there is no need to free it explicitly or there will be a double free(). Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable and di

[Freedreno] [PATCH] drm/msm/dp: Fix a potential double free in an error handling path

'dp_bridge' is devm_alloc'ed, so there is no need to free it explicitly or there will be a double free(). Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable and disable") Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/msm/dp/dp_drm.c | 1 - 1 file

[Freedreno] [PATCH] drm/msm/dp: Simplify dp_debug_init() and dp_debug_get()

dp_debug_init() always returns 0. So, make it a void function and simplify the only caller accordingly. While at it remove a useless 'rc' initialization in dp_debug_get() Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/msm/dp/dp_debug.c | 13 +++-- 1 file changed, 3 insertions

[Freedreno] [PATCH] drm: Remove redundant 'flush_workqueue()' calls

-by: Christophe JAILLET --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 1 - drivers/gpu/drm/msm/dsi/dsi_host.c| 1 - drivers/gpu/drm/msm/edp/edp_ctrl.c| 1 - drivers/gpu/drm/msm/hdmi/hdmi.c | 4 +--- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 +--- drivers/gpu/drm/vmwgfx/ttm_memory.c | 1 - 6

[Freedreno] [PATCH] drm/msm/dsi: Fix some reference counted resource leaks

device()' to solve both issues. Fixes: ec31abf6684e ("drm/msm/dsi: Separate PHY to another platform device") Signed-off-by: Christophe JAILLET --- Review carefully, management of reference counted resources is sometimes tricky. --- drivers/gpu/drm/msm/dsi/dsi.c | 6 +++--- 1 file changed, 3

[Freedreno] [PATCH] drm/msm: Fix typo

Duplicated 'we' Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c index 998bef1190a3..b5fed67c4651 100644

[Freedreno] [PATCH] drm/msm: Fix an error handling path 'msm_drm_init()'

If this memory allocation fails, we have to go through the error handling path to perform some clean-up, as already done in other other paths of this function. Fixes: db735fc4036b ("drm/msm: Set dma maximum segment size for mdss") Signed-off-by: Christophe JAILLET --- drivers/g

[Freedreno] [PATCH] drm/msm/a6xx: Fix a typo in an error message

'in' is duplicated in the error message. Axe one of them. While at it, slighly improve indentation. Signed-off-by: Christophe JAILLET --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b

[Freedreno] [PATCH] drm/msm/dsi: Fix the releasing of resources in error path in 'dsi_bus_clk_enable()'

ces correctly. Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index 1fc07ce24686..eac4987f39